From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.6 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2A7EDC432C0 for ; Tue, 19 Nov 2019 22:07:45 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id E04EB20643 for ; Tue, 19 Nov 2019 22:07:44 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="TmoEW5Gc" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727333AbfKSWHo (ORCPT ); Tue, 19 Nov 2019 17:07:44 -0500 Received: from mail-lj1-f193.google.com ([209.85.208.193]:37071 "EHLO mail-lj1-f193.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727140AbfKSWHo (ORCPT ); Tue, 19 Nov 2019 17:07:44 -0500 Received: by mail-lj1-f193.google.com with SMTP id d5so25150505ljl.4; Tue, 19 Nov 2019 14:07:41 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=/NIY0wwmd8kAAZ+E6bHh2DYRDKjCV9YXkhsBIS0hJcs=; b=TmoEW5GcPBJMZqxK1rUqJR+pE+JkTQcZyhd9lOiEtnWQEuFPNrgX5RYkHLUP9k2dzB F4v4WkOhxv2utmOmoTqSNP5+evY5Tmy6uMdT9Q34YFY0Cx6LLn9ru8FaoWrd0IJm7HNi IwWzM59zcT00oGu7h+67Osw+f47swWpY3WSsj5LoLK0A36rTSGInVPFWkWvMOc7TduUe Rkw/epEcJCLQd8Ry59u/bRUDt6kN+1ycbwiMu8u+/wZTn+ISKto9UYEniYR8N7r9I3fr iW3sKN+rAi2seboekh8qieg6ZU+am7W8u4iHTQMH85GfLVc0xFKEZ3ZPj19FwgK+9PPQ Hi8Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=/NIY0wwmd8kAAZ+E6bHh2DYRDKjCV9YXkhsBIS0hJcs=; b=V3zfMBzN6JQTjeHDh/YwbkerSHx2rGL1Gsb0TN9dlaUHYURifgNfNxcbM1X7Q53V5s sfh4/8ee7bcRuuwXqVgoXVUY/yFrfsrgzglA+xOl+77LpDqq9NoWgYJi8ODMA+IZZUIt X+Ywe01LMEL7cd5WCyOp4w9dMczlcbdy8pRYA8KLg6WCq2DBGh5+dt62aIn43EZiFDaN vJENq9K+1uo8OzYw6aPVW77IG9TR+3ECGUplLviidWGOV8U8ZMP1xwAD0p0MY//l1iyL Nd2tVZE0appwjMR6Vc+WgXshof2VI2e2HCt9bcKRx+ZH0ROgs0zUhbh6HxZ3MPH3lkYC 9kZw== X-Gm-Message-State: APjAAAUWCAZak4yDXvR2KRzwus74fZYgvJAlj2h2wOozS2qL2quqHLDg 3oPp/gm3jdBmiui0nirZ7pCF0IlyUXOFO+1/wWM= X-Google-Smtp-Source: APXvYqyoQLekI+Vh3I0S26z+Ix5Ed7Z6kLQCJi/wzt6okOYA5unIq30BI/YrCgYtnyaqmaVRPh68qgdfUOqklLCj8As= X-Received: by 2002:a2e:b5b8:: with SMTP id f24mr5665605ljn.188.1574201260547; Tue, 19 Nov 2019 14:07:40 -0800 (PST) MIME-Version: 1.0 References: <20191119001951.92930-1-lrizzo@google.com> <20191119140301.6ff669e1@cakuba.netronome.com> In-Reply-To: <20191119140301.6ff669e1@cakuba.netronome.com> From: Alexei Starovoitov Date: Tue, 19 Nov 2019 14:07:28 -0800 Message-ID: Subject: Re: [PATCH v2] net-af_xdp: use correct number of channels from ethtool To: Jakub Kicinski Cc: Luigi Rizzo , "Karlsson, Magnus" , =?UTF-8?B?QmrDtnJuIFTDtnBlbA==?= , Jonathan Lemon , Network Development , bpf , rizzo@iet.unipi.it Content-Type: text/plain; charset="UTF-8" Sender: bpf-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: bpf@vger.kernel.org On Tue, Nov 19, 2019 at 2:04 PM Jakub Kicinski wrote: > > On Mon, 18 Nov 2019 16:19:51 -0800, Luigi Rizzo wrote: > > Drivers use different fields to report the number of channels, so take > > the maximum of all data channels (rx, tx, combined) when determining the > > size of the xsk map. The current code used only 'combined' which was set > > to 0 in some drivers e.g. mlx4. > > > > Tested: compiled and run xdpsock -q 3 -r -S on mlx4 > > Signed-off-by: Luigi Rizzo > > Reviewed-by: Jakub Kicinski Applied. Thanks