From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.6 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B3309CA9EB6 for ; Wed, 23 Oct 2019 17:19:12 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 8BA2421929 for ; Wed, 23 Oct 2019 17:19:12 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="IXEvy/Cs" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728733AbfJWRTM (ORCPT ); Wed, 23 Oct 2019 13:19:12 -0400 Received: from mail-lj1-f193.google.com ([209.85.208.193]:39729 "EHLO mail-lj1-f193.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728549AbfJWRTL (ORCPT ); Wed, 23 Oct 2019 13:19:11 -0400 Received: by mail-lj1-f193.google.com with SMTP id y3so21945418ljj.6; Wed, 23 Oct 2019 10:19:10 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc:content-transfer-encoding; bh=DnypHcyiSmDYpsEnrDTzJLRsh2gQEWlfzVr6c4JGW3s=; b=IXEvy/Cs3F9Yw8kyCFMhSn+IrR/NXoG5FUCcrmhgxsxYeM32T0bAZWB5BSSGb5FQeQ ic5Rr4dM4ZPwQ8pzEvB8yyOMZDhv6J0BRJ0XrBNqgtODlOwjvjXmj78gdcfdIzktgPsw C0V59cUWLFMOrHqlw64fz/uQCuANctsbTbS7SDEpK7CSz0lRLQYEvsrFu1WxKJmw4onP 5tU8wbryvjWcV8J178St8tD2bIzl8teG86w3r6f7C34EvaM9/ZkDwY7rCa5pXAjcm6qL wod1T1qUgG8L4CDU8T6/D0/izlClk0wg6h+c19Uw5gyI6Bl2jx/eAvAYgHIQETcf9vHt sKSQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=DnypHcyiSmDYpsEnrDTzJLRsh2gQEWlfzVr6c4JGW3s=; b=q/hMHfdCT14TYgcJWIPwIYbYMfjdMMBt01DDZfvHcFG0xgzoY/XdiF3ZPUz8W9up6p 9eOefk75ySlORyRd2smxIHqEIyvV94UaGoWOIIPTBioxIy2qbSkWmYVorEFxeDLPqVWo 7QeAUAeLAz26pOmiQ2NRDCPp1D2lym/5Roc5nbqx4AY54Eblv/wNROPiYRwpe7v6WZjz 5GFBwExUjkLOZGwiCf4VljwVabYQdreVY8FsZPlA5qtzr5PMrD+FX9yyZwageMs/nop3 1GeaXaoCMa4My4iWgL6o2ZYct1mblo+e1p4gQOysT+iCoC/lsQ4Lrw/fRwwLFidfwA5d RBCQ== X-Gm-Message-State: APjAAAXDBZIazYBJhDHzKQJQTWV0+tjc4a5gyvaYLIuWDq7t5s1d8N+r gBIbKA5IxLnm9bhEXR/43ekoJMnGALxMJTRNGeI= X-Google-Smtp-Source: APXvYqytM3ljI+jWm3E+FZrjToihDhEk8GstYb412o1d3uBbgrjAaU2m0S2ecGjhHvSgvnPxlWWM1qTMQcAeO5jGqDE= X-Received: by 2002:a2e:9b12:: with SMTP id u18mr23724844lji.142.1571851149345; Wed, 23 Oct 2019 10:19:09 -0700 (PDT) MIME-Version: 1.0 References: <20191023154038.24075-1-kpsingh@chromium.org> In-Reply-To: <20191023154038.24075-1-kpsingh@chromium.org> From: Alexei Starovoitov Date: Wed, 23 Oct 2019 10:18:57 -0700 Message-ID: Subject: Re: [PATCH bpf-next v2] libbpf: Fix strncat bounds error in libbpf_prog_type_by_name To: KP Singh Cc: LKML , bpf , Alexei Starovoitov , Daniel Borkmann , Martin KaFai Lau , Song Liu , Yonghong Song , Florent Revest Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Sender: bpf-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: bpf@vger.kernel.org On Wed, Oct 23, 2019 at 8:40 AM KP Singh wrote: > > From: KP Singh > > On compiling samples with this change, one gets an error: > > error: =E2=80=98strncat=E2=80=99 specified bound 118 equals destination = size > [-Werror=3Dstringop-truncation] > > strncat(dst, name + section_names[i].len, > ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ > sizeof(raw_tp_btf_name) - (dst - raw_tp_btf_name)); > ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ > > strncat requires the destination to have enough space for the > terminating null byte. > > Fixes: f75a697e09137 ("libbpf: Auto-detect btf_id of BTF-based raw_tracep= oint") > Signed-off-by: KP Singh Applied. Thanks