From: Alexei Starovoitov <alexei.starovoitov@gmail.com>
To: Jonathan Lemon <jonathan.lemon@gmail.com>
Cc: "Magnus Karlsson" <magnus.karlsson@intel.com>,
"Björn Töpel" <bjorn.topel@intel.com>,
"Alexei Starovoitov" <ast@kernel.org>,
"Daniel Borkmann" <daniel@iogearbox.net>,
"Network Development" <netdev@vger.kernel.org>,
rgoodfel@isi.edu, bpf <bpf@vger.kernel.org>
Subject: Re: [PATCH bpf-next] xsk: support allocations of large umems
Date: Wed, 15 Jan 2020 11:43:45 -0800 [thread overview]
Message-ID: <CAADnVQJOQ1mnxNLwQykYK5brY=_xvjeYJFJZcf_v-zyAni9qKA@mail.gmail.com> (raw)
In-Reply-To: <F5A36D1D-633C-4CDB-A49D-71DE73E26963@gmail.com>
On Wed, Jan 15, 2020 at 11:10 AM Jonathan Lemon
<jonathan.lemon@gmail.com> wrote:
>
>
>
> On 14 Jan 2020, at 1:49, Magnus Karlsson wrote:
>
> > When registering a umem area that is sufficiently large (>1G on an
> > x86), kmalloc cannot be used to allocate one of the internal data
> > structures, as the size requested gets too large. Use kvmalloc instead
> > that falls back on vmalloc if the allocation is too large for kmalloc.
> >
> > Also add accounting for this structure as it is triggered by a user
> > space action (the XDP_UMEM_REG setsockopt) and it is by far the
> > largest structure of kernel allocated memory in xsk.
> >
> > Signed-off-by: Magnus Karlsson <magnus.karlsson@intel.com>
> > Reported-by: Ryan Goodfellow <rgoodfel@isi.edu>
>
> Acked-by: Jonathan Lemon <jonathan.lemon@gmail.com>
Applied. Thanks
prev parent reply other threads:[~2020-01-15 19:43 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-14 9:49 [PATCH bpf-next] xsk: support allocations of large umems Magnus Karlsson
2020-01-15 19:10 ` Jonathan Lemon
2020-01-15 19:43 ` Alexei Starovoitov [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAADnVQJOQ1mnxNLwQykYK5brY=_xvjeYJFJZcf_v-zyAni9qKA@mail.gmail.com' \
--to=alexei.starovoitov@gmail.com \
--cc=ast@kernel.org \
--cc=bjorn.topel@intel.com \
--cc=bpf@vger.kernel.org \
--cc=daniel@iogearbox.net \
--cc=jonathan.lemon@gmail.com \
--cc=magnus.karlsson@intel.com \
--cc=netdev@vger.kernel.org \
--cc=rgoodfel@isi.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).