bpf.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Alexei Starovoitov <alexei.starovoitov@gmail.com>
To: Andrey Ignatov <rdna@fb.com>
Cc: Song Liu <songliubraving@fb.com>, bpf <bpf@vger.kernel.org>,
	Alexei Starovoitov <ast@kernel.org>,
	Daniel Borkmann <daniel@iogearbox.net>,
	Kernel Team <Kernel-team@fb.com>
Subject: Re: [PATCH bpf-next] bpf: Document BPF_F_QUERY_EFFECTIVE flag
Date: Thu, 9 Jan 2020 09:41:44 -0800	[thread overview]
Message-ID: <CAADnVQJOZK380e8=vbkfNuG3xu375CJfrPmWH6Pf7ptB1LngYA@mail.gmail.com> (raw)
In-Reply-To: <20200108171949.GA96819@rdna-mbp.dhcp.thefacebook.com>

On Wed, Jan 8, 2020 at 9:20 AM Andrey Ignatov <rdna@fb.com> wrote:
>
> Song Liu <songliubraving@fb.com> [Wed, 2020-01-08 08:31 -0800]:
> [...]
> > > diff --git a/include/uapi/linux/bpf.h b/include/uapi/linux/bpf.h
> > > index 7df436da542d..dc4b8a2d2a86 100644
> > > --- a/include/uapi/linux/bpf.h
> > > +++ b/include/uapi/linux/bpf.h
> > > @@ -357,7 +357,12 @@ enum bpf_attach_type {
> > > /* Enable memory-mapping BPF map */
> > > #define BPF_F_MMAPABLE              (1U << 10)
> > >
> > > -/* flags for BPF_PROG_QUERY */
> > > +/* Flags for BPF_PROG_QUERY. */
> > > +
> > > +/* Query effective (directly attached + inherited from ancestor cgroups)
> > > + * programs that will be executed for events within a cgroup.
> > > + * attach_flags with this flag are returned only for directly attached programs.
> >
> > This line is more than 75 byte long, I guess ./scripts/checkpatch.pl would
> > complain about it?
>
> I run checkpatch.pl before sending it but it didn't complain:
>
>   % scripts/checkpatch.pl p/0001-bpf-Document-BPF_F_QUERY_EFFECTIVE-flag.patch
>   total: 0 errors, 0 warnings, 26 lines checked
>
>   p/0001-bpf-Document-BPF_F_QUERY_EFFECTIVE-flag.patch has no obvious style problems and is ready for submission.
>
> I haven't debugged why, but this header has plenty of lines like this:
>
>   % awk 'length($0) >= 75' include/uapi/linux/bpf.h | wc -l
>   74

Applied. Thanks

      reply	other threads:[~2020-01-09 17:41 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-01-08  1:40 [PATCH bpf-next] bpf: Document BPF_F_QUERY_EFFECTIVE flag Andrey Ignatov
2020-01-08 16:31 ` Song Liu
2020-01-08 17:19   ` Andrey Ignatov
2020-01-09 17:41     ` Alexei Starovoitov [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAADnVQJOZK380e8=vbkfNuG3xu375CJfrPmWH6Pf7ptB1LngYA@mail.gmail.com' \
    --to=alexei.starovoitov@gmail.com \
    --cc=Kernel-team@fb.com \
    --cc=ast@kernel.org \
    --cc=bpf@vger.kernel.org \
    --cc=daniel@iogearbox.net \
    --cc=rdna@fb.com \
    --cc=songliubraving@fb.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).