From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.7 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A8623C433E0 for ; Fri, 12 Feb 2021 02:06:52 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 6F08E64E44 for ; Fri, 12 Feb 2021 02:06:52 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229684AbhBLCGg (ORCPT ); Thu, 11 Feb 2021 21:06:36 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:48508 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229521AbhBLCGf (ORCPT ); Thu, 11 Feb 2021 21:06:35 -0500 Received: from mail-lj1-x22b.google.com (mail-lj1-x22b.google.com [IPv6:2a00:1450:4864:20::22b]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id C927DC061574; Thu, 11 Feb 2021 18:05:54 -0800 (PST) Received: by mail-lj1-x22b.google.com with SMTP id q14so9829156ljp.4; Thu, 11 Feb 2021 18:05:54 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=OiSkEcgchNsmSgBtf3fnMQzPIwmJ5tn4k1eUNo1HXyg=; b=ZBl8t/0TZL9DZivfE/IbgOPqpTHjguBG9nvWcvcI2fWez4rQfe6X4x3np/lGkOMV8d HN+C2nPfeG8ecfuKiA3rrSJMCkZuRuXivK6wzi3Gg1B8odvsfCp0DbhDpDAcflj170Yi v9kerAdvli1XESufLDKL5vZ2wJ1/m+MQSUB2Foc29vfhkiQyVxFaGMWyIVjdbMNJPbCC 76LEPPhaDLD/2j/Q89DT6FZzt9Cm1JpyOP/Od+RpgNvDOawyVIKewDrnROnlaM6VMwNh t10A6jQDJSON+KrouGv/Eui7AIg9RmChd2KHXa0fucBiKJHEh6TNs7e4xKf7B2z8pizo whCA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=OiSkEcgchNsmSgBtf3fnMQzPIwmJ5tn4k1eUNo1HXyg=; b=qQS6rxqcfkANpbW6KdgGJpvnhhUpeqnctsH70cOudWeBstGaqFnv5+F0OqWjWpFygm go2Zy4d8n4/FTATLcrKJ5Zh5COyLkRqY7Fv5JSKA2hICNw8JSoK5FRDqlrleby0zOIUo MRYOdDhyBqSnFqW9zKX+WgMnMNVPLIMlL/4hEA47yI2ScuUhYaPZxv/0f5yMRNhTcjmh G9mwDXOHFc2MfpXOFWj4b1ElXZlcWYirpKj7NHGqt+sc5QJybnTarhnpYJ3mV4Ri6jxS i4ixT1kJktc4lWf7gfN2Cev79e14+z0VMUYcN8X32b2cRhvHx/aBd+FJGc6hn27KD383 Byvg== X-Gm-Message-State: AOAM533kmkDkhCkkLxrwI/Yex9P9IPZt3cc8bkz6wDZXxEn1LEbyxczh B6rgB2wzOGwxXJJPtI22KBLgz/xOI2qrflkMx9nZtMBWU1g= X-Google-Smtp-Source: ABdhPJwKXqZN2gQ+HMFhDevuqT9eVhQMLKz5LWoKxPET6Lm95PKNH0TkH+6IOxIe8x5GzJC32PyD42Jith/zeyTT4Wo= X-Received: by 2002:a2e:700c:: with SMTP id l12mr371556ljc.236.1613095553180; Thu, 11 Feb 2021 18:05:53 -0800 (PST) MIME-Version: 1.0 References: <20201204102901.109709-1-marekx.majtyka@intel.com> <20201209125223.49096d50@carbon> <1e5e044c8382a68a8a547a1892b48fb21d53dbb9.camel@kernel.org> <6f8c23d4ac60525830399754b4891c12943b63ac.camel@kernel.org> <87h7mvsr0e.fsf@toke.dk> <87bld2smi9.fsf@toke.dk> <20210202113456.30cfe21e@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com> <20210203090232.4a259958@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com> <874kikry66.fsf@toke.dk> <20210210103135.38921f85@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com> <87czx7r0w8.fsf@toke.dk> <20210211172603.17d6a8f6@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com> In-Reply-To: <20210211172603.17d6a8f6@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com> From: Alexei Starovoitov Date: Thu, 11 Feb 2021 18:05:41 -0800 Message-ID: Subject: Re: [PATCH v2 bpf 1/5] net: ethtool: add xdp properties flag set To: Jakub Kicinski Cc: =?UTF-8?B?VG9rZSBIw7hpbGFuZC1Kw7hyZ2Vuc2Vu?= , Marek Majtyka , Saeed Mahameed , David Ahern , Maciej Fijalkowski , John Fastabend , Jesper Dangaard Brouer , Daniel Borkmann , Maciej Fijalkowski , =?UTF-8?B?QmrDtnJuIFTDtnBlbA==?= , Andrii Nakryiko , Jonathan Lemon , Alexei Starovoitov , Network Development , "David S. Miller" , Jesper Dangaard Brouer , bpf , intel-wired-lan , "Karlsson, Magnus" , Jeff Kirsher Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: bpf@vger.kernel.org On Thu, Feb 11, 2021 at 5:26 PM Jakub Kicinski wrote: > > Perhaps I had seen one too many vendor incompatibility to trust that > adding a driver API without a validation suite will result in something > usable in production settings. I agree with Jakub. I don't see how extra ethtool reporting will help. Anyone who wants to know whether eth0 supports XDP_REDIRECT can already do so: ethtool -S eth0 | grep xdp_redirect I think converging on the same stat names across the drivers will make the whole thing much more user friendly than new apis.