From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.6 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,MENTIONS_GIT_HOSTING, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 30FC9C432C0 for ; Thu, 28 Nov 2019 00:59:30 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 040CB2158A for ; Thu, 28 Nov 2019 00:59:30 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="dct7JSOO" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727176AbfK1A73 (ORCPT ); Wed, 27 Nov 2019 19:59:29 -0500 Received: from mail-lj1-f196.google.com ([209.85.208.196]:47033 "EHLO mail-lj1-f196.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726984AbfK1A73 (ORCPT ); Wed, 27 Nov 2019 19:59:29 -0500 Received: by mail-lj1-f196.google.com with SMTP id e9so26497546ljp.13; Wed, 27 Nov 2019 16:59:27 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=GlDsn7TqBs4w48Ao28vIPY+vTJ4FRLpQy82LHAO9FtM=; b=dct7JSOOxj7fmLcV6CatAbFkMkk+UoveZkp97Ar7akOPlhi8ZWJjP/o4CXp431UR+N luuDF+9IQPZooAfD62gbrYgCgQCevKJD9tE0gZ44JMcdYXWEXrGT7wzkva7n+koICphB 5bv2C8OHfCi4xq3Ru4/NPktJc/rNzrZeU8j5SR5e39AciMEWkXHN728967uZm+NFLpWF 0Gch3jGmwIfMcWCWrjr8B3jEWbu2PENANkdrtMV87F4xKFXztqbc1uES+Em/0KkU9cNk 4XIV5uwTpMr2wodZeqXhwzkw1jdu7hBok2fBoFU0g5Rww+7tzz4H5lX3bRdnroAIKDzs vFKg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=GlDsn7TqBs4w48Ao28vIPY+vTJ4FRLpQy82LHAO9FtM=; b=D6M3Nvv1oD3Kfwyne+z5SHtCJ5FXvyHy4RU8dUSGoYwZLF7R/QXdQrJ3xQvI1OlBVX SJBZBaRtA159rOe7TRFiYet6613nn5uuK0/YvLbunb54QqWb3iM/E7vjWyJFD0t6QL3G w1YeXd/ljDdYb7NShVSz785qAcspJEXOmH5oz1eh/mlkF8adJFnTMgEIWdRXgbKh4odd oAyZtmULMmihzA59/EfOQuD47xpd0rmRoi+5uMjhKOKGnXHmN/ahZLIwd53/vRoY1ZlV glFbi6SVyk1pjQZJUDtgxkPgDoiajZhxr0gruv541chjosjsmpP6NL7K0ubNun1yjm8S vS9w== X-Gm-Message-State: APjAAAWO7JfukhxsQzAmSEI9Y0n4YTmpyWDC57XDP4P8wvyqhpz+fko9 +QmRrbcxJSQ8XuZZMEVyQ7aXhf9phS/4IpADCKU= X-Google-Smtp-Source: APXvYqxVO2dwVk/p7oC6P4ANvvZYmBGLPU6Bnady0f0cJ8kbFRAMU3/QWKWq4fr0Qbz/MbrXG5uh3N+OTfw63e9A9Uk= X-Received: by 2002:a2e:8508:: with SMTP id j8mr32148600lji.136.1574902766702; Wed, 27 Nov 2019 16:59:26 -0800 (PST) MIME-Version: 1.0 References: <87imn6y4n9.fsf@toke.dk> <20191126183451.GC29071@kernel.org> <87d0dexyij.fsf@toke.dk> <20191126190450.GD29071@kernel.org> <20191126221018.GA22719@kernel.org> <20191126221733.GB22719@kernel.org> <20191126231030.GE3145429@mini-arch.hsd1.ca.comcast.net> <20191126155228.0e6ed54c@cakuba.netronome.com> <20191127013901.GE29071@kernel.org> <2993CDB0-8D4D-4A0C-9DB2-8FDD1A0538AB@kernel.org> In-Reply-To: <2993CDB0-8D4D-4A0C-9DB2-8FDD1A0538AB@kernel.org> From: Alexei Starovoitov Date: Wed, 27 Nov 2019 16:59:15 -0800 Message-ID: Subject: Re: [PATCH] libbpf: Fix up generation of bpf_helper_defs.h To: Arnaldo Carvalho de Melo Cc: Jakub Kicinski , Stanislav Fomichev , Andrii Nakryiko , =?UTF-8?B?VG9rZSBIw7hpbGFuZC1Kw7hyZ2Vuc2Vu?= , Andrii Nakryiko , Adrian Hunter , Alexei Starovoitov , Daniel Borkmann , Jiri Olsa , Martin KaFai Lau , Namhyung Kim , bpf , Networking , linux-perf-users@vger.kernel.org, Linux Kernel Mailing List , Quentin Monnet Content-Type: text/plain; charset="UTF-8" Sender: bpf-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: bpf@vger.kernel.org On Wed, Nov 27, 2019 at 4:50 PM Arnaldo Carvalho de Melo wrote: > > Take it as one, I think it's what should have been in the cset it is fixing, that way no breakage would have happened. Ok. I trimmed commit log and applied here: https://git.kernel.org/pub/scm/linux/kernel/git/bpf/bpf.git/commit/?id=1fd450f99272791df8ea8e1b0f5657678e118e90 What about your other fix and my suggestion there? (__u64) cast instead of PRI ? We do this already in two places: libbpf.c: shdr_idx, (__u64)sym->st_value); libbpf.c: (__u64)sym.st_value, GELF_ST_TYPE(sym.st_info),