From: Alexei Starovoitov <alexei.starovoitov@gmail.com>
To: "Tyler Wear (QUIC)" <quic_twear@quicinc.com>
Cc: "Network Development" <netdev@vger.kernel.org>,
bpf <bpf@vger.kernel.org>,
"Maciej Żenczykowski" <maze@google.com>,
"Yonghong Song" <yhs@fb.com>, "Martin KaFai Lau" <kafai@fb.com>,
"Toke Høiland-Jørgensen" <toke@redhat.com>,
"Daniel Borkmann" <daniel@iogearbox.net>,
"Song Liu" <song@kernel.org>
Subject: Re: [PATCH bpf-next v6 1/2] Add skb_store_bytes() for BPF_PROG_TYPE_CGROUP_SKB
Date: Thu, 13 Jan 2022 22:55:24 -0800 [thread overview]
Message-ID: <CAADnVQJc=qgz47S1OuUBmX5Rb_opZUCADKqzqGnBruxtJONO7Q@mail.gmail.com> (raw)
In-Reply-To: <BYAPR02MB5238AEC23C7287A41C44C307AA549@BYAPR02MB5238.namprd02.prod.outlook.com>
On Thu, Jan 13, 2022 at 10:49 PM Tyler Wear (QUIC)
<quic_twear@quicinc.com> wrote:
>
> > > This is wrong.
> > > CGROUP_INET_EGRESS bpf prog cannot arbitrary change packet data.
> > > The networking stack populated the IP header at that point.
> > > If the prog changes it to something else it will be confusing other
> > > layers of stack. neigh(L2) will be wrong, etc.
> > > We can still change certain things in the packet, but not arbitrary bytes.
> > >
> > > We cannot change the DS field directly in the packet either.
> > > It can only be changed by changing its value in the socket.
> >
> > Why is the DS field unchangeable, but ecn is changeable?
>
> Per spec the requirement is to modify the ds field of egress packets with DSCP value. Setting ds field on socket will not suffice here.
> Another case is where device is a middle-man and needs to modify the packets of a connected tethered client with the DSCP value, using a sock will not be able to change the packet here.
If DS field needs to be changed differently for every packet
it's better to use TC layer for this task.
qdiscs may send packets with different DSs to different queues.
next prev parent reply other threads:[~2022-01-14 6:55 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-01-13 0:06 [PATCH bpf-next v6 1/2] Add skb_store_bytes() for BPF_PROG_TYPE_CGROUP_SKB Tyler Wear
2022-01-13 0:06 ` [PATCH bpf-next v6 2/2] selftests/bpf: CGROUP_SKB test for skb_store_bytes() Tyler Wear
2022-01-13 0:55 ` Song Liu
2022-01-13 0:43 ` [PATCH bpf-next v6 1/2] Add skb_store_bytes() for BPF_PROG_TYPE_CGROUP_SKB Song Liu
2022-01-13 2:14 ` Alexei Starovoitov
2022-01-13 5:12 ` Tyler Wear
2022-01-14 6:49 ` Tyler Wear (QUIC)
2022-01-14 6:55 ` Alexei Starovoitov [this message]
2022-01-14 21:18 ` Maciej Żenczykowski
2022-01-18 20:37 ` Alexei Starovoitov
2022-01-18 22:23 ` Tyler Wear
2022-01-18 22:31 ` Alexei Starovoitov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAADnVQJc=qgz47S1OuUBmX5Rb_opZUCADKqzqGnBruxtJONO7Q@mail.gmail.com' \
--to=alexei.starovoitov@gmail.com \
--cc=bpf@vger.kernel.org \
--cc=daniel@iogearbox.net \
--cc=kafai@fb.com \
--cc=maze@google.com \
--cc=netdev@vger.kernel.org \
--cc=quic_twear@quicinc.com \
--cc=song@kernel.org \
--cc=toke@redhat.com \
--cc=yhs@fb.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).