From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.6 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 79037C433DF for ; Wed, 27 May 2020 22:23:29 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 51BC02084C for ; Wed, 27 May 2020 22:23:29 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="ikxz+wtq" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1725768AbgE0WX3 (ORCPT ); Wed, 27 May 2020 18:23:29 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:33732 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725446AbgE0WX2 (ORCPT ); Wed, 27 May 2020 18:23:28 -0400 Received: from mail-lj1-x242.google.com (mail-lj1-x242.google.com [IPv6:2a00:1450:4864:20::242]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 56E54C05BD1E; Wed, 27 May 2020 15:23:26 -0700 (PDT) Received: by mail-lj1-x242.google.com with SMTP id c11so28776114ljn.2; Wed, 27 May 2020 15:23:26 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=oDUCdw/ayIiyqDGiRwy24Togh8qSAsEHJq3kdKNjy6E=; b=ikxz+wtqcz/ix6joyxaUeYfQteyOLp04oMU8aJNHvQnZFbC9bWtbG1YytzuVFhW7H5 v+O7FfJ+cIfAxN0yjNGeg6pplAK8DwxGrqi/BjwaVQKPVGxUSi8mfwZvRtspfetStYV9 ox5CabBJjOpPZzRG6SA6pvEveJ4NU7jx9XKLQ6Drk6tJBDUDDyVZgy2Ra9hrOCp+zYTw k2m/P6ArpEIVCxXj7j8he3Qt6YgUyJeTv02WQYhPScomjaJsUrIV2pQlKSjgcqWDPWAc zTGXUWpDvHrMlX/0OvjuTlyX2Al1yHuQe1paZm/bLenHB7dISjOXZ1T1o58tu866OC76 qZDg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=oDUCdw/ayIiyqDGiRwy24Togh8qSAsEHJq3kdKNjy6E=; b=QMMcE8aHeFhzhiyWMSnpfTW9wbYbhtF5GaUr4XsKX2KGlMj8aNhGKIfFRfc0xhDrn4 0qn063BMMqjYg2snWUdkq2HC42xr/U9Wva9u90Yf0vytS/3hsNmqCKv4x9sbRJSJFSgD gYQ1T9ccOPwDoGktJPZV+wkwz4HEPoifSasX73bK+JH44OmFCXlODRMIXAcNaY8LfevB 5hSIcuIT3YrPIYIalGtMAZSiNVqStoZTtR4gqThxhljNOY6AhvX8YIZyiIx6WWnto+pI XaBCKk+/OlYK3a9Rc+G8Fia5s7jvFgUX9y/Ou+GGSjbIH+NB3oX5LyfrJv1ackYPb5tX IRtA== X-Gm-Message-State: AOAM5328mebKTww9zNi/K9pTcAk0dLo5pycTDTWNPpJgso6IE/lx+3kI R7zgeNyw21jHaxCTAn9h5fYZXQfSeSSwad3dfM0= X-Google-Smtp-Source: ABdhPJz2YfTgfRMaHeZNPMoqZ6BxheRpJKYAN/tJKTVlw8s7jqed1pa8mFXkVP0vF4UtBXfQUQeu8+/snV7j/b2NWj0= X-Received: by 2002:a2e:150e:: with SMTP id s14mr3716381ljd.290.1590618204753; Wed, 27 May 2020 15:23:24 -0700 (PDT) MIME-Version: 1.0 References: <20200522081901.238516-1-yauheni.kaliuta@redhat.com> In-Reply-To: From: Alexei Starovoitov Date: Wed, 27 May 2020 15:23:13 -0700 Message-ID: Subject: Re: [PATCH] selftests/bpf: split -extras target to -static and -gen To: shuah Cc: Yauheni Kaliuta , Andrii Nakryiko , bpf , Jiri Benc , Jiri Olsa , Andrii Nakryiko , Daniel Borkmann , "open list:KERNEL SELFTEST FRAMEWORK" Content-Type: text/plain; charset="UTF-8" Sender: bpf-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: bpf@vger.kernel.org On Wed, May 27, 2020 at 3:01 PM shuah wrote: > > On 5/27/20 11:05 AM, Alexei Starovoitov wrote: > > On Wed, May 27, 2020 at 10:02 AM Yauheni Kaliuta > > wrote: > >> > >> Hi, Alexei! > >> > >>>>>>> On Wed, 27 May 2020 09:48:04 -0700, Alexei Starovoitov wrote: > >> > >> > On Wed, May 27, 2020 at 12:19 AM Yauheni Kaliuta > >> > wrote: > >> >> > >> >> Hi, Alexei! > >> >> > >> >> >>>>> On Tue, 26 May 2020 22:37:39 -0700, Alexei Starovoitov wrote: > >> >> > >> >> > On Tue, May 26, 2020 at 10:31 PM Yauheni Kaliuta > >> >> > wrote: > >> >> >> > >> >> >> Hi, Andrii! > >> >> >> > >> >> >> >>>>> On Tue, 26 May 2020 17:19:18 -0700, Andrii Nakryiko wrote: > >> >> >> > >> >> >> > On Fri, May 22, 2020 at 1:19 AM Yauheni Kaliuta > >> >> >> > wrote: > >> >> >> >> > >> >> >> >> There is difference in depoying static and generated extra resource > >> >> >> >> files between in/out of tree build and flavors: > >> >> >> >> > >> >> >> >> - in case of unflavored out-of-tree build static files are not > >> >> >> >> available and must be copied as well as both static and generated > >> >> >> >> files for flavored build. > >> >> >> >> > >> >> >> >> So split the rules and variables. The name TRUNNER_EXTRA_GEN_FILES > >> >> >> >> is chosen in analogy to TEST_GEN_* variants. > >> >> >> >> > >> >> >> > >> >> >> > Can we keep them together but be smarter about what needs to > >> >> >> > be copied based on source/target directories? I would really > >> >> >> > like to not blow up all these rules. > >> >> >> > >> >> >> I can try, ok, I just find it a bit more clear. But it's good to > >> >> >> get some input from kselftest about OOT build in general. > >> >> > >> >> > I see no value in 'make install' of selftests/bpf > >> >> > and since it's broken just remove that makefile target. > >> >> > >> >> Some CI systems perform testing next stage after building were > >> >> build tree is not available anymore. So it's in use at the > >> >> moment. > >> > >> > such CI systems can do 'cp -r' then > >> >> It's a discussion for linux-kselftest@ (added). > >> > >> At the moment `make install` is generic kselftest functionality > >> and since bpf is part of that infra it looks a bit strange to > >> break it intentionally. > > > > selftests/bpf is only historically part of selftests. > > It probably should stop using kselftest build infra all together. > > We had breakages in selftests/bpf in the past only because > > of changes in kselftests bits. > > > > The question is whether or not the breakages addresses quickly. > Also, bpf keels breaking ksleftest builds and installs because > it has dependencies on bleeding edge tools and causes problems > for kselftest users. > > You are pulling me into the discussion midway and I am missing the > context for the discussion. There is another thread on this topic > where Yauheni and I have been talking about bpf install. > > I would say bpf install has never really worked from kselftest > install mechanism. > > Ideally all tests use kselftest common install rule to leverage > the install and not have users do individual test installs. > It isn't productive and cooperative to say let's have bpf test > do its thing. It is part of selftests and we have to figure out > how to have it consistently build and run. > > It isn't building for me on Linux 5.7-rc7 at the moment, leave > alone install. > > The test Makefile has to handle OUTPUT directory. Please add me > to the entire patch series especially if it changes selftests > Makefile and lib.mk. I will review and try to see if we can make > bpf install work under kselftest common infrastructure. I prefer to keep selftests/bpf install broken. This forced marriage between kselftests and selftests/bpf never worked well. I think it's a time to free them up from each other.