bpf.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Alexei Starovoitov <alexei.starovoitov@gmail.com>
To: Abaci Robot <abaci@linux.alibaba.com>
Cc: Daniel Borkmann <daniel@iogearbox.net>,
	Jiapeng Chong <jiapeng.chong@linux.alibaba.com>,
	"open list:KERNEL SELFTEST FRAMEWORK" 
	<linux-kselftest@vger.kernel.org>,
	Network Development <netdev@vger.kernel.org>,
	bpf <bpf@vger.kernel.org>, LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] selftests/bpf: fix warning comparing pointer to 0
Date: Fri, 23 Apr 2021 09:47:34 -0700	[thread overview]
Message-ID: <CAADnVQJoJW9GWk4guqzHQkDPD4RWoh-puVhnfW0LBPT_N6-4HA@mail.gmail.com> (raw)
In-Reply-To: <93957f3e-2274-c389-64a4-235ed8a228bf@linux.alibaba.com>

On Fri, Apr 23, 2021 at 4:57 AM Abaci Robot <abaci@linux.alibaba.com> wrote:
>
> 在 2021/4/23 上午5:56, Daniel Borkmann 写道:
> > On 4/22/21 12:00 PM, Jiapeng Chong wrote:
> >> Fix the following coccicheck warning:
> >>
> >> ./tools/testing/selftests/bpf/progs/fentry_test.c:76:15-16: WARNING
> >> comparing pointer to 0.
> >>
> >> Reported-by: Abaci Robot <abaci@linux.alibaba.com>
> >> Signed-off-by: Jiapeng Chong <jiapeng.chong@linux.alibaba.com>
> >
> > How many more of those 'comparing pointer to 0' patches do you have?
> > Right now we already merged the following with similar trivial pattern:
> >
> > - ebda107e5f222a086c83ddf6d1ab1da97dd15810
> > - a9c80b03e586fd3819089fbd33c38fb65ad5e00c
> > - 04ea63e34a2ee85cfd38578b3fc97b2d4c9dd573
> >
> > Given they don't really 'fix' anything, I would like to reduce such
> > patch cleanup churn on the bpf tree. Please _consolidate_ all other
> > such occurrences into a _single_ patch for BPF selftests, and resubmit.
> >
> > Thanks!
> >
> >> ---
> >>   tools/testing/selftests/bpf/progs/fentry_test.c | 2 +-
> >>   1 file changed, 1 insertion(+), 1 deletion(-)
> >>
> >> diff --git a/tools/testing/selftests/bpf/progs/fentry_test.c
> >> b/tools/testing/selftests/bpf/progs/fentry_test.c
> >> index 52a550d..d4247d6 100644
> >> --- a/tools/testing/selftests/bpf/progs/fentry_test.c
> >> +++ b/tools/testing/selftests/bpf/progs/fentry_test.c
> >> @@ -73,7 +73,7 @@ int BPF_PROG(test7, struct bpf_fentry_test_t *arg)
> >>   SEC("fentry/bpf_fentry_test8")
> >>   int BPF_PROG(test8, struct bpf_fentry_test_t *arg)
> >>   {
> >> -    if (arg->a == 0)
> >> +    if (!arg->a)
> >>           test8_result = 1;
> >>       return 0;
> >>   }
> >>
>
> Hi,
>
> Thanks for your reply.
>
> TLDR:
> 1. Now all this kind of warning in tools/testing/selftests/bpf/progs/
> were reported and discussed except this one.
> 2. We might not do scanning and check reports on
> tools/testing/selftests/bpf/progs/ in the future,

please stop such scans in selftests/bpf.
I don't see any value in such patches.

  reply	other threads:[~2021-04-23 16:47 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-04-22 10:00 [PATCH] selftests/bpf: fix warning comparing pointer to 0 Jiapeng Chong
2021-04-22 21:56 ` Daniel Borkmann
2021-04-23 11:57   ` Abaci Robot
2021-04-23 16:47     ` Alexei Starovoitov [this message]
  -- strict thread matches above, loose matches on Subject: below --
2022-03-24  2:08 [PATCH] selftests/bpf: Fix " Haowen Bai
2022-03-24 20:28 ` Martin KaFai Lau
2022-03-25 19:55 ` Shuah Khan
2021-03-18  1:55 [PATCH] selftests/bpf: fix " Jiapeng Chong
2021-03-18 16:23 ` Daniel Borkmann
2021-04-22  8:09   ` Jiapeng Chong
2021-03-16  7:59 Jiapeng Chong
2021-03-16 23:00 ` patchwork-bot+netdevbpf
2021-03-10  6:22 Jiapeng Chong
2021-03-10  9:31 ` Yauheni Kaliuta
2021-03-10 22:00 ` patchwork-bot+netdevbpf

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAADnVQJoJW9GWk4guqzHQkDPD4RWoh-puVhnfW0LBPT_N6-4HA@mail.gmail.com \
    --to=alexei.starovoitov@gmail.com \
    --cc=abaci@linux.alibaba.com \
    --cc=bpf@vger.kernel.org \
    --cc=daniel@iogearbox.net \
    --cc=jiapeng.chong@linux.alibaba.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-kselftest@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).