BPF Archive on lore.kernel.org
 help / color / Atom feed
* [PATCH] kcm: use BPF_PROG_RUN
@ 2019-09-05 21:15 Sami Tolvanen
  2019-09-06  0:07 ` Yonghong Song
  0 siblings, 1 reply; 3+ messages in thread
From: Sami Tolvanen @ 2019-09-05 21:15 UTC (permalink / raw)
  To: David S. Miller, Tom Herbert; +Cc: netdev, bpf, linux-kernel, Sami Tolvanen

Instead of invoking struct bpf_prog::bpf_func directly, use the
BPF_PROG_RUN macro.

Signed-off-by: Sami Tolvanen <samitolvanen@google.com>
---
 net/kcm/kcmsock.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/net/kcm/kcmsock.c b/net/kcm/kcmsock.c
index 5dbc0c48f8cb..f350c613bd7d 100644
--- a/net/kcm/kcmsock.c
+++ b/net/kcm/kcmsock.c
@@ -379,7 +379,7 @@ static int kcm_parse_func_strparser(struct strparser *strp, struct sk_buff *skb)
 	struct kcm_psock *psock = container_of(strp, struct kcm_psock, strp);
 	struct bpf_prog *prog = psock->bpf_prog;
 
-	return (*prog->bpf_func)(skb, prog->insnsi);
+	return BPF_PROG_RUN(prog, skb);
 }
 
 static int kcm_read_sock_done(struct strparser *strp, int err)
-- 
2.23.0.187.g17f5b7556c-goog


^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] kcm: use BPF_PROG_RUN
  2019-09-05 21:15 [PATCH] kcm: use BPF_PROG_RUN Sami Tolvanen
@ 2019-09-06  0:07 ` Yonghong Song
  2019-09-06 17:06   ` Alexei Starovoitov
  0 siblings, 1 reply; 3+ messages in thread
From: Yonghong Song @ 2019-09-06  0:07 UTC (permalink / raw)
  To: Sami Tolvanen, David S. Miller, Tom Herbert; +Cc: netdev, bpf, linux-kernel



On 9/5/19 2:15 PM, Sami Tolvanen wrote:
> Instead of invoking struct bpf_prog::bpf_func directly, use the
> BPF_PROG_RUN macro.
> 
> Signed-off-by: Sami Tolvanen <samitolvanen@google.com>

Acked-by: Yonghong Song <yhs@fb.com>

> ---
>   net/kcm/kcmsock.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/net/kcm/kcmsock.c b/net/kcm/kcmsock.c
> index 5dbc0c48f8cb..f350c613bd7d 100644
> --- a/net/kcm/kcmsock.c
> +++ b/net/kcm/kcmsock.c
> @@ -379,7 +379,7 @@ static int kcm_parse_func_strparser(struct strparser *strp, struct sk_buff *skb)
>   	struct kcm_psock *psock = container_of(strp, struct kcm_psock, strp);
>   	struct bpf_prog *prog = psock->bpf_prog;
>   
> -	return (*prog->bpf_func)(skb, prog->insnsi);
> +	return BPF_PROG_RUN(prog, skb);
>   }
>   
>   static int kcm_read_sock_done(struct strparser *strp, int err)
> 

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] kcm: use BPF_PROG_RUN
  2019-09-06  0:07 ` Yonghong Song
@ 2019-09-06 17:06   ` Alexei Starovoitov
  0 siblings, 0 replies; 3+ messages in thread
From: Alexei Starovoitov @ 2019-09-06 17:06 UTC (permalink / raw)
  To: Yonghong Song
  Cc: Sami Tolvanen, David S. Miller, Tom Herbert, netdev, bpf, linux-kernel

On Fri, Sep 6, 2019 at 3:03 AM Yonghong Song <yhs@fb.com> wrote:
>
>
>
> On 9/5/19 2:15 PM, Sami Tolvanen wrote:
> > Instead of invoking struct bpf_prog::bpf_func directly, use the
> > BPF_PROG_RUN macro.
> >
> > Signed-off-by: Sami Tolvanen <samitolvanen@google.com>
>
> Acked-by: Yonghong Song <yhs@fb.com>

Applied. Thanks

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, back to index

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-09-05 21:15 [PATCH] kcm: use BPF_PROG_RUN Sami Tolvanen
2019-09-06  0:07 ` Yonghong Song
2019-09-06 17:06   ` Alexei Starovoitov

BPF Archive on lore.kernel.org

Archives are clonable:
	git clone --mirror https://lore.kernel.org/bpf/0 bpf/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 bpf bpf/ https://lore.kernel.org/bpf \
		bpf@vger.kernel.org bpf@archiver.kernel.org
	public-inbox-index bpf


Newsgroup available over NNTP:
	nntp://nntp.lore.kernel.org/org.kernel.vger.bpf


AGPL code for this site: git clone https://public-inbox.org/ public-inbox