bpf.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Alexei Starovoitov <alexei.starovoitov@gmail.com>
To: Stanislav Fomichev <sdf@google.com>
Cc: Network Development <netdev@vger.kernel.org>,
	bpf <bpf@vger.kernel.org>,
	"David S. Miller" <davem@davemloft.net>,
	Alexei Starovoitov <ast@kernel.org>,
	Daniel Borkmann <daniel@iogearbox.net>,
	Andrii Nakryiko <andriin@fb.com>
Subject: Re: [PATCH bpf-next v5 0/3] selftests/bpf: switch test_progs back to stdio
Date: Tue, 6 Aug 2019 17:23:27 -0700	[thread overview]
Message-ID: <CAADnVQK-TK1T+MQj21HMxS9+9GDx3HnQmPLxWET0paoo+V_5dg@mail.gmail.com> (raw)
In-Reply-To: <20190806174529.8341-1-sdf@google.com>

On Tue, Aug 6, 2019 at 10:45 AM Stanislav Fomichev <sdf@google.com> wrote:
>
> I was looking into converting test_sockops* to test_progs framework
> and that requires using cgroup_helpers.c which rely on stdio/stderr.
> Let's use open_memstream to override stdout into buffer during
> subtests instead of custom test_{v,}printf wrappers. That lets
> us continue to use stdio in the subtests and dump it on failure
> if required.
>
> That would also fix bpf_find_map which currently uses printf to
> signal failure (missed during test_printf conversion).

Applied. Thanks

      parent reply	other threads:[~2019-08-07  0:23 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-08-06 17:45 [PATCH bpf-next v5 0/3] selftests/bpf: switch test_progs back to stdio Stanislav Fomichev
2019-08-06 17:45 ` [PATCH bpf-next v5 1/3] selftests/bpf: test_progs: switch to open_memstream Stanislav Fomichev
2019-08-06 17:45 ` [PATCH bpf-next v5 2/3] selftests/bpf: test_progs: test__printf -> printf Stanislav Fomichev
2019-08-06 17:45 ` [PATCH bpf-next v5 3/3] selftests/bpf: test_progs: drop extra trailing tab Stanislav Fomichev
2019-08-07  0:23 ` Alexei Starovoitov [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAADnVQK-TK1T+MQj21HMxS9+9GDx3HnQmPLxWET0paoo+V_5dg@mail.gmail.com \
    --to=alexei.starovoitov@gmail.com \
    --cc=andriin@fb.com \
    --cc=ast@kernel.org \
    --cc=bpf@vger.kernel.org \
    --cc=daniel@iogearbox.net \
    --cc=davem@davemloft.net \
    --cc=netdev@vger.kernel.org \
    --cc=sdf@google.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).