From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7F11BC43331 for ; Thu, 5 Sep 2019 21:44:57 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id AE80620820 for ; Thu, 5 Sep 2019 21:44:57 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="f/a2wjUZ" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1732027AbfIEVov (ORCPT ); Thu, 5 Sep 2019 17:44:51 -0400 Received: from mail-lj1-f193.google.com ([209.85.208.193]:42180 "EHLO mail-lj1-f193.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726936AbfIEVov (ORCPT ); Thu, 5 Sep 2019 17:44:51 -0400 Received: by mail-lj1-f193.google.com with SMTP id y23so4028446lje.9; Thu, 05 Sep 2019 14:44:49 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=h2bk3j52P30Q1CTEXW10Z5tA0jiFGXaEQ+rZ6Wp9rtw=; b=f/a2wjUZxmDspNldx7I3qghloHCzwxYNI4xFcoXbdP5KP+eN1RQmq83F9HgVXwJaPX NCinIjm2C0lQAHsiGIAPUUmlErnY/jzThdbblnlCyYU2opwVbOm7x9h/pErfp7SkqiTM a3Kjv89nvO7DVtUTyakUmpPMukfusBraJpzzFcRjSkWtfyZ6AlbIgUu8jo6bIDWQ6N0M 5Yb4ayEuktTJzvSgPKBENAc+vnDZTmRBZAjgpB2tnCAyG6RA4lKMc3g2ICHdl1tYh5DR WG/Kg2d9CWerk17gLxqDjJFIh4a+pVYbhl9hSOsBDoD66/J5BGqBG/S8Vph5S/E5irCq +rkg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=h2bk3j52P30Q1CTEXW10Z5tA0jiFGXaEQ+rZ6Wp9rtw=; b=X9Lhkv3b7x6Bmc74ZexKr8JTBKhaGHeL9Yg1Ld17TwJODtzPiKySURp4cutB1eVS5g sdBGmlw5ekmCQg0n/rnoGRubFe10IqZkmo/Ls5DQsXHKpVeP7pxh9DtAZeKn0YXYRpa5 Nt9zECNjuvFXrjNc5Dr7UxauEzN3kd74y3YgRiiqT9dhGfoEbRT7m0QNtnKuSZ8uNk1+ g96R1g3fWGgvn7kCnZmR6v+VOS0xded9pbGTZJDSTwTdD7mxdTinUiDfsT1nuARP6Bk0 RKrT1I1o5QEN0tbylyCurq4gh6fcIfPmjTt0aLbYUq2OYYtELC+6M6l5yEqqOTe+fzlS N02g== X-Gm-Message-State: APjAAAVuP4hqvfNFdNbeHcaTDCd1db3jvKRt6u02FETcSbUXUWHIVEkX ZbqZZSuG067JUaEIueuAuJqaf9nZ2EZyNoSLJ2c= X-Google-Smtp-Source: APXvYqyk6skdfl/16FhYXB68WgXTcAV0P1eaA9Y9REhksLUKbhCAx0u0UL9AhebkLoG8ZgVXF2woSJqnHh7LpFzcAho= X-Received: by 2002:a2e:4489:: with SMTP id b9mr3613889ljf.17.1567719889033; Thu, 05 Sep 2019 14:44:49 -0700 (PDT) MIME-Version: 1.0 References: <0000000000005091a70591d3e1d9@google.com> In-Reply-To: <0000000000005091a70591d3e1d9@google.com> From: Alexei Starovoitov Date: Thu, 5 Sep 2019 14:44:37 -0700 Message-ID: Subject: Re: general protection fault in dev_map_hash_update_elem To: syzbot Cc: bpf , Daniel Borkmann , Jesper Dangaard Brouer , LKML , Network Development , syzkaller-bugs , =?UTF-8?B?VG9rZSBIw7hpbGFuZC1Kw7hyZ2Vuc2Vu?= Content-Type: text/plain; charset="UTF-8" Sender: bpf-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: bpf@vger.kernel.org On Thu, Sep 5, 2019 at 1:08 PM syzbot wrote: > > Hello, > > syzbot found the following crash on: > > HEAD commit: 6d028043 Add linux-next specific files for 20190830 > git tree: linux-next > console output: https://syzkaller.appspot.com/x/log.txt?x=135c1a92600000 > kernel config: https://syzkaller.appspot.com/x/.config?x=82a6bec43ab0cb69 > dashboard link: https://syzkaller.appspot.com/bug?extid=4e7a85b1432052e8d6f8 > compiler: gcc (GCC) 9.0.0 20181231 (experimental) > syz repro: https://syzkaller.appspot.com/x/repro.syz?x=109124e1600000 > > IMPORTANT: if you fix the bug, please add the following tag to the commit: > Reported-by: syzbot+4e7a85b1432052e8d6f8@syzkaller.appspotmail.com > > kasan: CONFIG_KASAN_INLINE enabled > kasan: GPF could be caused by NULL-ptr deref or user memory access > general protection fault: 0000 [#1] PREEMPT SMP KASAN > CPU: 1 PID: 10235 Comm: syz-executor.0 Not tainted 5.3.0-rc6-next-20190830 > #75 > Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS > Google 01/01/2011 > RIP: 0010:__write_once_size include/linux/compiler.h:203 [inline] > RIP: 0010:__hlist_del include/linux/list.h:795 [inline] > RIP: 0010:hlist_del_rcu include/linux/rculist.h:475 [inline] > RIP: 0010:__dev_map_hash_update_elem kernel/bpf/devmap.c:668 [inline] > RIP: 0010:dev_map_hash_update_elem+0x3c8/0x6e0 kernel/bpf/devmap.c:691 > Code: 48 89 f1 48 89 75 c8 48 c1 e9 03 80 3c 11 00 0f 85 d3 02 00 00 48 b9 > 00 00 00 00 00 fc ff df 48 8b 53 10 48 89 d6 48 c1 ee 03 <80> 3c 0e 00 0f > 85 97 02 00 00 48 85 c0 48 89 02 74 38 48 89 55 b8 > RSP: 0018:ffff88808d607c30 EFLAGS: 00010046 > RAX: 0000000000000000 RBX: ffff8880a7f14580 RCX: dffffc0000000000 > RDX: 0000000000000000 RSI: 0000000000000000 RDI: ffff8880a7f14588 > RBP: ffff88808d607c78 R08: 0000000000000004 R09: ffffed1011ac0f73 > R10: ffffed1011ac0f72 R11: 0000000000000003 R12: ffff88809f4e9400 > R13: ffff88809b06ba00 R14: 0000000000000000 R15: ffff88809f4e9528 > FS: 00007f3a3d50c700(0000) GS:ffff8880ae900000(0000) knlGS:0000000000000000 > CS: 0010 DS: 0000 ES: 0000 CR0: 0000000080050033 > CR2: 00007feb3fcd0000 CR3: 00000000986b9000 CR4: 00000000001406e0 > DR0: 0000000000000000 DR1: 0000000000000000 DR2: 0000000000000000 > DR3: 0000000000000000 DR6: 00000000fffe0ff0 DR7: 0000000000000400 > Call Trace: > map_update_elem+0xc82/0x10b0 kernel/bpf/syscall.c:966 > __do_sys_bpf+0x8b5/0x3350 kernel/bpf/syscall.c:2854 > __se_sys_bpf kernel/bpf/syscall.c:2825 [inline] > __x64_sys_bpf+0x73/0xb0 kernel/bpf/syscall.c:2825 > do_syscall_64+0xfa/0x760 arch/x86/entry/common.c:290 > entry_SYSCALL_64_after_hwframe+0x49/0xbe > RIP: 0033:0x459879 > Code: fd b7 fb ff c3 66 2e 0f 1f 84 00 00 00 00 00 66 90 48 89 f8 48 89 f7 > 48 89 d6 48 89 ca 4d 89 c2 4d 89 c8 4c 8b 4c 24 08 0f 05 <48> 3d 01 f0 ff > ff 0f 83 cb b7 fb ff c3 66 2e 0f 1f 84 00 00 00 00 > RSP: 002b:00007f3a3d50bc78 EFLAGS: 00000246 ORIG_RAX: 0000000000000141 > RAX: ffffffffffffffda RBX: 0000000000000003 RCX: 0000000000459879 > RDX: 0000000000000020 RSI: 0000000020000040 RDI: 0000000000000002 > RBP: 000000000075bf20 R08: 0000000000000000 R09: 0000000000000000 > R10: 0000000000000000 R11: 0000000000000246 R12: 00007f3a3d50c6d4 > R13: 00000000004bfc86 R14: 00000000004d1960 R15: 00000000ffffffff > Modules linked in: > ---[ end trace 083223e21dbd0ae5 ]--- > RIP: 0010:__write_once_size include/linux/compiler.h:203 [inline] > RIP: 0010:__hlist_del include/linux/list.h:795 [inline] > RIP: 0010:hlist_del_rcu include/linux/rculist.h:475 [inline] > RIP: 0010:__dev_map_hash_update_elem kernel/bpf/devmap.c:668 [inline] > RIP: 0010:dev_map_hash_update_elem+0x3c8/0x6e0 kernel/bpf/devmap.c:691 Toke, please take a look. Thanks!