From: Alexei Starovoitov <alexei.starovoitov@gmail.com>
To: Kumar Kartikeya Dwivedi <memxor@gmail.com>
Cc: bpf <bpf@vger.kernel.org>, "Alexei Starovoitov" <ast@kernel.org>,
"Daniel Borkmann" <daniel@iogearbox.net>,
"Andrii Nakryiko" <andrii@kernel.org>,
"Martin KaFai Lau" <kafai@fb.com>,
"Song Liu" <songliubraving@fb.com>, "Yonghong Song" <yhs@fb.com>,
"Jesper Dangaard Brouer" <brouer@redhat.com>,
"Toke Høiland-Jørgensen" <toke@redhat.com>,
"Network Development" <netdev@vger.kernel.org>
Subject: Re: [PATCH bpf-next v7 0/9] Support kernel module function calls from eBPF
Date: Tue, 5 Oct 2021 17:17:34 -0700 [thread overview]
Message-ID: <CAADnVQKDPG+U-NwoAeNSU5Ef9ZYhhGcgL4wBkFoP-E9h8-XZhw@mail.gmail.com> (raw)
In-Reply-To: <20211002011757.311265-1-memxor@gmail.com>
On Fri, Oct 1, 2021 at 6:18 PM Kumar Kartikeya Dwivedi <memxor@gmail.com> wrote:
>
> This set enables kernel module function calls, and also modifies verifier logic
> to permit invalid kernel function calls as long as they are pruned as part of
> dead code elimination. This is done to provide better runtime portability for
> BPF objects, which can conditionally disable parts of code that are pruned later
> by the verifier (e.g. const volatile vars, kconfig options). libbpf
> modifications are made along with kernel changes to support module function
> calls.
>
> It also converts TCP congestion control objects to use the module kfunc support
> instead of relying on IS_BUILTIN ifdef.
>
> Changelog:
> ----------
> v6 -> v7
> v6: https://lore.kernel.org/bpf/20210930062948.1843919-1-memxor@gmail.com
>
> * Let __bpf_check_kfunc_call take kfunc_btf_id_list instead of generating
> callbacks (Andrii)
> * Rename it to bpf_check_mod_kfunc_call to reflect usage
> * Remove OOM checks (Alexei)
> * Remove resolve_btfids invocation for bpf_testmod (Andrii)
> * Move fd_array_cnt initialization near fd_array alloc (Andrii)
> * Rename helper to btf_find_by_name_kind and pass start_id (Andrii)
> * memset when data is NULL in add_data (Alexei)
> * Fix other nits
Looking good now. Applied. Thanks
prev parent reply other threads:[~2021-10-06 0:17 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-02 1:17 [PATCH bpf-next v7 0/9] Support kernel module function calls from eBPF Kumar Kartikeya Dwivedi
2021-10-02 1:17 ` [PATCH bpf-next v7 1/9] bpf: Introduce BPF support for kernel module function calls Kumar Kartikeya Dwivedi
2021-10-02 1:17 ` [PATCH bpf-next v7 2/9] bpf: Be conservative while processing invalid kfunc calls Kumar Kartikeya Dwivedi
2021-10-02 1:17 ` [PATCH bpf-next v7 3/9] bpf: btf: Introduce helpers for dynamic BTF set registration Kumar Kartikeya Dwivedi
2021-10-02 1:17 ` [PATCH bpf-next v7 4/9] tools: Allow specifying base BTF file in resolve_btfids Kumar Kartikeya Dwivedi
2021-10-02 1:17 ` [PATCH bpf-next v7 5/9] bpf: Enable TCP congestion control kfunc from modules Kumar Kartikeya Dwivedi
2021-10-02 1:17 ` [PATCH bpf-next v7 6/9] libbpf: Support kernel module function calls Kumar Kartikeya Dwivedi
2021-10-02 1:17 ` [PATCH bpf-next v7 7/9] libbpf: Resolve invalid weak kfunc calls with imm = 0, off = 0 Kumar Kartikeya Dwivedi
2021-10-02 1:17 ` [PATCH bpf-next v7 8/9] libbpf: Update gen_loader to emit BTF_KIND_FUNC relocations Kumar Kartikeya Dwivedi
2021-10-02 1:17 ` [PATCH bpf-next v7 9/9] bpf: selftests: Add selftests for module kfunc support Kumar Kartikeya Dwivedi
2021-10-06 0:17 ` Alexei Starovoitov [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAADnVQKDPG+U-NwoAeNSU5Ef9ZYhhGcgL4wBkFoP-E9h8-XZhw@mail.gmail.com \
--to=alexei.starovoitov@gmail.com \
--cc=andrii@kernel.org \
--cc=ast@kernel.org \
--cc=bpf@vger.kernel.org \
--cc=brouer@redhat.com \
--cc=daniel@iogearbox.net \
--cc=kafai@fb.com \
--cc=memxor@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=songliubraving@fb.com \
--cc=toke@redhat.com \
--cc=yhs@fb.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).