bpf.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Alexei Starovoitov <alexei.starovoitov@gmail.com>
To: Yonghong Song <yhs@fb.com>
Cc: Ma Xinjian <max.xinjian@intel.com>,
	Alexei Starovoitov <ast@fb.com>, bpf <bpf@vger.kernel.org>,
	Daniel Borkmann <daniel@iogearbox.net>,
	Kernel Team <kernel-team@fb.com>,
	"Li, Philip" <philip.li@intel.com>
Subject: Re: [PATCH bpf-next v2] [tools/bpf] workaround a verifier failure for test_progs
Date: Tue, 28 Apr 2020 15:33:55 -0700	[thread overview]
Message-ID: <CAADnVQKFMpw+VJODvcOrq2Fnb6e-prV5cSQapWc96iRWOt8gzA@mail.gmail.com> (raw)
In-Reply-To: <1b8051db-20af-73ab-179e-8818bee7c7ee@fb.com>

On Mon, Apr 27, 2020 at 11:14 PM Yonghong Song <yhs@fb.com> wrote:
> > -       int ret;
> > +      /* a workaround to prevent compiler from generating
> > +      * codes verifier cannot handle yet.
> > +      */
> > +      volatile int ret;
> >
> >          if (ctx->write)
> >                  return 0;
>
> Right. This is related to alu32 mode. The detailed description
> https://lore.kernel.org/bpf/20191107170045.2503480-1-yhs@fb.com/
>
> We are still working on this, either a verifier solution or a compiler
> workaround.

Thanks for the report.
I pushed the same fix for progs/test_sysctl_prog.c into bpf-next.
Now test_sysctl passes.

  reply	other threads:[~2020-04-28 22:34 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-04-28  2:56 [PATCH bpf-next v2] [tools/bpf] workaround a verifier failure for test_progs Ma Xinjian
2020-04-28  6:13 ` Yonghong Song
2020-04-28 22:33   ` Alexei Starovoitov [this message]
  -- strict thread matches above, loose matches on Subject: below --
2019-11-07 17:00 Yonghong Song
2019-11-07 23:10 ` Song Liu
2019-11-11 13:07 ` Daniel Borkmann

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAADnVQKFMpw+VJODvcOrq2Fnb6e-prV5cSQapWc96iRWOt8gzA@mail.gmail.com \
    --to=alexei.starovoitov@gmail.com \
    --cc=ast@fb.com \
    --cc=bpf@vger.kernel.org \
    --cc=daniel@iogearbox.net \
    --cc=kernel-team@fb.com \
    --cc=max.xinjian@intel.com \
    --cc=philip.li@intel.com \
    --cc=yhs@fb.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).