From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B3B7BC10DCE for ; Fri, 13 Mar 2020 01:30:21 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 709E9206E7 for ; Fri, 13 Mar 2020 01:30:21 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="nODddTl+" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726838AbgCMBaV (ORCPT ); Thu, 12 Mar 2020 21:30:21 -0400 Received: from mail-lj1-f195.google.com ([209.85.208.195]:39744 "EHLO mail-lj1-f195.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726834AbgCMBaU (ORCPT ); Thu, 12 Mar 2020 21:30:20 -0400 Received: by mail-lj1-f195.google.com with SMTP id f10so8702978ljn.6; Thu, 12 Mar 2020 18:30:19 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=+f8gupTNs8QwwqWyowgs1SqTg/02EBthP6Knr2UCYRA=; b=nODddTl+e3Eqhf35jmrbsBgEa7ZJS/NjbHhO/55Z0Ucao9gyT8nP5LEGpH7ZdR+OeO QxWCWPGYI/HML9LH/KOz3r9TS8yfa9aNfVE5RQcV95nBLngKOALQwAm5M5h/YaP/5exo 6PLCQrvPagKAGtcF2rGpBVbp+FTytIt0fG06VCLw2ujptbZ4FTsLSYwO0TVeCmr1DldG nnKdYttGryD5NlVdvHDDiq5wrxhPjT3CNpmmJkWrPyPzxns32dHTFMxZGxXyJKpImoxf 0ba7E80ZVL1oVNM/6oI1meq+HpgpEDIJxBWGjrFxwysr6m7T5Mxo5lbd1JX6KXp6AU+m l5cA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=+f8gupTNs8QwwqWyowgs1SqTg/02EBthP6Knr2UCYRA=; b=bDR2ZBq4u8CPldFX12RhX+yuQGsNybu/9iEu6YDQg3ir4YKboLfBYA2lW0iBfHvkNo 41Lc3raneliG6BGHoW35q6P77pD4qCVvECBwvcUhG3RUHUnwgfAlLkO3TFVfswbDvlNN qFUBU42s/X1vXD5tDq8/mHTHdRU9Fss6kR/iaRaGK6cXIeftdOu3YJf/sh4qzbrjm0Xd 8yvtoFajLkle39Wtl3dzM56pknk1tIM2pE7XEaz33MpKqBRBdbAQtSnoMqOw6YcKLf+r QU4EZ15peWbZohQD0ngZwTnzvyzEs+hVzmbq1SIamvtFzzv5jAaKQeD0RZQNrPT2HGMN TSzQ== X-Gm-Message-State: ANhLgQ152Zd/5Yfvvy6yPm+OIuyha7RgBSEhcniS/3la6TveNRMFxCpR dmw0/O31SRLcAOBig+CGTdismVYLqRkwOM8/GOU= X-Google-Smtp-Source: ADFU+vu4XHi9NvP91XxA/aM32nSzOLsNTjUcXLjbRHfqWU9Rm+LxHGAQ9avw47qGP3sNjJxHd7qqdirT2z5toBVBdH0= X-Received: by 2002:a2e:b5a2:: with SMTP id f2mr6980702ljn.212.1584063018944; Thu, 12 Mar 2020 18:30:18 -0700 (PDT) MIME-Version: 1.0 References: <20200311222749.458015-1-andriin@fb.com> In-Reply-To: <20200311222749.458015-1-andriin@fb.com> From: Alexei Starovoitov Date: Thu, 12 Mar 2020 18:30:07 -0700 Message-ID: Subject: Re: [PATCH v2 bpf-next] selftests/bpf: make tcp_rtt test more robust to failures To: Andrii Nakryiko Cc: bpf , Network Development , Alexei Starovoitov , Daniel Borkmann , Stanislav Fomichev , Andrii Nakryiko , Kernel Team Content-Type: text/plain; charset="UTF-8" Sender: bpf-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: bpf@vger.kernel.org On Wed, Mar 11, 2020 at 3:28 PM Andrii Nakryiko wrote: > > Switch to non-blocking accept and wait for server thread to exit before > proceeding. I noticed that sometimes tcp_rtt server thread failure would > "spill over" into other tests (that would run after tcp_rtt), probably just > because server thread exits much later and tcp_rtt doesn't wait for it. > > v1->v2: > - add usleep() while waiting on initial non-blocking accept() (Stanislav); > > Fixes: 8a03222f508b ("selftests/bpf: test_progs: fix client/server race in tcp_rtt") > Reviewed-by: Stanislav Fomichev > Signed-off-by: Andrii Nakryiko Applied. Thanks