From: Alexei Starovoitov <alexei.starovoitov@gmail.com>
To: Andrii Nakryiko <andrii.nakryiko@gmail.com>
Cc: John Fastabend <john.fastabend@gmail.com>,
Andrii Nakryiko <andriin@fb.com>,
Alexei Starovoitov <ast@kernel.org>,
Daniel Borkmann <daniel@iogearbox.net>, bpf <bpf@vger.kernel.org>
Subject: Re: [bpf-next PATCH] bpf, selftests: Use single cgroup helpers for both test_sockmap/progs
Date: Sat, 1 Aug 2020 20:30:08 -0700 [thread overview]
Message-ID: <CAADnVQKj3CKRPkXMPgCucLYKj8jhgvdxiz-CXmrnXi4uVhtkng@mail.gmail.com> (raw)
In-Reply-To: <CAEf4BzaXsve_=CfEzipd=wRLfDYSUdF6u5Myrd5E=F4qt=hGeg@mail.gmail.com>
On Fri, Jul 31, 2020 at 8:34 PM Andrii Nakryiko
<andrii.nakryiko@gmail.com> wrote:
>
> On Fri, Jul 31, 2020 at 3:09 PM John Fastabend <john.fastabend@gmail.com> wrote:
> >
> > Nearly every user of cgroup helpers does the same sequence of API calls. So
> > push these into a single helper cgroup_setup_and_join. The cases that do
> > a bit of extra logic are test_progs which currently uses an env variable
> > to decide if it needs to setup the cgroup environment or can use an
> > existingi environment. And then tests that are doing cgroup tests
> > themselves. We skip these cases for now.
> >
> > Signed-off-by: John Fastabend <john.fastabend@gmail.com>
> > ---
>
> makes total sense, thanks for the clean up!
>
> Acked-by: Andrii Nakryiko <andriin@fb.com>
Applied. Thanks
prev parent reply other threads:[~2020-08-02 3:30 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-31 22:08 [bpf-next PATCH] Consolidate cgroup setup in selftests John Fastabend
2020-07-31 22:09 ` [bpf-next PATCH] bpf, selftests: Use single cgroup helpers for both test_sockmap/progs John Fastabend
2020-08-01 3:33 ` Andrii Nakryiko
2020-08-02 3:30 ` Alexei Starovoitov [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAADnVQKj3CKRPkXMPgCucLYKj8jhgvdxiz-CXmrnXi4uVhtkng@mail.gmail.com \
--to=alexei.starovoitov@gmail.com \
--cc=andrii.nakryiko@gmail.com \
--cc=andriin@fb.com \
--cc=ast@kernel.org \
--cc=bpf@vger.kernel.org \
--cc=daniel@iogearbox.net \
--cc=john.fastabend@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).