* [PATCH bpf-next] bpf: Make array_map_mmap static
@ 2019-11-19 14:21 YueHaibing
2019-11-19 18:52 ` Andrii Nakryiko
2019-11-20 0:59 ` Alexei Starovoitov
0 siblings, 2 replies; 3+ messages in thread
From: YueHaibing @ 2019-11-19 14:21 UTC (permalink / raw)
To: ast, daniel, kafai, songliubraving, yhs, andriin
Cc: netdev, bpf, linux-kernel, YueHaibing
Fix sparse warning:
kernel/bpf/arraymap.c:481:5: warning:
symbol 'array_map_mmap' was not declared. Should it be static?
Reported-by: Hulk Robot <hulkci@huawei.com>
Signed-off-by: YueHaibing <yuehaibing@huawei.com>
---
kernel/bpf/arraymap.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/kernel/bpf/arraymap.c b/kernel/bpf/arraymap.c
index a42097c..633c8c7 100644
--- a/kernel/bpf/arraymap.c
+++ b/kernel/bpf/arraymap.c
@@ -478,7 +478,7 @@ static int array_map_check_btf(const struct bpf_map *map,
return 0;
}
-int array_map_mmap(struct bpf_map *map, struct vm_area_struct *vma)
+static int array_map_mmap(struct bpf_map *map, struct vm_area_struct *vma)
{
struct bpf_array *array = container_of(map, struct bpf_array, map);
pgoff_t pgoff = PAGE_ALIGN(sizeof(*array)) >> PAGE_SHIFT;
--
2.7.4
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH bpf-next] bpf: Make array_map_mmap static
2019-11-19 14:21 [PATCH bpf-next] bpf: Make array_map_mmap static YueHaibing
@ 2019-11-19 18:52 ` Andrii Nakryiko
2019-11-20 0:59 ` Alexei Starovoitov
1 sibling, 0 replies; 3+ messages in thread
From: Andrii Nakryiko @ 2019-11-19 18:52 UTC (permalink / raw)
To: YueHaibing
Cc: Alexei Starovoitov, Daniel Borkmann, Martin Lau, Song Liu,
Yonghong Song, Andrii Nakryiko, Networking, bpf, open list
On Tue, Nov 19, 2019 at 6:22 AM YueHaibing <yuehaibing@huawei.com> wrote:
>
> Fix sparse warning:
>
> kernel/bpf/arraymap.c:481:5: warning:
> symbol 'array_map_mmap' was not declared. Should it be static?
>
> Reported-by: Hulk Robot <hulkci@huawei.com>
> Signed-off-by: YueHaibing <yuehaibing@huawei.com>
> ---
Yes it should, thanks!
Acked-by: Andrii Nakryiko <andriin@fb.com>
[...]
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH bpf-next] bpf: Make array_map_mmap static
2019-11-19 14:21 [PATCH bpf-next] bpf: Make array_map_mmap static YueHaibing
2019-11-19 18:52 ` Andrii Nakryiko
@ 2019-11-20 0:59 ` Alexei Starovoitov
1 sibling, 0 replies; 3+ messages in thread
From: Alexei Starovoitov @ 2019-11-20 0:59 UTC (permalink / raw)
To: YueHaibing
Cc: Alexei Starovoitov, Daniel Borkmann, Martin KaFai Lau, Song Liu,
Yonghong Song, Andrii Nakryiko, Network Development, bpf, LKML
On Tue, Nov 19, 2019 at 6:21 AM YueHaibing <yuehaibing@huawei.com> wrote:
>
> Fix sparse warning:
>
> kernel/bpf/arraymap.c:481:5: warning:
> symbol 'array_map_mmap' was not declared. Should it be static?
>
> Reported-by: Hulk Robot <hulkci@huawei.com>
> Signed-off-by: YueHaibing <yuehaibing@huawei.com>
Applied. Thanks
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2019-11-20 0:59 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-11-19 14:21 [PATCH bpf-next] bpf: Make array_map_mmap static YueHaibing
2019-11-19 18:52 ` Andrii Nakryiko
2019-11-20 0:59 ` Alexei Starovoitov
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).