From: Alexei Starovoitov <alexei.starovoitov@gmail.com>
To: Carlos Neira <cneirabustos@gmail.com>
Cc: Network Development <netdev@vger.kernel.org>,
Yonghong Song <yhs@fb.com>,
"Eric W. Biederman" <ebiederm@xmission.com>,
Jesper Dangaard Brouer <brouer@redhat.com>,
bpf <bpf@vger.kernel.org>
Subject: Re: [PATCH v17 0/3] BPF: New helper to obtain namespace data from current task
Date: Thu, 12 Mar 2020 17:45:09 -0700 [thread overview]
Message-ID: <CAADnVQL4GR2kOoiLE0aTorvYzTPWrOCV4yKMh1BasYTVHkKxcg@mail.gmail.com> (raw)
In-Reply-To: <20200304204157.58695-1-cneirabustos@gmail.com>
On Wed, Mar 4, 2020 at 12:42 PM Carlos Neira <cneirabustos@gmail.com> wrote:
>
> Currently bpf_get_current_pid_tgid(), is used to do pid filtering in bcc's
> scripts but this helper returns the pid as seen by the root namespace which is
> fine when a bcc script is not executed inside a container.
> When the process of interest is inside a container, pid filtering will not work
> if bpf_get_current_pid_tgid() is used.
> This helper addresses this limitation returning the pid as it's seen by the current
> namespace where the script is executing.
>
> In the future different pid_ns files may belong to different devices, according to the
> discussion between Eric Biederman and Yonghong in 2017 Linux plumbers conference.
> To address that situation the helper requires inum and dev_t from /proc/self/ns/pid.
> This helper has the same use cases as bpf_get_current_pid_tgid() as it can be
> used to do pid filtering even inside a container.
Applied. Thanks.
There was one spurious trailing whitespace that I fixed in patch 3
and missing .gitignore update for test_current_pid_tgid_new_ns.
Could you please follow up with another patch to fold
test_current_pid_tgid_new_ns into test_progs.
I'd really like to consolidate all tests into single binary.
next prev parent reply other threads:[~2020-03-13 0:45 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-04 20:41 [PATCH v17 0/3] BPF: New helper to obtain namespace data from current task Carlos Neira
2020-03-04 20:41 ` [PATCH v17 1/3] fs/nsfs.c: added ns_match Carlos Neira
2020-03-04 20:41 ` [PATCH v17 2/3] bpf: added new helper bpf_get_ns_current_pid_tgid Carlos Neira
2020-03-04 20:41 ` [PATCH v17 3/3] tools/testing/selftests/bpf: Add self-tests for " Carlos Neira
2020-03-13 0:45 ` Alexei Starovoitov [this message]
2020-03-13 10:39 ` [PATCH v17 0/3] BPF: New helper to obtain namespace data from current task Quentin Monnet
2020-03-13 12:48 ` Carlos Antonio Neira Bustos
2020-03-13 12:46 ` Carlos Antonio Neira Bustos
2020-04-28 1:40 ` Andrii Nakryiko
[not found] ` <CACiB22iSFBybiAn_Z0cspWFLObZy30ZoQHnvH4kFdVsB9dinvQ@mail.gmail.com>
2020-04-28 1:47 ` Andrii Nakryiko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAADnVQL4GR2kOoiLE0aTorvYzTPWrOCV4yKMh1BasYTVHkKxcg@mail.gmail.com \
--to=alexei.starovoitov@gmail.com \
--cc=bpf@vger.kernel.org \
--cc=brouer@redhat.com \
--cc=cneirabustos@gmail.com \
--cc=ebiederm@xmission.com \
--cc=netdev@vger.kernel.org \
--cc=yhs@fb.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).