From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.7 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B5D3AC2B9F4 for ; Fri, 25 Jun 2021 15:07:26 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 9251A616E8 for ; Fri, 25 Jun 2021 15:07:26 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229940AbhFYPJq (ORCPT ); Fri, 25 Jun 2021 11:09:46 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:37840 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230235AbhFYPJp (ORCPT ); Fri, 25 Jun 2021 11:09:45 -0400 Received: from mail-lf1-x131.google.com (mail-lf1-x131.google.com [IPv6:2a00:1450:4864:20::131]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id EBAC0C061574; Fri, 25 Jun 2021 08:07:24 -0700 (PDT) Received: by mail-lf1-x131.google.com with SMTP id i13so16786259lfc.7; Fri, 25 Jun 2021 08:07:24 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=svkyksNfhmxePdvgJKJPqr2pES2gWbjljd0+oSLrCbk=; b=ei66awCGjohBDRqTdvTXGIiSfxI7GLRcHOCGeuYlRtCZOhRBFL61I4dasn2nQ6WVnS +FZ2e+Zo0RvfllLVz5NA8JvreDtw22TZ9O7b9JUsnks4pajjtN3TvF5ROVwPdhSE/Ow0 r/Ji0Gs3u741fkPvh/s/hlmglFjid+9QtoavP+vZQiYpRanRx8MRswj9UbO3g6oenJSp QufAPBGVDVnAeu0YrIMLcVgZbwCSDRfPxmLEsQ8QVANwVpu0a6C8UunnSDPOBHaaW6EA y7yQzcyNWTtF/xqF518mjXms5r0ek5+Ex4MW7PyGDegsYYO5wWg5X7B77YgWFKvN0A2z 6WhA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=svkyksNfhmxePdvgJKJPqr2pES2gWbjljd0+oSLrCbk=; b=cOh+SM9jXUE7qUY5KCid6jpMCwW1U+bSB+Ls9Rq+mhOwC5O/QiY74hs+Zojipw3H8e 4L0QAT16+3O7z6SaJFyAvyLxl7wzn2EY3sjirLG2IPh0ZaA2HC52H2Ul96cYAGI703NV 0HRnS73s7QgiKb4DRWcPYYXNSpUN1zvv0Srel3KnnfJYmbleK8SJSwpXOiTQOEurFWlL Z1dnS/UzN/rtivYA7Df9ZJvMI0HVI0qZX2lLCrjI3mk/HD74pmgRLDqrGgRDPDOi6hsY qrUiBuiMmfb4eAdZlV10YhDG4Lh5+afjMxUt0VPAktA0X+0MC3/nNr4dlnkYwQQ+ETh+ TP8Q== X-Gm-Message-State: AOAM533/JXS7+HncUsgwJyE0OXVK2yl0GKCgRoigoHu975AhoWA15saz YqQQvqjhe8zSBj2aj1t6zNMST8qf4T55FpLO07M= X-Google-Smtp-Source: ABdhPJyn2BUgSGrJfpZtRns/wqudcsilxjSgHGAe2cRG9riIPlkwBYJeORHhQpGNgwY79XX5x0m6jIESBsvqlwIhtuQ= X-Received: by 2002:ac2:4e82:: with SMTP id o2mr8606980lfr.38.1624633643234; Fri, 25 Jun 2021 08:07:23 -0700 (PDT) MIME-Version: 1.0 References: <20210622110026.1157847-1-ravi.bangoria@linux.ibm.com> <960b5e26-e97d-2b1a-4628-df8525c0728b@linux.ibm.com> In-Reply-To: <960b5e26-e97d-2b1a-4628-df8525c0728b@linux.ibm.com> From: Alexei Starovoitov Date: Fri, 25 Jun 2021 08:07:11 -0700 Message-ID: Subject: Re: [PATCH] x86 bpf: Fix extable offset calculation To: Ravi Bangoria Cc: Alexei Starovoitov , "David S. Miller" , Hideaki YOSHIFUJI , David Ahern , Daniel Borkmann , Thomas Gleixner , Ingo Molnar , Borislav Petkov , X86 ML , "H. Peter Anvin" , Andrii Nakryiko , Martin KaFai Lau , Song Liu , Yonghong Song , John Fastabend , KP Singh , Network Development , bpf , LKML , "Naveen N. Rao" Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: bpf@vger.kernel.org On Thu, Jun 24, 2021 at 11:22 PM Ravi Bangoria wrote: > > Could you send a followup patch with a selftest, so I don't make > > the same mistake again ? ;) > > Unfortunately extable gets involved only for bad kernel pointers and > ideally there should not be any bad pointer in kernel. So there is no > easy way to create a proper selftest for this. Right. We have lib/test_bpf.c kernel module for such cases.