From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D42E1CA9EAE for ; Mon, 21 Oct 2019 01:22:46 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 9B5512190F for ; Mon, 21 Oct 2019 01:22:46 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="R2ppIkaI" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726681AbfJUBWq (ORCPT ); Sun, 20 Oct 2019 21:22:46 -0400 Received: from mail-lj1-f195.google.com ([209.85.208.195]:46135 "EHLO mail-lj1-f195.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726399AbfJUBWq (ORCPT ); Sun, 20 Oct 2019 21:22:46 -0400 Received: by mail-lj1-f195.google.com with SMTP id d1so11401090ljl.13; Sun, 20 Oct 2019 18:22:44 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=V/JUtmAtM/GkGXaDJB1vyKZ/gwQgDhBXRCWybHQRV1k=; b=R2ppIkaIhKzFC0+4362d6zF8FdwgTWIn1nCslYhGfqoh6Jsn0RAsXwUgAs5b1eMP3k fyLKoD6dmuyQt/tBaZ6Tesjn8KpIUjOgXrMxWGHFAtYaGOrtIiwLPSU/9NrwwNMpfTa6 /yV7UQdlP/iQaoTVhK/S7yL61gRt7KP9bxQCeL+Cx5aWoESOUulDFNNyk2SYZkLS6h97 joJKZk1i9mtA7C3H0Cf1dOZYnDku7HPxHRF8oXMvt0nniA0JH4EpdzuJ++jzD2Sgeiy/ 2+NV7l/J5EphLTD+VRL23DJpvPSg+ShqS9jxWhMkFvrLHEc97a7jhvCM9T+GbjK5pPLZ dN4A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=V/JUtmAtM/GkGXaDJB1vyKZ/gwQgDhBXRCWybHQRV1k=; b=rFjRa8JJ9xv/KUFFKiUBN/7wF2CAkJNet44MpebqyTMKTfR+gYSCuNxJxx8EQYyetL HhTuEIbPn+7Jn04YBJ261rGk2nyV+jVRqTL3D/T1n1OdBnfW/dCniJeic39evlMhiGS0 95E0HRKlfWdA3CbIyw8KjI0kNTD71J/Bcr3DUZd4WKweswQLaal5VNEJ+JVmWAi81NZG lrvXNcWiLk8GpXNDngw3aiD+6ph37WNZCnxG2t1QgWFQVkrCTQrT/zqts9YlnueSGmhg YJdqEwKDV2CNuWagsNZo0R3NUX/Nr44owHC630BpcHBzkkpf4oBhj4e+/D27WfxPKLd4 Cu0A== X-Gm-Message-State: APjAAAWZ/ibi4Vv+RW+xyFopDAGJcUdrFL+ZMYkPsdL5Uqq9itxRw1Uo BxKYX6/jTw3CXBG6eSeEXXv+bO1E2B1qLukzKJs= X-Google-Smtp-Source: APXvYqxq0kNKbR0aT/7nSQNIKfSC0yOdCtkHu+Eq9h/o5SF7h3HDeGwYjUcOT50IIBc5FQtcfXws13kHxLYtXudWJRs= X-Received: by 2002:a2e:9b12:: with SMTP id u18mr13350055lji.142.1571620963520; Sun, 20 Oct 2019 18:22:43 -0700 (PDT) MIME-Version: 1.0 References: <20191020112344.19395-1-jakub@cloudflare.com> In-Reply-To: From: Alexei Starovoitov Date: Sun, 20 Oct 2019 18:22:31 -0700 Message-ID: Subject: Re: [PATCH bpf-next v2] scripts/bpf: Print an error when known types list needs updating To: Andrii Nakryiko Cc: Jakub Sitnicki , bpf , Networking , kernel-team , Andrii Nakryiko Content-Type: text/plain; charset="UTF-8" Sender: bpf-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: bpf@vger.kernel.org On Sun, Oct 20, 2019 at 5:52 PM Andrii Nakryiko wrote: > > On Sun, Oct 20, 2019 at 4:24 AM Jakub Sitnicki wrote: > > > > Don't generate a broken bpf_helper_defs.h header if the helper script needs > > updating because it doesn't recognize a newly added type. Instead print an > > error that explains why the build is failing, clean up the partially > > generated header and stop. > > > > v1->v2: > > - Switched from temporary file to .DELETE_ON_ERROR. > > > > Fixes: 456a513bb5d4 ("scripts/bpf: Emit an #error directive known types list needs updating") > > Suggested-by: Andrii Nakryiko > > Signed-off-by: Jakub Sitnicki Applied.Thanks