bpf.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Alexei Starovoitov <alexei.starovoitov@gmail.com>
To: Tobias Klauser <tklauser@distanz.ch>
Cc: Alexei Starovoitov <ast@kernel.org>,
	Daniel Borkmann <daniel@iogearbox.net>,
	Wang YanQing <udknight@gmail.com>, bpf <bpf@vger.kernel.org>,
	Network Development <netdev@vger.kernel.org>,
	X86 ML <x86@kernel.org>
Subject: Re: [PATCH bpf-next 1/2] bpf, x86: Factor common x86 JIT code
Date: Mon, 29 Jun 2020 10:48:23 -0700	[thread overview]
Message-ID: <CAADnVQLNAJoV1-0jADDMA=pv7f_P6nNdDVnYnVsLFQxJNgWbuQ@mail.gmail.com> (raw)
In-Reply-To: <20200629093336.20963-2-tklauser@distanz.ch>

On Mon, Jun 29, 2020 at 2:33 AM Tobias Klauser <tklauser@distanz.ch> wrote:
>
> Factor out code common for 32-bit and 64-bit x86 BPF JITs to bpf_jit.h
>
> Also follow other architectures and rename bpf_jit_comp.c to
> bpf_jit_comp64.c to be more explicit.
>
> Also adjust the file matching pattern in MAINTAINERS such that the
> common x86 files are included for both the 32-bit and 64-bit BPF JIT
> sections.
>
> Signed-off-by: Tobias Klauser <tklauser@distanz.ch>
> ---
>  MAINTAINERS                                   |   3 +-
>  arch/x86/net/Makefile                         |   2 +-
>  arch/x86/net/bpf_jit.h                        |  93 ++++++++++++
>  arch/x86/net/bpf_jit_comp32.c                 | 135 ++++--------------
>  .../net/{bpf_jit_comp.c => bpf_jit_comp64.c}  |  84 +----------
>  5 files changed, 123 insertions(+), 194 deletions(-)
>  create mode 100644 arch/x86/net/bpf_jit.h
>  rename arch/x86/net/{bpf_jit_comp.c => bpf_jit_comp64.c} (96%)

I don't see any value in such refactoring.
Looks like code churn to me.

  reply	other threads:[~2020-06-29 19:07 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-06-29  9:33 [PATCH bpf-next 0/2] Factor common x86 JIT code Tobias Klauser
2020-06-29  9:33 ` [PATCH bpf-next 1/2] bpf, x86: " Tobias Klauser
2020-06-29 17:48   ` Alexei Starovoitov [this message]
2020-06-30  5:20   ` kernel test robot
2020-07-11  3:13   ` kernel test robot
2020-06-29  9:33 ` [PATCH bpf-next 2/2] bpf, x86: Factor out get_cond_jmp_opcode and use for 64bit x86 Tobias Klauser

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAADnVQLNAJoV1-0jADDMA=pv7f_P6nNdDVnYnVsLFQxJNgWbuQ@mail.gmail.com' \
    --to=alexei.starovoitov@gmail.com \
    --cc=ast@kernel.org \
    --cc=bpf@vger.kernel.org \
    --cc=daniel@iogearbox.net \
    --cc=netdev@vger.kernel.org \
    --cc=tklauser@distanz.ch \
    --cc=udknight@gmail.com \
    --cc=x86@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).