From: Alexei Starovoitov <alexei.starovoitov@gmail.com>
To: Jakub Kicinski <kuba@kernel.org>
Cc: YueHaibing <yuehaibing@huawei.com>,
"David S. Miller" <davem@davemloft.net>,
Alexei Starovoitov <ast@kernel.org>,
Daniel Borkmann <daniel@iogearbox.net>,
Martin KaFai Lau <kafai@fb.com>, Song Liu <songliubraving@fb.com>,
Yonghong Song <yhs@fb.com>, Andrii Nakryiko <andrii@kernel.org>,
John Fastabend <john.fastabend@gmail.com>,
KP Singh <kpsingh@chromium.org>,
Masahiro Yamada <masahiroy@kernel.org>,
Network Development <netdev@vger.kernel.org>,
bpf <bpf@vger.kernel.org>, LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] bpfilter: Fix build error with CONFIG_BPFILTER_UMH
Date: Thu, 15 Oct 2020 12:03:14 -0700 [thread overview]
Message-ID: <CAADnVQLVvd_2zJTQJ7m=322H7M7NdTFfFE7f800XA=9HXVY28Q@mail.gmail.com> (raw)
In-Reply-To: <20201015115643.3a4d4820@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com>
On Thu, Oct 15, 2020 at 11:56 AM Jakub Kicinski <kuba@kernel.org> wrote:
>
> On Thu, 15 Oct 2020 11:53:08 -0700 Alexei Starovoitov wrote:
> > On Thu, Oct 15, 2020 at 9:37 AM Jakub Kicinski <kuba@kernel.org> wrote:
> > > On Wed, 14 Oct 2020 17:17:49 +0800 YueHaibing wrote:
> > > > IF CONFIG_BPFILTER_UMH is set, building fails:
> > > >
> > > > In file included from /usr/include/sys/socket.h:33:0,
> > > > from net/bpfilter/main.c:6:
> > > > /usr/include/bits/socket.h:390:10: fatal error: asm/socket.h: No such file or directory
> > > > #include <asm/socket.h>
> > > > ^~~~~~~~~~~~~~
> > > > compilation terminated.
> > > > scripts/Makefile.userprogs:43: recipe for target 'net/bpfilter/main.o' failed
> > > > make[2]: *** [net/bpfilter/main.o] Error 1
> > > >
> > > > Add missing include path to fix this.
> > > >
> > > > Signed-off-by: YueHaibing <yuehaibing@huawei.com>
> > >
> > > Applied, thank you!
> >
> > Please revert. The patch makes no sense.
>
> How so? It's using in-tree headers instead of system ones.
> Many samples seem to be doing the same thing.
There is no such thing as "usr/include" in the kernel build and source trees.
> > Also please don't take bpf patches.
>
> You had it marked it as netdev in your patchwork :/
It was delegated automatically by the patchwork system.
I didn't have time to reassign, but you should have known better
when you saw 'bpfilter' in the subject.
next prev parent reply other threads:[~2020-10-15 19:03 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-14 9:17 [PATCH] bpfilter: Fix build error with CONFIG_BPFILTER_UMH YueHaibing
2020-10-15 16:37 ` Jakub Kicinski
2020-10-15 18:53 ` Alexei Starovoitov
2020-10-15 18:56 ` Jakub Kicinski
2020-10-15 19:03 ` Alexei Starovoitov [this message]
2020-10-15 19:26 ` Jakub Kicinski
2020-10-15 19:57 ` Alexei Starovoitov
2020-10-16 6:18 ` Yuehaibing
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAADnVQLVvd_2zJTQJ7m=322H7M7NdTFfFE7f800XA=9HXVY28Q@mail.gmail.com' \
--to=alexei.starovoitov@gmail.com \
--cc=andrii@kernel.org \
--cc=ast@kernel.org \
--cc=bpf@vger.kernel.org \
--cc=daniel@iogearbox.net \
--cc=davem@davemloft.net \
--cc=john.fastabend@gmail.com \
--cc=kafai@fb.com \
--cc=kpsingh@chromium.org \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=masahiroy@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=songliubraving@fb.com \
--cc=yhs@fb.com \
--cc=yuehaibing@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).