From: Alexei Starovoitov <alexei.starovoitov@gmail.com>
To: "Daniel T. Lee" <danieltimlee@gmail.com>
Cc: Yonghong Song <yhs@fb.com>, Song Liu <liu.song.a23@gmail.com>,
Andrii Nakryiko <andrii.nakryiko@gmail.com>,
Daniel Borkmann <daniel@iogearbox.net>,
Alexei Starovoitov <ast@kernel.org>, bpf <bpf@vger.kernel.org>,
Network Development <netdev@vger.kernel.org>
Subject: Re: [PATCH bpf-next v7] samples: bpf: add max_pckt_size option at xdp_adjust_tail
Date: Mon, 7 Oct 2019 20:24:19 -0700 [thread overview]
Message-ID: <CAADnVQLYuNmVSdq3to2Sjpg3WmZF54A_OPTngMRZwToiDF5PoQ@mail.gmail.com> (raw)
In-Reply-To: <20191007172117.3916-1-danieltimlee@gmail.com>
On Mon, Oct 7, 2019 at 10:21 AM Daniel T. Lee <danieltimlee@gmail.com> wrote:
>
> Currently, at xdp_adjust_tail_kern.c, MAX_PCKT_SIZE is limited
> to 600. To make this size flexible, static global variable
> 'max_pcktsz' is added.
>
> By updating new packet size from the user space, xdp_adjust_tail_kern.o
> will use this value as a new max packet size.
>
> This static global variable can be accesible from .data section with
> bpf_object__find_map* from user space, since it is considered as
> internal map (accessible with .bss/.data/.rodata suffix).
>
> If no '-P <MAX_PCKT_SIZE>' option is used, the size of maximum packet
> will be 600 as a default.
>
> For clarity, change the helper to fetch map from 'bpf_map__next'
> to 'bpf_object__find_map_fd_by_name'. Also, changed the way to
> test prog_fd, map_fd from '!= 0' to '< 0', since fd could be 0
> when stdin is closed.
>
> Signed-off-by: Daniel T. Lee <danieltimlee@gmail.com>
>
> ---
> Changes in v6:
> - Remove redundant error message
Applied.
Please keep Acks if you're only doing minor tweaks between versions.
next prev parent reply other threads:[~2019-10-08 3:24 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-07 17:21 [PATCH bpf-next v7] samples: bpf: add max_pckt_size option at xdp_adjust_tail Daniel T. Lee
2019-10-08 3:24 ` Alexei Starovoitov [this message]
2019-10-08 4:13 ` Daniel T. Lee
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAADnVQLYuNmVSdq3to2Sjpg3WmZF54A_OPTngMRZwToiDF5PoQ@mail.gmail.com \
--to=alexei.starovoitov@gmail.com \
--cc=andrii.nakryiko@gmail.com \
--cc=ast@kernel.org \
--cc=bpf@vger.kernel.org \
--cc=daniel@iogearbox.net \
--cc=danieltimlee@gmail.com \
--cc=liu.song.a23@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=yhs@fb.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).