From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.6 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 85275C56202 for ; Fri, 6 Nov 2020 04:18:34 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 20F3F206E3 for ; Fri, 6 Nov 2020 04:18:34 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="sINzjgHv" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1725925AbgKFEQ6 (ORCPT ); Thu, 5 Nov 2020 23:16:58 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:32804 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725828AbgKFEQ6 (ORCPT ); Thu, 5 Nov 2020 23:16:58 -0500 Received: from mail-lj1-x241.google.com (mail-lj1-x241.google.com [IPv6:2a00:1450:4864:20::241]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id F3A30C0613CF; Thu, 5 Nov 2020 20:16:57 -0800 (PST) Received: by mail-lj1-x241.google.com with SMTP id k25so3899513lji.9; Thu, 05 Nov 2020 20:16:57 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=AoocLBBvUJrI0bLOOZTh8xYoi/tHgAN+ua/bhX68FM8=; b=sINzjgHvy6ulBGqRGUPhFTT730zcVjTJ63oLbOTnwWTF1dtv+m7Xh8tx18yvhbigwv K+jpB1Z7Me38xpsNnnWGAGqo5I6Dhy4ODfsmaqxXVigyKn13DnoNhggKaoB6OeiRqkte DADDhjdrXimmBRbhVBMJcpH6nwvlDP02GCB2IOy0ZIXbGRKZ9wBI0apeC/YziAXK7Kaw bHXhtm62DVkgDKYrIYHrDummNvSi15N+6xODSxRcU28nxu6fqSWHOA8g103z/NY+foYI oY1XXbuISgUEM9+DR05gTrcTC44RQlwPKqOQFrP6nVHQ2ZeSYGVL/BPwYJ89YWhBzrQe kKuw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=AoocLBBvUJrI0bLOOZTh8xYoi/tHgAN+ua/bhX68FM8=; b=mIOdPr8M3EcLfLEqdH1ebV/mp3BqPDDEQvhCBCHvaFlqtL+9dwCQaQmL1eR0YriU3H yvufzT4LOwx85w7ExS9+CXKOCnWDsFQhZvdD8D/nuCORJ7k6wlOVkTrvRdggWGdXbhGU IluiFUH61KRMx6xv3FOFhemfPNMM17pG4ZK3jLsR1N3zv79DIXnjilNVc4GkVr9162Gb VYFlIDIj7NelOExffCqhuOITMfZvK0gmtuZOYJkCgrO3iB1SpPz2n0MdNi3UI3VfTpy0 qElijBLtkh4APUDj2682QNYs7ZgPQn7Oq64L9482VRLJ4DQZQYip4TuZd8NEyxHfKI/Q mEHw== X-Gm-Message-State: AOAM533vnB27p3f/5ayK11SqjYIHSY8kMccaA5DTWDyjhr+5Nig5U73n oPEtbOUnUguVcIaBLZ7yd/dlJ7a0cYT0GubnoYM= X-Google-Smtp-Source: ABdhPJzT9gjrVO2QBAMOuWU6fZsr/CDjFypLslG8r4nvEDWzi5MHV9UIGjTVCPYTBekisHpRdbi6Mo2jTxCnzgVzqnE= X-Received: by 2002:a2e:9094:: with SMTP id l20mr35819ljg.290.1604636216488; Thu, 05 Nov 2020 20:16:56 -0800 (PST) MIME-Version: 1.0 References: <20201104191052.390657-1-ndesaulniers@google.com> In-Reply-To: <20201104191052.390657-1-ndesaulniers@google.com> From: Alexei Starovoitov Date: Thu, 5 Nov 2020 20:16:44 -0800 Message-ID: Subject: Re: [PATCH] compiler-clang: remove version check for BPF Tracing To: Nick Desaulniers Cc: Andrew Morton , stable , Chen Yu , Jarkko Sakkinen , Alexei Starovoitov , Daniel Borkmann , Martin KaFai Lau , Song Liu , Yonghong Song , Andrii Nakryiko , John Fastabend , KP Singh , Nathan Chancellor , Miguel Ojeda , Kees Cook , Marco Elver , Arvind Sankar , Randy Dunlap , Sami Tolvanen , Ingo Molnar , LKML , Network Development , bpf , Clang-Built-Linux ML Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: bpf@vger.kernel.org On Wed, Nov 4, 2020 at 11:11 AM Nick Desaulniers wrote: > > bpftrace parses the kernel headers and uses Clang under the hood. Remove > the version check when __BPF_TRACING__ is defined (as bpftrace does) so > that this tool can continue to parse kernel headers, even with older > clang sources. > > Cc: > Fixes: commit 1f7a44f63e6c ("compiler-clang: add build check for clang 10.0.1") > Reported-by: Chen Yu > Reported-by: Jarkko Sakkinen > Signed-off-by: Nick Desaulniers > --- > include/linux/compiler-clang.h | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/include/linux/compiler-clang.h b/include/linux/compiler-clang.h > index dd7233c48bf3..98cff1b4b088 100644 > --- a/include/linux/compiler-clang.h > +++ b/include/linux/compiler-clang.h > @@ -8,8 +8,10 @@ > + __clang_patchlevel__) > > #if CLANG_VERSION < 100001 > +#ifndef __BPF_TRACING__ > # error Sorry, your version of Clang is too old - please use 10.0.1 or newer. > #endif > +#endif I can take it through the bpf tree if no one objects.