From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8187FC4360C for ; Sun, 13 Oct 2019 04:59:42 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 51A61206A3 for ; Sun, 13 Oct 2019 04:59:42 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="qoybofSO" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727492AbfJME7l (ORCPT ); Sun, 13 Oct 2019 00:59:41 -0400 Received: from mail-lf1-f65.google.com ([209.85.167.65]:33789 "EHLO mail-lf1-f65.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727354AbfJME7l (ORCPT ); Sun, 13 Oct 2019 00:59:41 -0400 Received: by mail-lf1-f65.google.com with SMTP id y127so9622790lfc.0; Sat, 12 Oct 2019 21:59:39 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=Q6UM81QVu0g8B790B9HS33FwVmQAj8ztbARaQxYqUMg=; b=qoybofSOmnKeQDR+5nHiLTGyULrVm194uVIlttyiLvZwXxGksFpZnbvGsxS5cjGsGZ mhrrfjyHsMioENy5pUql0BN9/tYNil09990SNvJs1RFeqrs1jSSNv+jtJEmsrhEiwxDp bGZQap8fD5+OREbsF2pIWL9xBk2lrACUuoP3zzgQkvzE0sRByLMWtbApMnJ2PI7Ad9Wg wsVA7ZmuzxrGtcLSKy2eY195ovwxN9qj0xqkn/n/GtYhkmDs37i/eKOmDkU4YndK8Iiu k3U5mtbb5Rf16rsKm9+rYDWbjgU/8l0UR/iLbypVbjR73K/w0HHXcfAWbbuRINwjSzeh /B5g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=Q6UM81QVu0g8B790B9HS33FwVmQAj8ztbARaQxYqUMg=; b=UBIUQ0cSo3SIPxTjMw+KWh2nu6EKX1Wf1igAMXsccU/3YAf1EUM9mbUQzk4RJsBCYu a51AgXbhbfgo3QRWdCvkjKYhFVjS61Hd5VBniK0lIpglFmlqmk2NZIu7e5Bv4fQzF+W2 K9Ethm/zu3+Xzde8nHV8aIiXcgLXljNLktPfsJPVfSO5MfpfOxScfZ5rMoCnBXlY1iGQ ErabzeAGtUG6ZEjMfbKobk7O7EjoHOEtS7tcaY2SgkZNomYqnNSGEZpqn6bEprwJL5dO Su8LYyAF+7cM6zGN699B4Na5yARRUmOjazXpzofbIvOT7l0T+/NCwhcieyUeFvZruC8A CDTg== X-Gm-Message-State: APjAAAXcU52rO6oMEwJL2mxlEYZ9HMC/5cBNwbQXSD34byO8CH2ZT6eh lG2Q9VnU9yfuV5YoL758whVmG7eugOWcbLkhPq4= X-Google-Smtp-Source: APXvYqy1wi9v13QqBiW8S7d3gqZHecXqoR5sYStLbxjbsSYRGtJKipwZT669sLcw5kjSpb2Try4PW9H/wejLhGAB3B4= X-Received: by 2002:a19:5050:: with SMTP id z16mr14394005lfj.181.1570942778928; Sat, 12 Oct 2019 21:59:38 -0700 (PDT) MIME-Version: 1.0 References: <5da2ad7f.1c69fb81.2ed87.f547SMTPIN_ADDED_BROKEN@mx.google.com> In-Reply-To: <5da2ad7f.1c69fb81.2ed87.f547SMTPIN_ADDED_BROKEN@mx.google.com> From: Alexei Starovoitov Date: Sat, 12 Oct 2019 21:59:26 -0700 Message-ID: Subject: Re: [PATCH bpf] libbpf: fix passing uninitialized bytes to setsockopt To: Ilya Maximets Cc: "netdev@vger.kernel.org" , "bpf@vger.kernel.org" , "linux-kernel@vger.kernel.org" , Alexei Starovoitov , Daniel Borkmann , "David S . Miller" , Jonathan Lemon Content-Type: text/plain; charset="UTF-8" Sender: bpf-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: bpf@vger.kernel.org On Sat, Oct 12, 2019 at 9:52 PM Ilya Maximets wrote: > > 'struct xdp_umem_reg' has 4 bytes of padding at the end that makes > valgrind complain about passing uninitialized stack memory to the > syscall: > > Syscall param socketcall.setsockopt() points to uninitialised byte(s) > at 0x4E7AB7E: setsockopt (in /usr/lib64/libc-2.29.so) > by 0x4BDE035: xsk_umem__create@@LIBBPF_0.0.4 (xsk.c:172) > Uninitialised value was created by a stack allocation > at 0x4BDDEBA: xsk_umem__create@@LIBBPF_0.0.4 (xsk.c:140) > > Padding bytes appeared after introducing of a new 'flags' field. > > Fixes: 10d30e301732 ("libbpf: add flags to umem config") > Signed-off-by: Ilya Maximets Something is not right with (e|g)mail. This is 3rd email I got with the same patch. First one (the one that was applied) was 3 days ago.