From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.1 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 63A73C04AAF for ; Thu, 16 May 2019 19:50:20 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 3977B2082E for ; Thu, 16 May 2019 19:50:20 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="ANoFkUZ5" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726523AbfEPTuT (ORCPT ); Thu, 16 May 2019 15:50:19 -0400 Received: from mail-lj1-f195.google.com ([209.85.208.195]:34023 "EHLO mail-lj1-f195.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726519AbfEPTuT (ORCPT ); Thu, 16 May 2019 15:50:19 -0400 Received: by mail-lj1-f195.google.com with SMTP id j24so4249768ljg.1; Thu, 16 May 2019 12:50:18 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=KSYFmnA9eWWLhRZS08HYOCsYCy2SOuZ4e0aM+KE0WVc=; b=ANoFkUZ5sAwab5YdVJ0Xm2+8cDq5G/jPbZGJ7r6qhzsp+4oxAlT2wAqJBJAeFSRSqe +WY2OHOviCdRockUMRL9Zwzi5dBoQIEjxW1Z2XHmHolwZuTiEoO77CpuX9vD/aYGMkQR ZSnG9I7MxxWHbkb74p0AxLkQha0UAdJ3tRc8IyaRfdb5BNoIAjhGSLjkKnwWPK+VttX5 SVvRlCfqYCL3/aWsSZ3y7BluJIIOb2C3Tqn8zMbl0mDXplsVCEBQFdCw73xePoZVPol+ 7h65ekuzls9ZIEcy3aUgKz1ZEdhPNx4FKD1FJc3DT66T2T8PXdqAWcCXjqnxEbqDZgel kmyA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=KSYFmnA9eWWLhRZS08HYOCsYCy2SOuZ4e0aM+KE0WVc=; b=BCVB7MQ85SR6Dibb5P2/n9Zed+qSTTcK1MNKp/ZFNp6dnjtudz3hfgbolDKySTMYWD WnFxY8eSOkg2ezxQXjH820ypdn3+FH04d+3vg4btVIzJp4kdei/SdaysX1ZktU4UuFry bE3DUnO2SSxgYUvqLyPuMn2WXorc1JT2NCq/9zPv8E7MD0Nlisl91JJ2q5vWDfCWB10p +uwV75bgl67MgEf/CqTdgbOd/xKhf9BXWnxoOEZbfLb487au0g53kKR5m2JG2v2p+qYM jRZAlyDRrQHlbjeTNyW3N/Lw8x9PQjsUpx0hbGXC+/FtILIGhsiYPhJEOT47kF3zHde3 qNYA== X-Gm-Message-State: APjAAAVNGxNBOecrhqe/Q0k0ZIOdcmPbSluj2iNWgqlfhTUgmxRBwu3e U9Ee567vsSvhcBOKjhRHOmqcvd7Cz2WAO9AJCTY= X-Google-Smtp-Source: APXvYqz/LEs1QdSNRfkt+ypL+QM5F568mGeQcYUfzZeAMEjhGP4XuGG0PdcYZLPcOShkWOGJd3v4F/jjK27Xx0NtDgo= X-Received: by 2002:a2e:a294:: with SMTP id k20mr19646012lja.118.1558036217477; Thu, 16 May 2019 12:50:17 -0700 (PDT) MIME-Version: 1.0 References: <20190516033927.2425057-1-andriin@fb.com> In-Reply-To: <20190516033927.2425057-1-andriin@fb.com> From: Alexei Starovoitov Date: Thu, 16 May 2019 12:50:05 -0700 Message-ID: Subject: Re: [PATCH bpf] libbpf: move logging helpers into libbpf_internal.h To: Andrii Nakryiko Cc: Andrii Nakryiko , Network Development , bpf , Alexei Starovoitov , Stanislav Fomichev , Daniel Borkmann Content-Type: text/plain; charset="UTF-8" Sender: bpf-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: bpf@vger.kernel.org On Wed, May 15, 2019 at 8:39 PM Andrii Nakryiko wrote: > > libbpf_util.h header was recently exposed as public as a dependency of > xsk.h. In addition to memory barriers, it contained logging helpers, > which are not supposed to be exposed. This patch moves those into > libbpf_internal.h, which is kept as an internal header. > > Cc: Stanislav Fomichev > Cc: Daniel Borkmann > Fixes: 7080da890984 ("libbpf: add libbpf_util.h to header install.") > Signed-off-by: Andrii Nakryiko Applied. Thanks