bpf.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Alexei Starovoitov <alexei.starovoitov@gmail.com>
To: Xu Kuohai <xukuohai@huawei.com>
Cc: bpf <bpf@vger.kernel.org>, Brian Vazquez <brianvv@google.com>,
	Alexei Starovoitov <ast@kernel.org>,
	Daniel Borkmann <daniel@iogearbox.net>,
	Yonghong Song <yhs@fb.com>
Subject: Re: [PATCH bpf] bpf: Fix error usage of map_fd and fdget() in generic_map_update_batch()
Date: Thu, 21 Oct 2021 15:04:48 -0700	[thread overview]
Message-ID: <CAADnVQLm_z5cdXOgUpt0e+YGzMcFUkgE-0c7xYsCERzScDOKuw@mail.gmail.com> (raw)
In-Reply-To: <20211019032934.1210517-1-xukuohai@huawei.com>

On Mon, Oct 18, 2021 at 8:24 PM Xu Kuohai <xukuohai@huawei.com> wrote:
>
> 1. The ufd in generic_map_update_batch() should be read from batch.map_fd;
> 2. A call to fdget() should be followed by a symmetric call to fdput().
>
> Fixes: aa2e93b8e58e ("bpf: Add generic support for update and delete batch ops")
> Signed-off-by: Xu Kuohai <xukuohai@huawei.com>

Ouch. Thanks for the fix. Applied.

Brian,
when your bugs are fixed please pay attention in the future and
review the fix with Reviewed-by or Acked-by.

  reply	other threads:[~2021-10-21 22:05 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-10-19  3:29 [PATCH bpf] bpf: Fix error usage of map_fd and fdget() in generic_map_update_batch() Xu Kuohai
2021-10-21 22:04 ` Alexei Starovoitov [this message]
2021-10-21 22:22   ` Brian Vazquez

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAADnVQLm_z5cdXOgUpt0e+YGzMcFUkgE-0c7xYsCERzScDOKuw@mail.gmail.com \
    --to=alexei.starovoitov@gmail.com \
    --cc=ast@kernel.org \
    --cc=bpf@vger.kernel.org \
    --cc=brianvv@google.com \
    --cc=daniel@iogearbox.net \
    --cc=xukuohai@huawei.com \
    --cc=yhs@fb.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).