From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.6 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E18A3C35242 for ; Tue, 11 Feb 2020 23:26:30 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id B65AF20842 for ; Tue, 11 Feb 2020 23:26:30 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="kLJeqEt5" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727865AbgBKX00 (ORCPT ); Tue, 11 Feb 2020 18:26:26 -0500 Received: from mail-lj1-f195.google.com ([209.85.208.195]:44782 "EHLO mail-lj1-f195.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727597AbgBKX00 (ORCPT ); Tue, 11 Feb 2020 18:26:26 -0500 Received: by mail-lj1-f195.google.com with SMTP id q8so96263ljj.11; Tue, 11 Feb 2020 15:26:25 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=b+UnFJdAm9s/f93leG1ycIqg/kGef55fT1Md7EMcfbM=; b=kLJeqEt5CYtm8yUjPsFzYb9Z+Y0vuRc0rVpStu4m6kw4CA52xUgmo2SVKD4xLYQwpb tRAheeXe9hu0u6CraeycsJ7+itG45yM4VnVBDtbo/IUeWC0LpB7pIU8dzTssDeFwAR7j MtOxnPATkeSWcwTKri1i6ZRt/N/Aj23R2ijnr5hagD6F3i1mMp69nf35zwu+xnOOxizG NwLxQyjonLIlZwmnM+ZONki0vHWJShUSPHsiZRQqU/psifcRvbDaCmW3YpIm7byLezLX YIKBLGgdczORPtgVgwPYXN1Oq4oDncolkZ6Z1y9+gt4TNSM7bjsLOG6k1vqj/+bp78q1 B/fg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=b+UnFJdAm9s/f93leG1ycIqg/kGef55fT1Md7EMcfbM=; b=JOqqR0yZqsqTSqhWQoCRjD+yJjEVBtCIKrY9MbntqRXmRvVoeUNy/BFPdIbfn5XxZv AEPCVfR0+IEMQZtDglHE6K+GhW3AP1VqxnkraAla5wG2bUos/UjShwMsSjpjYo5xwC/F Of7KM433HDarzsU8kwdeFvuI38l+UBZYqfUxzbEJZd1zxJvh5cVXkz6BPRMfkWhKehS6 YAWuD8uCTE0pfQGAhkaM0kgDPH727mal9rXM8dK8xGrHKIw8xaQac2ZVKRgZTL5EdP84 ztlsgtHSwXyD27Ma2s5Cx70P4BjzwlNV+bQDZv6kJevgB3fxrezhBt+bDHnlhT2zoTUe WGTQ== X-Gm-Message-State: APjAAAUj9BKdwePx9YOrtSdsTj2MsuFyB6GwLqYPMcKOyEqhiEffOqix BmejVLGPS/uVIxIXyMmtsKoHQ3Z/MV11PBgGqao= X-Google-Smtp-Source: APXvYqwaKatfhBd0fIQTVs5Yimze4i5NNaCnOiThpMyD9BiV7j3UfnGigS0KE40nNkDY0UIiFZWe669eMpM7R9PkmoA= X-Received: by 2002:a2e:8145:: with SMTP id t5mr5874745ljg.144.1581463584142; Tue, 11 Feb 2020 15:26:24 -0800 (PST) MIME-Version: 1.0 References: <20200123152440.28956-1-kpsingh@chromium.org> <20200123152440.28956-5-kpsingh@chromium.org> <20200211031208.e6osrcathampoog7@ast-mbp> <20200211124334.GA96694@google.com> <20200211175825.szxaqaepqfbd2wmg@ast-mbp> <20200211190943.sysdbz2zuz5666nq@ast-mbp> <20200211201039.om6xqoscfle7bguz@ast-mbp> <20200211213819.j4ltrjjkuywihpnv@ast-mbp> In-Reply-To: <20200211213819.j4ltrjjkuywihpnv@ast-mbp> From: Alexei Starovoitov Date: Tue, 11 Feb 2020 15:26:12 -0800 Message-ID: Subject: Re: BPF LSM and fexit [was: [PATCH bpf-next v3 04/10] bpf: lsm: Add mutable hooks list for the BPF LSM] To: Jann Horn Cc: KP Singh , kernel list , bpf , linux-security-module , Brendan Jackman , Florent Revest , Thomas Garnier , Alexei Starovoitov , Daniel Borkmann , James Morris , Kees Cook , Thomas Garnier , Michael Halcrow , Paul Turner , Brendan Gregg , Matthew Garrett , Christian Brauner , =?UTF-8?B?TWlja2HDq2wgU2FsYcO8bg==?= , Florent Revest , Brendan Jackman , "Serge E. Hallyn" , Mauro Carvalho Chehab , "David S. Miller" , Greg Kroah-Hartman , Kernel Team Content-Type: text/plain; charset="UTF-8" Sender: bpf-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: bpf@vger.kernel.org On Tue, Feb 11, 2020 at 1:38 PM Alexei Starovoitov wrote: > > On Tue, Feb 11, 2020 at 09:33:49PM +0100, Jann Horn wrote: > > > > > > Got it. Then let's whitelist them ? > > > All error injection points are marked with ALLOW_ERROR_INJECTION(). > > > We can do something similar here, but let's do it via BTF and avoid > > > abusing yet another elf section for this mark. > > > I think BTF_TYPE_EMIT() should work. Just need to pick explicit enough > > > name and extensive comment about what is going on. > > > > Sounds reasonable to me. :) > > awesome :) Looks like the kernel already provides this whitelisting. $ bpftool btf dump file /sys/kernel/btf/vmlinux |grep FUNC|grep '\