bpf.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Alexei Starovoitov <alexei.starovoitov@gmail.com>
To: Joanne Koong <joannekoong@fb.com>
Cc: tcs.kernel@gmail.com, Alexei Starovoitov <ast@kernel.org>,
	Daniel Borkmann <daniel@iogearbox.net>,
	Andrii Nakryiko <andrii@kernel.org>,
	Martin KaFai Lau <kafai@fb.com>, Song Liu <songliubraving@fb.com>,
	Yonghong Song <yhs@fb.com>,
	John Fastabend <john.fastabend@gmail.com>,
	KP Singh <kpsingh@kernel.org>, bpf <bpf@vger.kernel.org>,
	Haimin Zhang <tcs_kernel@tencent.com>
Subject: Re: [PATCH v2] bpf: Add missing map_get_next_key method to bloom filter map
Date: Wed, 29 Dec 2021 09:41:58 -0800	[thread overview]
Message-ID: <CAADnVQLth6eh3UfdkHgKAX+UCTSyizw6OAc7-ZS0WEQgdj1b5g@mail.gmail.com> (raw)
In-Reply-To: <1c8f6a26-658c-8986-2186-7e1868850cc2@fb.com>

On Wed, Dec 29, 2021 at 9:22 AM Joanne Koong <joannekoong@fb.com> wrote:
>
> On 12/29/21 3:20 AM, tcs.kernel@gmail.com wrote:
>
> > From: Haimin Zhang <tcs_kernel@tencent.com>
> >
> > Without it, kernel crashes in map_get_next_key().
> >
> > Fixes: 9330986c0300 ("bpf: Add bloom filter map implementation")
> >
> > Reported-by: TCS Robot <tcs_robot@tencent.com>
> > Signed-off-by: Haimin Zhang <tcs_kernel@tencent.com>
> > Signed-off-by: Daniel Borkmann <daniel@iogearbox.net>

Haimin,

Daniel didn't give you his SOB in v1 patch, so I've dropped it
while applying.


> > ---
>
> Thanks for fixing this. I'll take a look at the other bpf_map_ops and see if
> there are other missing ones.
>
> Acked-by: Joanne Koong <joannekoong@fb.com>


Thanks everyone.

      reply	other threads:[~2021-12-29 17:42 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-12-29 11:20 [PATCH v2] bpf: Add missing map_get_next_key method to bloom filter map tcs.kernel
2021-12-29 17:21 ` Joanne Koong
2021-12-29 17:41   ` Alexei Starovoitov [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAADnVQLth6eh3UfdkHgKAX+UCTSyizw6OAc7-ZS0WEQgdj1b5g@mail.gmail.com \
    --to=alexei.starovoitov@gmail.com \
    --cc=andrii@kernel.org \
    --cc=ast@kernel.org \
    --cc=bpf@vger.kernel.org \
    --cc=daniel@iogearbox.net \
    --cc=joannekoong@fb.com \
    --cc=john.fastabend@gmail.com \
    --cc=kafai@fb.com \
    --cc=kpsingh@kernel.org \
    --cc=songliubraving@fb.com \
    --cc=tcs.kernel@gmail.com \
    --cc=tcs_kernel@tencent.com \
    --cc=yhs@fb.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).