From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D8E8DC433E0 for ; Tue, 5 Jan 2021 11:57:22 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 8FA2522AAB for ; Tue, 5 Jan 2021 11:57:22 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729696AbhAEL5W (ORCPT ); Tue, 5 Jan 2021 06:57:22 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:32922 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726074AbhAEL5V (ORCPT ); Tue, 5 Jan 2021 06:57:21 -0500 Received: from mail-pg1-x535.google.com (mail-pg1-x535.google.com [IPv6:2607:f8b0:4864:20::535]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 723E1C061574; Tue, 5 Jan 2021 03:56:41 -0800 (PST) Received: by mail-pg1-x535.google.com with SMTP id c132so9812159pga.3; Tue, 05 Jan 2021 03:56:41 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=GjrvkpU/AGcjZIUG3h6dX5jurwGnXUE8Hhbb+57Aipw=; b=uAuJvOVujn0Z5sGNtyDbi/ashwYJSbTpzoLztZFtgfEbcwJtywI68EvNRYMlpPd7QG 0LzloFAVKZ8OkNjcRcga0U4S/8BMKeggB5FkGm+n4U6sZa86M30hMwOaasFoN21KnFDY df//0Z0zPZzrhwFQAGDoGgHXbQa21MBcCgolZo2CsB+14kquOiKLXh7lrqF0RnpzX8Ow EzM+GZNQ4b9f3U4/7SSUOqcvjSJQEwBnZ1bIiSVIjAld3HElrMoQ5D3N7236k9zaW5wx OTpczU8omOuLtCqPkDoDPHV3YmY6w9P4mqnXsNni15n2VKsEXaCSHJEvftKLsXnw3gV+ 42Uw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=GjrvkpU/AGcjZIUG3h6dX5jurwGnXUE8Hhbb+57Aipw=; b=mhuq/pKF6o1QiC38mfrKNW/nTgYa5gMBnBgq63X7wOfmFZOmi1mYJysQ5b9jP09A3A +XaZBM9UnVMNKUJqg8H2tPPmq93NNje5AO5WqqQwhACXJ6RJrsEAhhSZHDUpYrDy7g7o eO6BQykuV+w2IqEDLfMX4Ps2+usl027vlXCh8zTyepyf/QH1DRcwqGRNDUtaezApiJmK qEv33eM2DqlvpHRM9M6Gar1ilT+Q2KpQF305pY0hppRJV2EjPp280wQ3W8EcMoJUQsPY j47LjQK3je9ATxRldSrPkQLBae9R3retMn849Zr5kOfPL+sBQz9K1b9dWYnIBdmpFry0 sUKg== X-Gm-Message-State: AOAM530msxHiXaR1+YGj0AZTmMyu3L6wxWTKylW5HXm1woTDTGDKJ1ej ZUFuao9ukTWflqcYlOPGlQZytqimXI89QrkgvVH0blr9TeM= X-Google-Smtp-Source: ABdhPJwWMUSo118gSNiRmh+JZtN0BRDD9lpvkGrw2nOb6SpOHeJoAtyQmix72gXZCCy2DA8c3OypCO2eVLllZyoCgs4= X-Received: by 2002:a62:e516:0:b029:156:3b35:9423 with SMTP id n22-20020a62e5160000b02901563b359423mr47629907pff.19.1609847801044; Tue, 05 Jan 2021 03:56:41 -0800 (PST) MIME-Version: 1.0 References: <20201204102901.109709-1-marekx.majtyka@intel.com> <20201204102901.109709-2-marekx.majtyka@intel.com> <878sad933c.fsf@toke.dk> <20201204124618.GA23696@ranger.igk.intel.com> <048bd986-2e05-ee5b-2c03-cd8c473f6636@iogearbox.net> <20201207135433.41172202@carbon> <5fce960682c41_5a96208e4@john-XPS-13-9370.notmuch> <20201207230755.GB27205@ranger.igk.intel.com> <5fd068c75b92d_50ce20814@john-XPS-13-9370.notmuch> <20201209095454.GA36812@ranger.igk.intel.com> <20201209125223.49096d50@carbon> <1e5e044c8382a68a8a547a1892b48fb21d53dbb9.camel@kernel.org> <6f8c23d4ac60525830399754b4891c12943b63ac.camel@kernel.org> In-Reply-To: <6f8c23d4ac60525830399754b4891c12943b63ac.camel@kernel.org> From: Marek Majtyka Date: Tue, 5 Jan 2021 12:56:30 +0100 Message-ID: Subject: Re: [PATCH v2 bpf 1/5] net: ethtool: add xdp properties flag set To: Saeed Mahameed , David Ahern , Maciej Fijalkowski , John Fastabend , Jesper Dangaard Brouer , Daniel Borkmann , =?UTF-8?B?VG9rZSBIw7hpbGFuZC1Kw7hyZ2Vuc2Vu?= , Maciej Fijalkowski Cc: =?UTF-8?B?QmrDtnJuIFTDtnBlbA==?= , Andrii Nakryiko , Jonathan Lemon , Alexei Starovoitov , Network Development , "David S. Miller" , hawk@kernel.org, bpf , intel-wired-lan , Jakub Kicinski , "Karlsson, Magnus" , jeffrey.t.kirsher@intel.com Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: bpf@vger.kernel.org I would like to thank you for your time, comments, nitpicking as well as encouraging. One thing needs clarification I think, that is, that those flags describe driver static feature sets - which are read-only. They have nothing in common with driver runtime configuration change yet. Runtime change of this state can be added but it needs a new variable and it can be done later on if someone needs it. Obviously, it is not possible to make everybody happy, especially with XDP_BASE flags set. To be honest, this XDP_BASE definition is a syntactic sugar for me and I can live without it. We can either remove it completely, from which IMO we all and other developers will suffer later on, or maybe we can agree on these two helper set of flags: XDP_BASE (TX, ABORTED, PASS, DROP) and XDP_LIMITED_BASE(ABORTED,PASS_DROP). What do you think? I am also going to add a new XDP_REDIRECT_TARGET flag and retrieving XDP flags over rtnelink interface. I also think that for completeness, ethtool implementation should be kept together with rtnelink part in order to cover both ip and ethtool tools. Do I have your approval or disagreement? Please let me know. Both AF_XDP_ZEROCOPY and XDP_SOCK_ZEROCOPY are good to me. I will pick the one XDP_SOCK_ZEROCOPY unless there are protests. I don't think that HEADROOM parameter should be passed via the flags. It is by nature a number and an attempt to quantize with flags seems to be an unnatural limitation for the future. Thanks Marek