From: Ferenc Fejes <email@example.com> To: firstname.lastname@example.org Cc: email@example.com, firstname.lastname@example.org, email@example.com, Martin KaFai Lau <firstname.lastname@example.org>, Lawrence Brakmo <email@example.com>, "David S . Miller" <firstname.lastname@example.org> Subject: Re: [PATCH net-next] Extending bpf_setsockopt with SO_BINDTODEVICE sockopt Date: Thu, 21 May 2020 23:55:12 +0200 Message-ID: <CAAej5NZMBTsoSMh2RJF19WwZNDxq5cLE2dy3TC0Od+yh05VP=A@mail.gmail.com> (raw) In-Reply-To: <20200521211432.GC49942@google.com> > Any specific reason you're not reusing sock_setbindtodevice or at least > sock_setbindtodevice_locked here? I think, historically, we've > reimplemented some of the sockopts because they were 'easy' (i.e. > were just setting a flag in the socket), this one looks more involved. Yes, there is a copy_from_user in the sock_setbindtodevice for copying the ioctl netdev name from the user which (I think) not necessary here. However sock_setbindtodevice_locked is the way to go but I was afraid to forward declare it in sock.h, change the linkage and export it in sock.c (I find that a little bit too intrusive). > I'd suggest, add an optional 'lock_sk' argument to sock_setbindtodevice, > call it with 'true' from real setsockopt, and call it with 'false' > here. Thanks for the advice. However I think I'll wait what happens with this patch: https://email@example.com/T/#u Very strange coincidence that patch was submitted a few hours before mine (but I noticed just now) and refactor the sock_setbindtodevice in a way that will useful in my case (also define it in sock.h). > And, as Andrii pointed out, it would be nice to have a selftest > that exercises this new option. Thanks, I will implement them in the next iteration.
prev parent reply index Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top 2020-05-21 12:52 Ferenc Fejes 2020-05-21 19:09 ` Andrii Nakryiko 2020-05-21 21:14 ` sdf 2020-05-21 21:55 ` Ferenc Fejes [this message]
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to='CAAej5NZMBTsoSMh2RJF19WwZNDxq5cLE2dy3TC0Od+yh05VP=A@mail.gmail.com' \ --firstname.lastname@example.org \ --email@example.com \ --firstname.lastname@example.org \ --email@example.com \ --firstname.lastname@example.org \ --email@example.com \ --firstname.lastname@example.org \ --email@example.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
BPF Archive on lore.kernel.org Archives are clonable: git clone --mirror https://lore.kernel.org/bpf/0 bpf/git/0.git # If you have public-inbox 1.1+ installed, you may # initialize and index your mirror using the following commands: public-inbox-init -V2 bpf bpf/ https://lore.kernel.org/bpf \ firstname.lastname@example.org public-inbox-index bpf Example config snippet for mirrors Newsgroup available over NNTP: nntp://nntp.lore.kernel.org/org.kernel.vger.bpf AGPL code for this site: git clone https://public-inbox.org/public-inbox.git