From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.9 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id ECBA5C352AA for ; Wed, 2 Oct 2019 15:50:32 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id C0F5921848 for ; Wed, 2 Oct 2019 15:50:32 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=cloudflare.com header.i=@cloudflare.com header.b="eHNq+x9e" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728737AbfJBPuc (ORCPT ); Wed, 2 Oct 2019 11:50:32 -0400 Received: from mail-oi1-f196.google.com ([209.85.167.196]:46356 "EHLO mail-oi1-f196.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728736AbfJBPuc (ORCPT ); Wed, 2 Oct 2019 11:50:32 -0400 Received: by mail-oi1-f196.google.com with SMTP id k25so18023234oiw.13 for ; Wed, 02 Oct 2019 08:50:31 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cloudflare.com; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc:content-transfer-encoding; bh=XPi23PQ3ntrJN4vwnFwOV3iiejI/uiaQJJXoux+ak0I=; b=eHNq+x9e3grDWF9FADg+Uq3zpxAVrmz2HUc0eGIZ3zLPLUWCLWzi3PbAQvJi5x81bs XaN+SLrQ3ocESNPArhR9QE3cmg8CA7ofNnK2hDevrtkotdEX932qSEdagljwVCN1/oCC GsoRTSoLVr3ZVMzblw58nd8gPaKIAhwanYgVg= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=XPi23PQ3ntrJN4vwnFwOV3iiejI/uiaQJJXoux+ak0I=; b=TjUX4qU1wWg9Zee6N4kDrDi+6srC/ciWvG/L0rHc8UYNGf7EYrVCWA6kSeVFLwiuA1 YIQtlSC3lDrQBwOuVBcItNXQxsjuJyu4P0ZEPAc4ExpT17bq7gPS0mxmWilngylngA1B BQ7WOug5Y+6pgk+Bke+UizhbNWd8a8oFnr+fnR0ah4/y+cD7Sa2Ay0AB+D8CLvHFxKMc q39psfoTj8rxUyN/jzeFYbfiB+3TxUOtQdC8SzVzAKYOhVgHsu5mbo3YlQZwBM9SLz7x u1jQ9mYha6BJmpP5ErVNHLqJwSSpZTzql+f8FmLzy7e58RAx/svTSjLcUIbCmVeJsQq4 IxPg== X-Gm-Message-State: APjAAAU2c3cyferQAALCqVE9H4sZFPSl4grPqg6iLwvU905Yucn0pHBn 8BAV/BGY+c0ZUZ1IgEW0HNaHT60/iv+jMMBUvpQEcA== X-Google-Smtp-Source: APXvYqzdQir8sEmBMINkIdrrlG7+jwPznL9m21FBsLaWxLZKLykHRd/1vLIB2wFQXhPNi8t6PJAjFkLARdQflSWiLVA= X-Received: by 2002:aca:3556:: with SMTP id c83mr3277944oia.78.1570031431218; Wed, 02 Oct 2019 08:50:31 -0700 (PDT) MIME-Version: 1.0 References: <157002302448.1302756.5727756706334050763.stgit@alrua-x1> <157002302784.1302756.2073486805381846919.stgit@alrua-x1> In-Reply-To: <157002302784.1302756.2073486805381846919.stgit@alrua-x1> From: Lorenz Bauer Date: Wed, 2 Oct 2019 16:50:18 +0100 Message-ID: Subject: Re: [PATCH bpf-next 3/9] xdp: Support setting and getting device chain map To: =?UTF-8?B?VG9rZSBIw7hpbGFuZC1Kw7hyZ2Vuc2Vu?= Cc: Daniel Borkmann , Alexei Starovoitov , Martin KaFai Lau , Song Liu , Yonghong Song , Marek Majkowski , David Miller , Jesper Dangaard Brouer , Networking , bpf , kernel-team Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Sender: bpf-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: bpf@vger.kernel.org On Wed, 2 Oct 2019 at 14:30, Toke H=C3=B8iland-J=C3=B8rgensen wrote: > > From: Toke H=C3=B8iland-J=C3=B8rgensen > > This adds support to rtnetlink for setting and getting the per-device XDP > chain map. The map is set by means of a new netlink attribute that contai= ns > a pointer to a BPF map of the XDP chain type. If such an attribute is > included, it will be inserted into the struct net_device so that the XDP > chain call code will pick it up on program execution. > > To prevent old userspace programs that do not understand the chain map > attribute from messing up the chain call order, a netlink message with no > chain map attribute set will be rejected if a chain map has already been > installed. > > When installing a new chain call map, an XDP program fd must also be > provided, otherwise the operation will be rejected. Why is the program required? I kind of expected the chain call map to override any program. -- Lorenz Bauer | Systems Engineer 6th Floor, County Hall/The Riverside Building, SE1 7PB, UK www.cloudflare.com