bpf.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Lorenz Bauer <lmb@cloudflare.com>
To: Andrii Nakryiko <andrii@kernel.org>, Yonghong Song <yhs@fb.com>
Cc: bpf <bpf@vger.kernel.org>
Subject: CO-RE: Weird immediate for bpf_core_field_exists
Date: Thu, 29 Apr 2021 11:29:38 +0100	[thread overview]
Message-ID: <CACAyw99n-cMEtVst7aK-3BfHb99GMEChmRLCvhrjsRpHhPrtvA@mail.gmail.com> (raw)

Hi Andrii and Yonghong,

This is probably a case of me holding it wrong, but I figured I would
share this nonetheless. Given the following C:

struct s {
    int _1;
    char _2;
};

typedef struct s s_t;

union u {
    int *_1;
    char *_2;
};

__section("socket_filter/fields") int fields() {
    struct t {
        union {
            s_t s[10];
        };
        struct {
            union u u;
        };
    } bar;
    return bpf_core_field_exists((&bar)[1]);
}

clang-12 generates the following instructions:

0000000000000000 <fields>:
;     return bpf_core_field_exists((&bar)[1]);
       0:    b7 00 00 00 58 00 00 00    r0 = 88
       1:    95 00 00 00 00 00 00 00    exit

The weird bit is that the immediate for instruction 0 isn't 1 but 88.
Coincidentally sizeof(bar) is also 88 bytes.

$ clang-12 --version
Ubuntu clang version
12.0.0-++20210126113614+510b3d4b3e02-1~exp1~20210126104320.178

I've tried clang-13 as well, same result.

Best,
Lorenz

-- 
Lorenz Bauer  |  Systems Engineer
6th Floor, County Hall/The Riverside Building, SE1 7PB, UK

www.cloudflare.com

             reply	other threads:[~2021-04-29 10:29 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-04-29 10:29 Lorenz Bauer [this message]
2021-04-29 15:31 ` Yonghong Song

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CACAyw99n-cMEtVst7aK-3BfHb99GMEChmRLCvhrjsRpHhPrtvA@mail.gmail.com \
    --to=lmb@cloudflare.com \
    --cc=andrii@kernel.org \
    --cc=bpf@vger.kernel.org \
    --cc=yhs@fb.com \
    --subject='CO-RE: Weird immediate for bpf_core_field_exists' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
on how to clone and mirror all data and code used for this inbox