From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.8 required=3.0 tests=BAYES_00,DKIMWL_WL_MED, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 47AC4C433B4 for ; Mon, 26 Apr 2021 08:10:06 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 0840A610E6 for ; Mon, 26 Apr 2021 08:10:05 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232316AbhDZIKp (ORCPT ); Mon, 26 Apr 2021 04:10:45 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:46254 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232259AbhDZIIt (ORCPT ); Mon, 26 Apr 2021 04:08:49 -0400 Received: from mail-lf1-x131.google.com (mail-lf1-x131.google.com [IPv6:2a00:1450:4864:20::131]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 2FC07C061756 for ; Mon, 26 Apr 2021 01:08:08 -0700 (PDT) Received: by mail-lf1-x131.google.com with SMTP id h36so32760151lfv.7 for ; Mon, 26 Apr 2021 01:08:08 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cloudflare.com; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=5NsG9mqD3X1aAKJzc66v8dsrFLWvkG6sC5U1QqeHF8A=; b=X/P3ycOi6YyAIEma+DpmbuS961EpLUuf66D2tSQtRgpQOSdwIFIoadsn7myNCHrtod SzfFK8FWV9kIIIvDg3aU3fWbQ3gdzAw9dmh5owX6VeM16ko2u2SSibQQZs2q+WCSp2n1 ZXmqUY3S7UiTjlvwXtjUh9IxLJbMti7ZnpTz0= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=5NsG9mqD3X1aAKJzc66v8dsrFLWvkG6sC5U1QqeHF8A=; b=h6pGe/f6SA0qHjLFA3D8W5k/0LzVthVF+1ngPNRRZO8DmYilx2vtuM0tkZuNROTL3k 2AD6bDHk49qzHWlHx6TLYhpecMc47VUY7DDGo/X3BiNOIS5PI2IrwujpQZxvb6YuoCVK 8UDeVK5EPcWWl7VMxu8RjWG1ldnn0TkmhZDc81Azo9zcTIWQzXCi1LDRIxzNXsXPmFKf J7FhCMBhrjZw2HNUDH5aSy0Wik3t3jCTir9/XczNnsjL3tSgsQSuwdbk6ZdYow2liFwu 4d1b1VYWFJs34jEWi7MCHINbdbG++8CyX7eG7Cnl7+P6SSHaavSBPdo4R/DC70lm46Fa hL0g== X-Gm-Message-State: AOAM531dfjuXCFbGO4yzMguC35cGhlPqIrTu3cv5nuoxF9o9hsORmoXi /Sr2SJhkERNWl8az6WMm6cRLkIySQH5X/1BAUWoXCQ== X-Google-Smtp-Source: ABdhPJycPSZBuGHFfbjDvbQyVEsIGAR4uEIbmsfd8KJWJltBxS9hup6Ltdr+bha/XhIIiQ49ersqJ/GopBNBAzoKcJU= X-Received: by 2002:ac2:4d08:: with SMTP id r8mr11629565lfi.97.1619424486692; Mon, 26 Apr 2021 01:08:06 -0700 (PDT) MIME-Version: 1.0 References: <20210423233058.3386115-1-andrii@kernel.org> <20210423233058.3386115-3-andrii@kernel.org> In-Reply-To: <20210423233058.3386115-3-andrii@kernel.org> From: Lorenz Bauer Date: Mon, 26 Apr 2021 09:07:55 +0100 Message-ID: Subject: Re: [PATCH bpf-next 2/5] libbpf: support BTF_KIND_FLOAT during type compatibility checks in CO-RE To: Andrii Nakryiko Cc: bpf , Networking , Alexei Starovoitov , Daniel Borkmann , Kernel Team Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: bpf@vger.kernel.org On Sat, 24 Apr 2021 at 00:36, Andrii Nakryiko wrote: > > Add BTF_KIND_FLOAT support when doing CO-RE field type compatibility check. > Without this, relocations against float/double fields will fail. > > Also adjust one error message to emit instruction index instead of less > convenient instruction byte offset. > > Fixes: 22541a9eeb0d ("libbpf: Add BTF_KIND_FLOAT support") > Signed-off-by: Andrii Nakryiko > --- > tools/lib/bpf/libbpf.c | 5 +++-- > 1 file changed, 3 insertions(+), 2 deletions(-) > > diff --git a/tools/lib/bpf/libbpf.c b/tools/lib/bpf/libbpf.c > index a1cddd17af7d..ff54ffef433a 100644 > --- a/tools/lib/bpf/libbpf.c > +++ b/tools/lib/bpf/libbpf.c > @@ -5141,6 +5141,7 @@ static int bpf_core_fields_are_compat(const struct btf *local_btf, > > switch (btf_kind(local_type)) { > case BTF_KIND_PTR: > + case BTF_KIND_FLOAT: Nit: update the function comment as well? Acked-by: Lorenz Bauer -- Lorenz Bauer | Systems Engineer 6th Floor, County Hall/The Riverside Building, SE1 7PB, UK www.cloudflare.com