From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.9 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C529CC433E1 for ; Tue, 2 Jun 2020 09:06:46 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 9A79B2077D for ; Tue, 2 Jun 2020 09:06:46 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b="M8uuyvAj" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1725811AbgFBJGq (ORCPT ); Tue, 2 Jun 2020 05:06:46 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:37304 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726311AbgFBJGp (ORCPT ); Tue, 2 Jun 2020 05:06:45 -0400 Received: from mail-wr1-x444.google.com (mail-wr1-x444.google.com [IPv6:2a00:1450:4864:20::444]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 8C961C061A0E for ; Tue, 2 Jun 2020 02:06:44 -0700 (PDT) Received: by mail-wr1-x444.google.com with SMTP id x14so2587539wrp.2 for ; Tue, 02 Jun 2020 02:06:44 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=8v86iOfFTv5BgAxyuvboR4oLRtDNPVTIFHSDTXVpBds=; b=M8uuyvAjamNhrQwwq0xYkQclgXmwzuX291UmA2eh4YYt+i6td+xKOzAxr0g38rgSym kGLTujiAzXWc3s6IPpbHo8VP8mIkzajR2qEnrc8HK7oQ/gvHcpVN2VXpVrTPMvJ4m7hF N54TmJSOkDH+pf8ZJogd+pu+4UDVgU1aLG4Yc= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=8v86iOfFTv5BgAxyuvboR4oLRtDNPVTIFHSDTXVpBds=; b=EqIwTqacuBhkCyufplcy3DPp0FAnpTHswlnmpc1HASzQIRlIu3a/m7fys0l0coPHB8 GTTebBmpHAKQB0XNlUeui+hG3pyg2k9fSUw4wn8yKIvKlysH3JXSoxkXWdNItVxRAjNI NSV2GZpx29sA/RfBUbs3nwNsiuoVDF2ujem8X2hjtmMLSfyzBSjxl81nt7UWF9HasX0c 05USl/GjlJP2Nj2TEyXSYWbqCRT73i5t+vjqk+TXwqJIsqp93pzO62YmikM4px+cCIGl PNguaQ4d7QsfsfjpatYe05gVOtSBEO3L1ER6yy4Go6U30sZUjbB7PeBANGMV144muM3P 7VHQ== X-Gm-Message-State: AOAM53386NepLR4UCjuvVavOHpjruq5UJZb0xTOfCWlYIKrbZwnszozS DkK3zbBXqafHGsYqAu5ckuvqEo+/gDDYByUEDhYb9A== X-Google-Smtp-Source: ABdhPJx6Y9xwmLNgoYiiWind01Az3F7mso6mNpKG2xSrW6WTJ19a8Nsjx96OMPLN9lu0VVk+nD+pZPRubtOi3kJyi7U= X-Received: by 2002:adf:f30d:: with SMTP id i13mr23946962wro.146.1591088803135; Tue, 02 Jun 2020 02:06:43 -0700 (PDT) MIME-Version: 1.0 References: <20200531154255.896551-1-jolsa@kernel.org> <20200602081339.GA1112120@krava> In-Reply-To: <20200602081339.GA1112120@krava> From: KP Singh Date: Tue, 2 Jun 2020 11:06:32 +0200 Message-ID: Subject: Re: [PATCH] bpf: Use tracing helpers for lsm programs To: Jiri Olsa Cc: Alexei Starovoitov , Song Liu , Jiri Olsa , Alexei Starovoitov , Daniel Borkmann , KP Singh , Networking , bpf , Yonghong Song , Martin KaFai Lau , Jakub Kicinski , David Miller , John Fastabend , Jesper Dangaard Brouer , Andrii Nakryiko Content-Type: text/plain; charset="UTF-8" Sender: bpf-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: bpf@vger.kernel.org On Tue, Jun 2, 2020 at 10:13 AM Jiri Olsa wrote: > > On Mon, Jun 01, 2020 at 03:12:13PM -0700, Alexei Starovoitov wrote: > > On Mon, Jun 1, 2020 at 12:00 PM Song Liu wrote: > > > > > > On Sun, May 31, 2020 at 8:45 AM Jiri Olsa wrote: > > > > > > > > Currenty lsm uses bpf_tracing_func_proto helpers which do > > > > not include stack trace or perf event output. It's useful > > > > to have those for bpftrace lsm support [1]. > > > > > > > > Using tracing_prog_func_proto helpers for lsm programs. > > > > > > How about using raw_tp_prog_func_proto? > > > > why? > > I think skb/xdp_output is useful for lsm progs too. > > So I've applied the patch. > > right, it's also where d_path will be as well > > > > > > PS: Please tag the patch with subject prefix "PATCH bpf" for > > > "PATCH bpf-next". I think this one belongs to bpf-next, which means > > > we should wait after the merge window. > > I must have missed info about that, > thanks for info Thanks for adding this! LGTM as well. - KP > > > > > +1. > > Jiri, > > pls tag the subject properly. > > will do, sry > > thanks, > jirka >