From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.9 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 41F3EC3F2D7 for ; Thu, 5 Mar 2020 23:22:20 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 1A6B7207FD for ; Thu, 5 Mar 2020 23:22:20 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b="Q0eAh/OF" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726128AbgCEXWT (ORCPT ); Thu, 5 Mar 2020 18:22:19 -0500 Received: from mail-wr1-f67.google.com ([209.85.221.67]:46012 "EHLO mail-wr1-f67.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726275AbgCEXWT (ORCPT ); Thu, 5 Mar 2020 18:22:19 -0500 Received: by mail-wr1-f67.google.com with SMTP id v2so167307wrp.12 for ; Thu, 05 Mar 2020 15:22:17 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=UlJYZnn8gF6EelxRY7x9k7613SCS7XFaITrtE8tR1vQ=; b=Q0eAh/OF99KaSC2bJbBgNXpd2QkbUTjmndCby1sHRDc4RDN9PLzt+IU13Y/EcIRT3X wECALzFKTcmLuaIiGhTxjNKI+t6/1bm4eI9ziAC1ihdUoFAMxA+YaqzyE3zscFC153kG /hOYqdVEr9Qn2KYRL0tkuuHahZW5sWUkMgC34= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=UlJYZnn8gF6EelxRY7x9k7613SCS7XFaITrtE8tR1vQ=; b=Elk0oR4svwsQELDEYLyw5AgbDrFkQ0voVqHijztU2r+raGB8Ive+82oLdWL6X98rmQ 3GCUJCMPGmusM4jrtWQKnAbLYr0PayMZFzApurksdtlDEqzwjge8GuZbHcU5TT9i+TPq B7gFlW2UMJIi4PgOEzHABe26Owiv64gVCBRDjzO0O74GP0iHw/QymDPMi6vziIrdUFiF IQU1kTBrBoZLfESR6HZhHi07wk1IYA0uYI8fDY26bNzFGUSeDQGfubS8UCpc+6f16T3z TwtLmbXvgC05aqHkalEXwBWxcfREW5zLTn6ueKZ6fhWBrilSKqv3Xr1YURpKHJ6+FEJ3 auYg== X-Gm-Message-State: ANhLgQ3ZVM6VPgTAWea8I/44na3k6w4DB5zDMhJa2yuvlDp5FC+exJpp 9Z/nQ0HcUxEuP+d4O/TBumT7pcsMp0HY96eAsbUKUA== X-Google-Smtp-Source: ADFU+vtuvKFZ8s0RSzwglFPDiN/FF9/4W9jJ87Uq/hW3kxlvaebx5BVTUTkvJRxM0Q/UeUYHe8Dj5RI0gNK8ohHJwL8= X-Received: by 2002:adf:ded2:: with SMTP id i18mr271722wrn.173.1583450536966; Thu, 05 Mar 2020 15:22:16 -0800 (PST) MIME-Version: 1.0 References: <20200305220127.29109-1-kpsingh@chromium.org> <92937298-69c1-be6f-3e40-75af1bc72d9e@infradead.org> In-Reply-To: From: KP Singh Date: Fri, 6 Mar 2020 00:22:06 +0100 Message-ID: Subject: Re: [PATCH bpf-next] bpf: Fix bpf_prog_test_run_tracing for !CONFIG_NET To: Alexei Starovoitov Cc: Randy Dunlap , LSM List , Linux-Next Mailing List , bpf , Alexei Starovoitov , Daniel Borkmann , Stephen Rothwell , Florent Revest , Brendan Jackman Content-Type: text/plain; charset="UTF-8" Sender: bpf-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: bpf@vger.kernel.org On Fri, Mar 6, 2020 at 12:16 AM Alexei Starovoitov wrote: > > On Thu, Mar 5, 2020 at 3:12 PM Randy Dunlap wrote: > > > > On 3/5/20 2:01 PM, KP Singh wrote: > > > From: KP Singh > > > > > > test_run.o is not built when CONFIG_NET is not set and > > > bpf_prog_test_run_tracing being referenced in bpf_trace.o causes the > > > linker error: > > > > > > ld: kernel/trace/bpf_trace.o:(.rodata+0x38): undefined reference to > > > `bpf_prog_test_run_tracing' > > > > > > Add a __weak function in bpf_trace.c to handle this. > > > > > > Fixes: da00d2f117a0 ("bpf: Add test ops for BPF_PROG_TYPE_TRACING") > > > Signed-off-by: KP Singh > > > > Reported-by: Randy Dunlap Thanks! Apologies, I should have added the "Reported-by:" tag. - KP > > Acked-by: Randy Dunlap # build-tested > > Since it was at the top of the tree I amended the commit > with your tags. > Thanks for reporting and testing.