From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-11.0 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,INCLUDES_CR_TRAILER,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 05ED7C433ED for ; Mon, 19 Apr 2021 22:47:17 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id C8D5861168 for ; Mon, 19 Apr 2021 22:47:16 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229936AbhDSWrp (ORCPT ); Mon, 19 Apr 2021 18:47:45 -0400 Received: from mail.kernel.org ([198.145.29.99]:54938 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229718AbhDSWro (ORCPT ); Mon, 19 Apr 2021 18:47:44 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id F2A1A613AA for ; Mon, 19 Apr 2021 22:47:12 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1618872433; bh=+yGM8k3N1hvfgbB3yripFKTduuYlrssXdmGk19osRPI=; h=References:In-Reply-To:From:Date:Subject:To:Cc:From; b=YEJkR0fK6u9xLa7OA+SCjjQWeTPRqG7jDkMqZnVRDYRq8eBvOfupr2wtLWbQktJZI 4btIs3Cg+LyoweGOjrOFtQ4bMF2deRYGGkDUb7pJsxPfdHNfgAvLxQcvae4pGDfuyc dMXRlW2CsA50RtQA8aVk6k0Wc2BSUxg5k4MaocKkICWez6c7GuI6qq3IjrTzc6yPmx mmQD3UHaSdyRJwXKuLMaBx+ris/zuwERgToPql+bnzq+z+L9PzHhGqzXxasJK1mBg+ Y6WzoCiFcYieDlxmEIzDMeHKBJ3IdmuwlsYpvHG6Um4kn95MbNmaMf4avLC6ILF1/t hE0wddmLr29bQ== Received: by mail-lj1-f169.google.com with SMTP id a5so4285837ljk.0 for ; Mon, 19 Apr 2021 15:47:12 -0700 (PDT) X-Gm-Message-State: AOAM531FFbNjYCo8trlGoIKvjEivrkzvHK5tUdgtp9kDieW+B0PTRV7x tz8QgGKVrYZGcwK5umChkMFi3fs370pilIDc7Pf4cw== X-Google-Smtp-Source: ABdhPJypBmFQJq4PLzpKb0UDiaqSFGE/v6VhrBiEwAwvXdSUSQ4riFJm9UydkC3BES/9hm6gidEPC1dMOkUrNddbWTY= X-Received: by 2002:a05:651c:387:: with SMTP id e7mr13082013ljp.425.1618872431155; Mon, 19 Apr 2021 15:47:11 -0700 (PDT) MIME-Version: 1.0 References: <20210414195147.1624932-1-jolsa@kernel.org> <20210414195147.1624932-2-jolsa@kernel.org> In-Reply-To: From: KP Singh Date: Tue, 20 Apr 2021 00:47:00 +0200 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCHv5 bpf-next 1/7] bpf: Allow trampoline re-attach for tracing and lsm programs To: Andrii Nakryiko Cc: Jiri Olsa , Alexei Starovoitov , Daniel Borkmann , Andrii Nakryiko , kernel test robot , Julia Lawall , =?UTF-8?B?VG9rZSBIw7hpbGFuZC1Kw7hyZ2Vuc2Vu?= , Networking , bpf , Martin KaFai Lau , Song Liu , Yonghong Song , John Fastabend , Julia Lawall Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: bpf@vger.kernel.org On Fri, Apr 16, 2021 at 1:22 AM Andrii Nakryiko wrote: > > On Wed, Apr 14, 2021 at 5:44 PM Jiri Olsa wrote: > > > > Currently we don't allow re-attaching of trampolines. Once > > it's detached, it can't be re-attach even when the program > > is still loaded. > > > > Adding the possibility to re-attach the loaded tracing and > > lsm programs. > > > > Fixing missing unlock with proper cleanup goto jump reported > > by Julia. > > > > Reported-by: kernel test robot > > Reported-by: Julia Lawall > > Acked-by: Toke H=C3=B8iland-J=C3=B8rgensen > > Signed-off-by: Jiri Olsa > > --- > > Acked-by: Andrii Nakryiko Thanks! Acked-by: KP Singh