From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-18.3 required=3.0 tests=BAYES_00,DKIMWL_WL_MED, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, USER_IN_DEF_DKIM_WL autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 61F9AC432BE for ; Wed, 25 Aug 2021 01:32:47 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 42DF161214 for ; Wed, 25 Aug 2021 01:32:47 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234233AbhHYBd3 (ORCPT ); Tue, 24 Aug 2021 21:33:29 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:60670 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229962AbhHYBd3 (ORCPT ); Tue, 24 Aug 2021 21:33:29 -0400 Received: from mail-yb1-xb2d.google.com (mail-yb1-xb2d.google.com [IPv6:2607:f8b0:4864:20::b2d]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 84FC3C061764 for ; Tue, 24 Aug 2021 18:32:44 -0700 (PDT) Received: by mail-yb1-xb2d.google.com with SMTP id z5so44771425ybj.2 for ; Tue, 24 Aug 2021 18:32:44 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=DooZUfswKHzF8AU/S6qWSrN/bFFsgcna1SIFXjsJJEg=; b=uxyyEw0fUbMCkvNC3wec542H+lvX3swlTIQLLENJRbUpRjJqitEJBG/KFXQ9/xNbwu 7Nn2gE9Lgnz6p3FP7gPSv0tIOOXuStwN3sTyC4sUXs34Fuq8Pc0QIddlAb5H8xzZ0aaa /OLm4zo9uBkJPHP54bECeCT2cfGR+RYsTTVveEY/3148FI1Tf+CiSPnjI+Q5ERYvbhs+ N5BDekNpuE5pgoOXZK9e4D0WW90OBnphi/9G6kazl5MhAWnlGABC3YC95313DfjW8utP Bv3BsiBSjw4TzPxqD8PUGXmeq25Ya0sjR4j6+39w1SXQNsc0HbStDyfhc6UB5GkUkJsn /NXA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=DooZUfswKHzF8AU/S6qWSrN/bFFsgcna1SIFXjsJJEg=; b=CeSmEIoeHqBy9vDvSBxWi3+gylIfJnfWIgURH0S6WLYoWSS1JhRdrFf07f4dovMSHy KfBWkAE2cET/Wn2/0rlYxybtoO3DMzo2LW+1+5g2GzOucbO4XKwLad25pwQpjGJcDn52 dkRwrhn5fCl4chgCUfDqrSdfYWXPx0xY3quVzngLHXOppdY/aCCwNMGXEFSqq//Qb8Tk FifJoOzKViJZeNnHc+poTUvTubRHKNcX5BJn3m6o2HJQhzalEAAhHCw7yPBWCKQ5zpxq xzunebyJrTPt3kHagM3E8+1itQQMeTcpmJea2YNyKp2wdWtrWo4AnESiakC5wwhQeGgI tidA== X-Gm-Message-State: AOAM533veVcYVMTRDsQmkM8A5tTr6PEimNyNcaYg9BVUkOxZKxFOp1oB KvaTpIKq9nXyaYGccsw3wSt4eZSkRSn9PYrgNRjeDvuZIbrEATkW X-Google-Smtp-Source: ABdhPJw722xmr0qeMiaTP8R7yUGL7dZJ8a2XkTfEXvtNFzqy3/yP084uoAmTuR2Fmtarb48DK50uipQoUFJh1ZI5J5k= X-Received: by 2002:a25:2286:: with SMTP id i128mr17939984ybi.172.1629855163549; Tue, 24 Aug 2021 18:32:43 -0700 (PDT) MIME-Version: 1.0 References: <20210823030143.29937-1-po-hsu.lin@canonical.com> In-Reply-To: <20210823030143.29937-1-po-hsu.lin@canonical.com> From: Dylan Hatch Date: Tue, 24 Aug 2021 18:32:32 -0700 Message-ID: Subject: Re: [PATCH] selftests/bpf: Use kselftest skip code for skipped tests To: Po-Hsu Lin Cc: linux-kernel@vger.kernel.org, bpf@vger.kernel.org, netdev@vger.kernel.org, linux-kselftest@vger.kernel.org, hawk@kernel.org, kuba@kernel.org, davem@davemloft.net, kpsingh@kernel.org, john.fastabend@gmail.com, yhs@fb.com, songliubraving@fb.com, kafai@fb.com, andrii@kernel.org, daniel@iogearbox.net, ast@kernel.org, skhan@linuxfoundation.org Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: bpf@vger.kernel.org On Sun, Aug 22, 2021 at 8:12 PM Po-Hsu Lin wrote: > > There are several test cases in the bpf directory are still using > exit 0 when they need to be skipped. Use kselftest framework skip > code instead so it can help us to distinguish the return status. > > Criterion to filter out what should be fixed in bpf directory: > grep -r "exit 0" -B1 | grep -i skip > > This change might cause some false-positives if people are running > these test scripts directly and only checking their return codes, > which will change from 0 to 4. However I think the impact should be > small as most of our scripts here are already using this skip code. > And there will be no such issue if running them with the kselftest > framework. > > Signed-off-by: Po-Hsu Lin Reviewed-By: Dylan Hatch