From: Joe Stringer <joe@isovalent.com>
To: Bagas Sanjaya <bagasdotme@gmail.com>
Cc: bpf@vger.kernel.org, linux-doc@vger.kernel.org,
linux-kernel@vger.kernel.org, ast@kernel.org, corbet@lwn.net,
martin.lau@linux.dev, maxtram95@gmail.com
Subject: Re: [PATCH bpf-next v3] docs/bpf: Add LRU internals description and graph
Date: Mon, 13 Mar 2023 12:18:12 -0700 [thread overview]
Message-ID: <CADa=Ryyp10=ki5ctVTVbeUFy23uyRbi+ZgJE5JpxX3UFWvQcyw@mail.gmail.com> (raw)
In-Reply-To: <ZA6ecdQl3STWVAH6@debian.me>
On Sun, Mar 12, 2023 at 8:54 PM Bagas Sanjaya <bagasdotme@gmail.com> wrote:
>
> On Sun, Mar 12, 2023 at 12:05:59PM -0700, Joe Stringer wrote:
> > +Even if an LRU node may be acquired, maps of type ``BPF_MAP_TYPE_LRU_HASH``
> > +may fail to insert the entry into the map if other CPUs are heavily contending
> > +on the global hashmap lock.
>
> "Even if an LRU node can be acquired, ..."
Ack.
> > +
> > +This algorithm is described visually in the following diagram. See the
> > +description in commit 3a08c2fd7634 ("bpf: LRU List") for a full explanation of
> > +the corresponding operations:
> > +
> > +.. kernel-figure:: map_lru_hash_update.dot
> > + :alt: Diagram outlining the LRU eviction steps taken during map update
> > +
> > + LRU hash eviction during map update for ``BPF_MAP_TYPE_LRU_HASH`` and
> > + variants
> > +
> > <snipped> ...
> > +The dot file source for the above figure uses internal kernel function names
> > +for the node names in order to make the corresponding logic easier to find.
>
> Shouldn't the figure note above be in :alt:?
Do you mean alt or caption? Alt will hide the information from most developers.
> Otherwise LGTM.
Thanks for the review!
next prev parent reply other threads:[~2023-03-13 19:19 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-12 19:05 [PATCH bpf-next v3] docs/bpf: Add LRU internals description and graph Joe Stringer
2023-03-13 3:54 ` Bagas Sanjaya
2023-03-13 19:18 ` Joe Stringer [this message]
2023-03-14 5:21 ` John Fastabend
2023-03-16 1:19 ` Joe Stringer
2023-03-14 13:55 ` Maxim Mikityanskiy
2023-03-16 1:22 ` Joe Stringer
2023-03-14 19:31 ` Martin KaFai Lau
2023-03-16 1:54 ` Joe Stringer
2023-03-17 6:04 ` Martin KaFai Lau
2023-04-01 18:57 ` Joe Stringer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CADa=Ryyp10=ki5ctVTVbeUFy23uyRbi+ZgJE5JpxX3UFWvQcyw@mail.gmail.com' \
--to=joe@isovalent.com \
--cc=ast@kernel.org \
--cc=bagasdotme@gmail.com \
--cc=bpf@vger.kernel.org \
--cc=corbet@lwn.net \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=martin.lau@linux.dev \
--cc=maxtram95@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).