bpf.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Andrii Nakryiko <andrii.nakryiko@gmail.com>
To: Ilya Leoshkevich <iii@linux.ibm.com>
Cc: Alexei Starovoitov <ast@kernel.org>,
	Daniel Borkmann <daniel@iogearbox.net>, bpf <bpf@vger.kernel.org>,
	Heiko Carstens <heiko.carstens@de.ibm.com>,
	Vasily Gorbik <gor@linux.ibm.com>
Subject: Re: [PATCH bpf-next] selftests/bpf: Fix endianness issues in atomic tests
Date: Wed, 10 Feb 2021 12:28:21 -0800	[thread overview]
Message-ID: <CAEf4BzY2xgxU11bKBo-UazPDaC_zZ4=dgLUhQc5AKabwEAGdRw@mail.gmail.com> (raw)
In-Reply-To: <20210210020713.77911-1-iii@linux.ibm.com>

On Tue, Feb 9, 2021 at 6:11 PM Ilya Leoshkevich <iii@linux.ibm.com> wrote:
>
> Atomic tests store a DW, but then load it back as a W from the same
> address. This doesn't work on big-endian systems, and since the point
> of those tests is not testing narrow loads, fix simply by loading a
> DW.
>
> Signed-off-by: Ilya Leoshkevich <iii@linux.ibm.com>
> Fixes: 98d666d05a1d ("bpf: Add tests for new BPF atomic operations")
> ---

Applied to bpf-next.

>  tools/testing/selftests/bpf/verifier/atomic_and.c | 2 +-
>  tools/testing/selftests/bpf/verifier/atomic_or.c  | 2 +-
>  tools/testing/selftests/bpf/verifier/atomic_xor.c | 2 +-
>  3 files changed, 3 insertions(+), 3 deletions(-)
>

      parent reply	other threads:[~2021-02-10 20:29 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-02-10  2:07 [PATCH bpf-next] selftests/bpf: Fix endianness issues in atomic tests Ilya Leoshkevich
2021-02-10 20:20 ` patchwork-bot+netdevbpf
2021-02-10 20:28 ` Andrii Nakryiko [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAEf4BzY2xgxU11bKBo-UazPDaC_zZ4=dgLUhQc5AKabwEAGdRw@mail.gmail.com' \
    --to=andrii.nakryiko@gmail.com \
    --cc=ast@kernel.org \
    --cc=bpf@vger.kernel.org \
    --cc=daniel@iogearbox.net \
    --cc=gor@linux.ibm.com \
    --cc=heiko.carstens@de.ibm.com \
    --cc=iii@linux.ibm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).