BPF Archive on lore.kernel.org
 help / color / Atom feed
From: Andrii Nakryiko <andrii.nakryiko@gmail.com>
To: Alexei Starovoitov <alexei.starovoitov@gmail.com>
Cc: "David S. Miller" <davem@davemloft.net>,
	Daniel Borkmann <daniel@iogearbox.net>,
	"Paul E . McKenney" <paulmck@kernel.org>,
	Networking <netdev@vger.kernel.org>, bpf <bpf@vger.kernel.org>,
	Kernel Team <kernel-team@fb.com>
Subject: Re: [PATCH v5 bpf-next 0/5] bpf: Introduce minimal support for sleepable progs
Date: Mon, 29 Jun 2020 22:14:18 -0700
Message-ID: <CAEf4BzYG2drMiUvjgAF5vgdjAo5+N3zL+5TTvCoUUK=Z3ErVwA@mail.gmail.com> (raw)
In-Reply-To: <20200630043343.53195-1-alexei.starovoitov@gmail.com>

On Mon, Jun 29, 2020 at 9:34 PM Alexei Starovoitov
<alexei.starovoitov@gmail.com> wrote:
>
> From: Alexei Starovoitov <ast@kernel.org>
>
> v4->v5:
> - addressed Andrii's feedback.
>
> v3->v4:
> - fixed synchronize_rcu_tasks_trace() usage and accelerated with synchronize_rcu_mult().
> - removed redundant synchronize_rcu(). Otherwise it won't be clear why
>   synchronize_rcu_tasks_trace() is not needed in free_map callbacks.
> - improved test coverage.
>
> v2->v3:
> - switched to rcu_trace
> - added bpf_copy_from_user
>
> Here is 'perf report' differences:
> sleepable with SRCU:
>    3.86%  bench     [k] __srcu_read_unlock
>    3.22%  bench     [k] __srcu_read_lock
>    0.92%  bench     [k] bpf_prog_740d4210cdcd99a3_bench_trigger_fentry_sleep
>    0.50%  bench     [k] bpf_trampoline_10297
>    0.26%  bench     [k] __bpf_prog_exit_sleepable
>    0.21%  bench     [k] __bpf_prog_enter_sleepable
>
> sleepable with RCU_TRACE:
>    0.79%  bench     [k] bpf_prog_740d4210cdcd99a3_bench_trigger_fentry_sleep
>    0.72%  bench     [k] bpf_trampoline_10381
>    0.31%  bench     [k] __bpf_prog_exit_sleepable
>    0.29%  bench     [k] __bpf_prog_enter_sleepable
>
> non-sleepable with RCU:
>    0.88%  bench     [k] bpf_prog_740d4210cdcd99a3_bench_trigger_fentry
>    0.84%  bench     [k] bpf_trampoline_10297
>    0.13%  bench     [k] __bpf_prog_enter
>    0.12%  bench     [k] __bpf_prog_exit
>
> Happy to confirm that rcu_trace overhead is negligible.
>
> v1->v2:
> - split fmod_ret fix into separate patch
> - added blacklist
>
> v1:
> This patch set introduces the minimal viable support for sleepable bpf programs.
> In this patch only fentry/fexit/fmod_ret and lsm progs can be sleepable.
> Only array and pre-allocated hash and lru maps allowed.
>
> Alexei Starovoitov (5):
>   bpf: Remove redundant synchronize_rcu.
>   bpf: Introduce sleepable BPF programs
>   bpf: Add bpf_copy_from_user() helper.
>   libbpf: support sleepable progs
>   selftests/bpf: Add sleepable tests
>
>  arch/x86/net/bpf_jit_comp.c                   | 32 +++++----
>  include/linux/bpf.h                           |  4 ++
>  include/uapi/linux/bpf.h                      | 19 +++++-
>  init/Kconfig                                  |  1 +
>  kernel/bpf/arraymap.c                         | 10 +--
>  kernel/bpf/hashtab.c                          | 20 +++---
>  kernel/bpf/helpers.c                          | 22 +++++++
>  kernel/bpf/lpm_trie.c                         |  5 --
>  kernel/bpf/queue_stack_maps.c                 |  7 --
>  kernel/bpf/reuseport_array.c                  |  2 -
>  kernel/bpf/ringbuf.c                          |  7 --
>  kernel/bpf/stackmap.c                         |  3 -
>  kernel/bpf/syscall.c                          | 13 +++-
>  kernel/bpf/trampoline.c                       | 28 +++++++-
>  kernel/bpf/verifier.c                         | 62 ++++++++++++++++-
>  kernel/trace/bpf_trace.c                      |  2 +
>  tools/include/uapi/linux/bpf.h                | 19 +++++-
>  tools/lib/bpf/libbpf.c                        | 25 ++++++-
>  tools/testing/selftests/bpf/bench.c           |  2 +
>  .../selftests/bpf/benchs/bench_trigger.c      | 17 +++++
>  .../selftests/bpf/prog_tests/test_lsm.c       |  9 +++
>  tools/testing/selftests/bpf/progs/lsm.c       | 66 ++++++++++++++++++-
>  .../selftests/bpf/progs/trigger_bench.c       |  7 ++
>  23 files changed, 315 insertions(+), 67 deletions(-)
>
> --
> 2.23.0
>

For the series:

Acked-by: Andrii Nakryiko <andriin@fb.com>

      parent reply index

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-06-30  4:33 Alexei Starovoitov
2020-06-30  4:33 ` [PATCH v5 bpf-next 1/5] bpf: Remove redundant synchronize_rcu Alexei Starovoitov
2020-06-30 20:55   ` Paul E. McKenney
2020-06-30  4:33 ` [PATCH v5 bpf-next 2/5] bpf: Introduce sleepable BPF programs Alexei Starovoitov
2020-06-30 22:04   ` Paul E. McKenney
2020-06-30 23:26   ` Daniel Borkmann
2020-06-30 23:41     ` Alexei Starovoitov
2020-07-01  9:15       ` KP Singh
2020-07-01  9:34         ` Daniel Borkmann
2020-07-01 15:21           ` Alexei Starovoitov
2020-07-10 17:00             ` Arnaldo Carvalho de Melo
2020-07-10 22:59               ` Alexei Starovoitov
2020-07-01  9:17       ` Daniel Borkmann
2020-07-01 15:14         ` Alexei Starovoitov
2020-07-01 19:03           ` KP Singh
2020-06-30  4:33 ` [PATCH v5 bpf-next 3/5] bpf: Add bpf_copy_from_user() helper Alexei Starovoitov
2020-06-30 11:41   ` KP Singh
2020-06-30  4:33 ` [PATCH v5 bpf-next 4/5] libbpf: support sleepable progs Alexei Starovoitov
2020-06-30  4:33 ` [PATCH v5 bpf-next 5/5] selftests/bpf: Add sleepable tests Alexei Starovoitov
2020-06-30  5:14 ` Andrii Nakryiko [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAEf4BzYG2drMiUvjgAF5vgdjAo5+N3zL+5TTvCoUUK=Z3ErVwA@mail.gmail.com' \
    --to=andrii.nakryiko@gmail.com \
    --cc=alexei.starovoitov@gmail.com \
    --cc=bpf@vger.kernel.org \
    --cc=daniel@iogearbox.net \
    --cc=davem@davemloft.net \
    --cc=kernel-team@fb.com \
    --cc=netdev@vger.kernel.org \
    --cc=paulmck@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

BPF Archive on lore.kernel.org

Archives are clonable:
	git clone --mirror https://lore.kernel.org/bpf/0 bpf/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 bpf bpf/ https://lore.kernel.org/bpf \
		bpf@vger.kernel.org
	public-inbox-index bpf

Example config snippet for mirrors

Newsgroup available over NNTP:
	nntp://nntp.lore.kernel.org/org.kernel.vger.bpf


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git