From: Andrii Nakryiko <andrii.nakryiko@gmail.com>
To: Jiri Olsa <jolsa@kernel.org>
Cc: Arnaldo Carvalho de Melo <acme@kernel.org>,
Hao Luo <haoluo@google.com>,
dwarves@vger.kernel.org, bpf <bpf@vger.kernel.org>,
Alexei Starovoitov <ast@kernel.org>,
Andrii Nakryiko <andriin@fb.com>, Yonghong Song <yhs@fb.com>,
"Frank Ch. Eigler" <fche@redhat.com>,
Mark Wielaard <mjw@redhat.com>
Subject: Re: [PATCH 2/3] btf_encoder: Move find_all_percpu_vars in generic collect_symbols
Date: Thu, 5 Nov 2020 11:34:08 -0800 [thread overview]
Message-ID: <CAEf4BzYJd5ib3WOO_gp+vs7VQtuSAOC8+QTah_S+=kN=PMpyjg@mail.gmail.com> (raw)
In-Reply-To: <20201104215923.4000229-3-jolsa@kernel.org>
On Wed, Nov 4, 2020 at 2:02 PM Jiri Olsa <jolsa@kernel.org> wrote:
>
> Moving find_all_percpu_vars under generic collect_symbols
> function that walks over symbols and calls collect_percpu_var.
>
> We will add another collect function that needs to go through
> all the symbols, so it's better we go through them just once.
>
> There's no functional change intended.
>
> Acked-by: Hao Luo <haoluo@google.com>
> Signed-off-by: Jiri Olsa <jolsa@kernel.org>
> ---
diff tool didn't do a great job here :( but code seems fine to me, so:
Acked-by: Andrii Nakryiko <andrii@kernel.org>
> btf_encoder.c | 124 +++++++++++++++++++++++++++-----------------------
> 1 file changed, 67 insertions(+), 57 deletions(-)
>
[...]
next prev parent reply other threads:[~2020-11-05 19:34 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-04 21:59 [PATCHv3 0/3] pahole/kernel: Workaround dwarf bug for function encoding Jiri Olsa
2020-11-04 21:59 ` [PATCH 1/3] bpf: Move iterator functions into special init section Jiri Olsa
2020-11-05 1:01 ` Song Liu
2020-11-04 21:59 ` [PATCH 2/3] btf_encoder: Move find_all_percpu_vars in generic collect_symbols Jiri Olsa
2020-11-05 19:34 ` Andrii Nakryiko [this message]
2020-11-04 21:59 ` [PATCH 3/3] btf_encoder: Change functions check due to broken dwarf Jiri Olsa
2020-11-05 19:52 ` Andrii Nakryiko
2020-11-05 22:56 ` Jiri Olsa
2020-11-06 22:25 [PATCHv4 0/3] pahole/kernel: Workaround dwarf bug for function encoding Jiri Olsa
2020-11-06 22:25 ` [PATCH 2/3] btf_encoder: Move find_all_percpu_vars in generic collect_symbols Jiri Olsa
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAEf4BzYJd5ib3WOO_gp+vs7VQtuSAOC8+QTah_S+=kN=PMpyjg@mail.gmail.com' \
--to=andrii.nakryiko@gmail.com \
--cc=acme@kernel.org \
--cc=andriin@fb.com \
--cc=ast@kernel.org \
--cc=bpf@vger.kernel.org \
--cc=dwarves@vger.kernel.org \
--cc=fche@redhat.com \
--cc=haoluo@google.com \
--cc=jolsa@kernel.org \
--cc=mjw@redhat.com \
--cc=yhs@fb.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).