From: Andrii Nakryiko <andrii.nakryiko@gmail.com>
To: Hangbin Liu <liuhangbin@gmail.com>
Cc: bpf <bpf@vger.kernel.org>, Networking <netdev@vger.kernel.org>,
"Toke Høiland-Jørgensen" <toke@redhat.com>,
"Jiri Benc" <jbenc@redhat.com>,
"Jesper Dangaard Brouer" <brouer@redhat.com>,
"Daniel Borkmann" <daniel@iogearbox.net>,
"Alexei Starovoitov" <ast@kernel.org>,
"Stephen Hemminger" <stephen@networkplumber.org>,
"Song Liu" <songliubraving@fb.com>, "Yonghong Song" <yhs@fb.com>
Subject: Re: [PATCH bpf-next] libbpf: export bpf_object__reuse_map() to libbpf api
Date: Mon, 28 Sep 2020 20:30:42 -0700 [thread overview]
Message-ID: <CAEf4BzYKtPgSxKqduax1mW1WfVXKuCEpbGKRFvXv7yNUmUm_=A@mail.gmail.com> (raw)
In-Reply-To: <20200929031845.751054-1-liuhangbin@gmail.com>
On Mon, Sep 28, 2020 at 8:20 PM Hangbin Liu <liuhangbin@gmail.com> wrote:
>
> Besides bpf_map__reuse_fd(), which could let us reuse existing map fd.
> bpf_object__reuse_map() could let us reuse existing pinned maps, which
> is helpful.
>
> This functions could also be used when we add iproute2 libbpf support,
> so we don't need to re-use or re-implement new functions like
> bpf_obj_get()/bpf_map_selfcheck_pinned() in iproute2.
>
> Signed-off-by: Hangbin Liu <liuhangbin@gmail.com>
> ---
> tools/lib/bpf/libbpf.c | 3 +--
> tools/lib/bpf/libbpf.h | 1 +
> 2 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/tools/lib/bpf/libbpf.c b/tools/lib/bpf/libbpf.c
> index 32dc444224d8..e835d7a3437f 100644
> --- a/tools/lib/bpf/libbpf.c
> +++ b/tools/lib/bpf/libbpf.c
> @@ -4033,8 +4033,7 @@ static bool map_is_reuse_compat(const struct bpf_map *map, int map_fd)
> map_info.map_flags == map->def.map_flags);
> }
>
> -static int
> -bpf_object__reuse_map(struct bpf_map *map)
> +int bpf_object__reuse_map(struct bpf_map *map)
> {
> char *cp, errmsg[STRERR_BUFSIZE];
> int err, pin_fd;
> diff --git a/tools/lib/bpf/libbpf.h b/tools/lib/bpf/libbpf.h
> index a750f67a23f6..4b9e615eb393 100644
> --- a/tools/lib/bpf/libbpf.h
> +++ b/tools/lib/bpf/libbpf.h
> @@ -431,6 +431,7 @@ bpf_map__prev(const struct bpf_map *map, const struct bpf_object *obj);
> /* get/set map FD */
> LIBBPF_API int bpf_map__fd(const struct bpf_map *map);
> LIBBPF_API int bpf_map__reuse_fd(struct bpf_map *map, int fd);
> +LIBBPF_API int bpf_object__reuse_map(struct bpf_map *map);
It's internal function, which doesn't check that map->pin_path is set,
for one thing. It shouldn't be exposed. libbpf exposes
bpf_map__set_pin_path() to set pin_path for any map, and then during
load time libbpf with "reuse map", if pin_path is not NULL. Doesn't
that work for you?
> /* get map definition */
> LIBBPF_API const struct bpf_map_def *bpf_map__def(const struct bpf_map *map);
> /* get map name */
> --
> 2.25.4
>
next prev parent reply other threads:[~2020-09-29 3:30 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-29 3:18 [PATCH bpf-next] libbpf: export bpf_object__reuse_map() to libbpf api Hangbin Liu
2020-09-29 3:30 ` Andrii Nakryiko [this message]
2020-09-29 9:42 ` Hangbin Liu
2020-09-29 23:03 ` Andrii Nakryiko
2020-09-30 2:34 ` Hangbin Liu
2020-09-30 18:30 ` Andrii Nakryiko
2020-10-01 11:34 ` Hangbin Liu
2020-10-01 18:17 ` Andrii Nakryiko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAEf4BzYKtPgSxKqduax1mW1WfVXKuCEpbGKRFvXv7yNUmUm_=A@mail.gmail.com' \
--to=andrii.nakryiko@gmail.com \
--cc=ast@kernel.org \
--cc=bpf@vger.kernel.org \
--cc=brouer@redhat.com \
--cc=daniel@iogearbox.net \
--cc=jbenc@redhat.com \
--cc=liuhangbin@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=songliubraving@fb.com \
--cc=stephen@networkplumber.org \
--cc=toke@redhat.com \
--cc=yhs@fb.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).