From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.6 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B85B6C32771 for ; Mon, 20 Jan 2020 21:00:32 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 898E422522 for ; Mon, 20 Jan 2020 21:00:32 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="NBc2Q5ad" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726816AbgATVA1 (ORCPT ); Mon, 20 Jan 2020 16:00:27 -0500 Received: from mail-qt1-f193.google.com ([209.85.160.193]:44424 "EHLO mail-qt1-f193.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726586AbgATVA0 (ORCPT ); Mon, 20 Jan 2020 16:00:26 -0500 Received: by mail-qt1-f193.google.com with SMTP id w8so871577qts.11; Mon, 20 Jan 2020 13:00:26 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc:content-transfer-encoding; bh=VQ+GdhZxzN9nLfpgX9IxRVtlqBky78upQxgIvlUTRO0=; b=NBc2Q5ad06i24N8mOKCL845ZVy+ujPfi9RBGUNzQtEEFG4/8bmSi/donUXXwJ1N71Y LSDgtkx9hwumwnpljKgb+ryOssu7jsEhbyzZ8dxOSIGX8OiMU0alsdMwwwbbaRGeB1PT ZlfiaNNOWttrRlCCxv/CjE0xSWiXc1l7pN4MUasYxr9lxApRSX55uhFau6n6HCjLUj0u w+feAqSwILqzzIbBe8zBU7cFT7oJMg646KFtVfkiVp3v7cSpoWI3KY35FZ4/bwWlOrGF u3TBLRFw0Xx56HWxcvQuJcWGYkH6TCy73cgjT1Q694EzAciA+c6SVPAgahCtVU2PXSSU 45fg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=VQ+GdhZxzN9nLfpgX9IxRVtlqBky78upQxgIvlUTRO0=; b=hG9pzMKuq5WZUjZOcX3WF4ytlizSzyZXHH66ABHyrZ/O5UfP2D1/1vYia72RXsbpIO fsc01Xei1QtdCzCzS0JrNSOArqSkWiFgcBNfZjd7g1uS8/UJ+ue0RQB5H0sthfq7jc4A mSARnQ07mlMovK8+0RXSADs/EDoqI8vmKnSHx3sqQMDC3KKdxnLAT7MWIoCLIHEGJqNT P1S8cup7weIhoDDtBwrTQHm05Mt1s1uWI7hNp9o3fYNsTT25+ptKRyoZj8dbJMZPZGfX /ZYACqoYuE4aQ2yBaaKPF7CSBFFJL6A52bF83fxrDoT04UdQYHGn0UNVbTwVYqRay0Od Sktg== X-Gm-Message-State: APjAAAVre1+dyo6tKIkVkf88TJ1+xl9M9adaCIT4k4/9ZZNzMPYTzNTc b8AS4osokOoJgRBdTe4pr3QIHuNM0IyICWgK640= X-Google-Smtp-Source: APXvYqwEPU4xurzWUVBVkjOCNXZiOSX0Z04FaiBCkpyvjBsziwOuEFBAX0ydhhSkW4AJoK7PvMHYKvVMg4OLoukxoR4= X-Received: by 2002:ac8:1385:: with SMTP id h5mr1257133qtj.59.1579554025526; Mon, 20 Jan 2020 13:00:25 -0800 (PST) MIME-Version: 1.0 References: <157926819690.1555735.10756593211671752826.stgit@toke.dk> <157926820131.1555735.1177228853838027248.stgit@toke.dk> <875zh6p9pg.fsf@toke.dk> In-Reply-To: From: Andrii Nakryiko Date: Mon, 20 Jan 2020 13:00:14 -0800 Message-ID: Subject: Re: [PATCH bpf-next v4 04/10] tools/runqslower: Use consistent include paths for libbpf To: =?UTF-8?B?VG9rZSBIw7hpbGFuZC1Kw7hyZ2Vuc2Vu?= Cc: Alexei Starovoitov , Daniel Borkmann , Martin KaFai Lau , Song Liu , Yonghong Song , Andrii Nakryiko , Doug Ledford , Jason Gunthorpe , "David S. Miller" , Jakub Kicinski , Jesper Dangaard Brouer , John Fastabend , Peter Zijlstra , Ingo Molnar , Arnaldo Carvalho de Melo , Mark Rutland , Alexander Shishkin , Jiri Olsa , Namhyung Kim , Shuah Khan , Networking , bpf , open list , linux-rdma@vger.kernel.org, "open list:KERNEL SELFTEST FRAMEWORK" , clang-built-linux@googlegroups.com Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Sender: bpf-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: bpf@vger.kernel.org On Mon, Jan 20, 2020 at 10:35 AM Andrii Nakryiko wrote: > > On Mon, Jan 20, 2020 at 4:57 AM Toke H=C3=B8iland-J=C3=B8rgensen wrote: > > > > Andrii Nakryiko writes: > > > > > On Fri, Jan 17, 2020 at 5:37 AM Toke H=C3=B8iland-J=C3=B8rgensen wrote: > > >> > > >> From: Toke H=C3=B8iland-J=C3=B8rgensen > > >> > > >> Fix the runqslower tool to include libbpf header files with the bpf/ > > >> prefix, to be consistent with external users of the library. Also en= sure > > >> that all includes of exported libbpf header files (those that are ex= ported > > >> on 'make install' of the library) use bracketed includes instead of = quoted. > > >> > > >> To not break the build, keep the old include path until everything h= as been > > >> changed to the new one; a subsequent patch will remove that. > > >> > > >> Fixes: 6910d7d3867a ("selftests/bpf: Ensure bpf_helper_defs.h are ta= ken from selftests dir") > > >> Acked-by: Andrii Nakryiko > > >> Signed-off-by: Toke H=C3=B8iland-J=C3=B8rgensen > > >> --- > > >> tools/bpf/runqslower/Makefile | 5 +++-- > > >> tools/bpf/runqslower/runqslower.bpf.c | 2 +- > > >> tools/bpf/runqslower/runqslower.c | 4 ++-- > > >> 3 files changed, 6 insertions(+), 5 deletions(-) > > >> > > >> diff --git a/tools/bpf/runqslower/Makefile b/tools/bpf/runqslower/Ma= kefile > > >> index b62fc9646c39..9f022f7f2593 100644 > > >> --- a/tools/bpf/runqslower/Makefile > > >> +++ b/tools/bpf/runqslower/Makefile > > >> @@ -5,6 +5,7 @@ LLC :=3D llc > > >> LLVM_STRIP :=3D llvm-strip > > >> DEFAULT_BPFTOOL :=3D $(OUTPUT)/sbin/bpftool > > >> BPFTOOL ?=3D $(DEFAULT_BPFTOOL) > > >> +INCLUDES :=3D -I$(OUTPUT) -I$(abspath ../../lib) -I$(abspath ../../= lib/bpf) > > >> LIBBPF_SRC :=3D $(abspath ../../lib/bpf) > > > > > > drop LIBBPF_SRC, it's not used anymore > > > > It is: in the rule for building libbpf there's a '-C $(LIBBPF_SRC)' > > > > Ah, right, missed that one. Looked a bit weird to have $(abspath > ../../lib/bpf) used in INCLUDES and then separate LIBBPF_SRC > definition there, maybe > > LIBBPF_SRC :=3D $(abspath ../../lib/bpf) > INCLUDES :=3D -I$(OUTPUT) -I$(abspath ../../lib) -I$(LIBBPF_SRC) Never mind, you delete it in later patch anyway. > > > -Toke > >