From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.6 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9C478C33C9E for ; Wed, 15 Jan 2020 01:44:11 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 6CC6124658 for ; Wed, 15 Jan 2020 01:44:10 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="BEdqIWMc" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728880AbgAOBoK (ORCPT ); Tue, 14 Jan 2020 20:44:10 -0500 Received: from mail-qt1-f194.google.com ([209.85.160.194]:36997 "EHLO mail-qt1-f194.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728844AbgAOBoJ (ORCPT ); Tue, 14 Jan 2020 20:44:09 -0500 Received: by mail-qt1-f194.google.com with SMTP id w47so14411451qtk.4; Tue, 14 Jan 2020 17:44:09 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=3mqVS9DBlywDqi6+FLa7SAx2QVby5ixPoTqqNPEq/SI=; b=BEdqIWMcigy95FTOqkMhBm6SqvqHkay54i3OrWQ9tn8p+gcmOhFBFE+AIAgb0WBB9H aVUdEt1HPMPcNhHbV6UPn6CwculVGW7roiZu80l2hbBkX1kACLRPG6QOkQmi+174+8MW dNCaoKYp6g/vVB3MT3WKCXj5Lc6IVZJoFqGg52yRMR0RBPQC+DxH1yvxGRuj9n9BSEZ7 zInbMenJlfQ0ZHJD7ZpoxfdSNkRzxebbHU8Vk/Sme4FVG0jsf2k3pLRmzXreq36wThFo KXBUistE9fC+eiKtStSttrKt/lYRCiUtT+jLPoNEwo8i29khmuJ4lRawevuECDKpr6RD wo+g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=3mqVS9DBlywDqi6+FLa7SAx2QVby5ixPoTqqNPEq/SI=; b=Mun0xdwENSust4vqGNU3hQqbu341RfT1qBA/ZC0c8Fx+UvAUYChNgU6du60QBi9LCy 1Qwr2wK+EF+35Eq6SgaM4ck0QmEuO1v8AXUNVGHk5dsGG0AdzXbCf6gfrU/XpZdPc2Q5 LVekXBCbjF8igzN2S9T/TFHGTBaDWQqf7yQM4pb1E93jRMR79ZulvydiN1VDz9p8mvuQ PIPaDPxaJmkF2Nme/Dn+skNnTB4zh3WktiBsgLOAcIAN6DNMdyI/oyBhZ8MAXIevs2Cl 6kNZLfSAX08nVJBER+ji/A9YvPgR9Jq5g6NU0uG7WkhZVcSU/vL1t3iX4bgaioL2q5bz Fs+Q== X-Gm-Message-State: APjAAAWJJNuUlec7ZR4qty9/6V5lSQ7qTDzzSMqZzld1sIU+Pd3sLKa9 p0DdIcBgHqZzU5xeRVM62QZjKacOL7Uiw5poOX71Nw== X-Google-Smtp-Source: APXvYqy8Tx/IxYllo8dsmo0WKCJkCI7Qpn9qZbrfssr5ba37Rgkc6gNouqVKYXJWZJwcDSs9hwHmMnquI7IBEWLOkPk= X-Received: by 2002:ac8:4050:: with SMTP id j16mr1400451qtl.171.1579052648893; Tue, 14 Jan 2020 17:44:08 -0800 (PST) MIME-Version: 1.0 References: <20200114224358.3027079-1-kafai@fb.com> <20200114224412.3028054-1-kafai@fb.com> In-Reply-To: <20200114224412.3028054-1-kafai@fb.com> From: Andrii Nakryiko Date: Tue, 14 Jan 2020 17:43:58 -0800 Message-ID: Subject: Re: [PATCH bpf-next 3/5] libbpf: Expose bpf_find_kernel_btf to libbpf_internal.h To: Martin KaFai Lau Cc: bpf , Alexei Starovoitov , Daniel Borkmann , David Miller , Kernel Team , Networking Content-Type: text/plain; charset="UTF-8" Sender: bpf-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: bpf@vger.kernel.org On Tue, Jan 14, 2020 at 2:44 PM Martin KaFai Lau wrote: > > This patch exposes bpf_find_kernel_btf() to libbpf_internal.h. > It will be used in 'bpftool map dump' in a following patch > to dump a map with btf_vmlinux_value_type_id set. > > Signed-off-by: Martin KaFai Lau > --- This function comes up not a first time, I guess it makes sense to finally make it a public API. We should also try to minimize number of internal APIs used by bpftool. So if no one objects to expose it, should we call it a bit more precisely and according to libbpf naming guidelines: libbpf_load_kernel_btf? libbpf_find_kernel_btf is acceptable, but it does more than just finding, thus "load". It should also probably live in btf.c+btf.h? WDYT? > tools/lib/bpf/libbpf.c | 3 +-- > tools/lib/bpf/libbpf_internal.h | 1 + > 2 files changed, 2 insertions(+), 2 deletions(-) > [...]