From: Andrii Nakryiko <andrii.nakryiko@gmail.com>
To: Brian Vazquez <brianvv@google.com>
Cc: Brian Vazquez <brianvv.kernel@gmail.com>,
Alexei Starovoitov <ast@kernel.org>,
Daniel Borkmann <daniel@iogearbox.net>,
"David S . Miller" <davem@davemloft.net>,
Yonghong Song <yhs@fb.com>, Stanislav Fomichev <sdf@google.com>,
Petar Penkov <ppenkov@google.com>,
Willem de Bruijn <willemb@google.com>,
open list <linux-kernel@vger.kernel.org>,
Networking <netdev@vger.kernel.org>, bpf <bpf@vger.kernel.org>
Subject: Re: [PATCH v5 bpf-next 7/9] libbpf: add libbpf support to batch ops
Date: Wed, 15 Jan 2020 12:20:52 -0800 [thread overview]
Message-ID: <CAEf4BzYR2cNC_O6c8Fu4HtAny-XJaGafpDCMGhuj4-ubQ14vRw@mail.gmail.com> (raw)
In-Reply-To: <20200115184308.162644-8-brianvv@google.com>
On Wed, Jan 15, 2020 at 10:43 AM Brian Vazquez <brianvv@google.com> wrote:
>
> From: Yonghong Song <yhs@fb.com>
>
> Added four libbpf API functions to support map batch operations:
> . int bpf_map_delete_batch( ... )
> . int bpf_map_lookup_batch( ... )
> . int bpf_map_lookup_and_delete_batch( ... )
> . int bpf_map_update_batch( ... )
>
> Signed-off-by: Yonghong Song <yhs@fb.com>
> ---
> tools/lib/bpf/bpf.c | 58 ++++++++++++++++++++++++++++++++++++++++
> tools/lib/bpf/bpf.h | 22 +++++++++++++++
> tools/lib/bpf/libbpf.map | 4 +++
> 3 files changed, 84 insertions(+)
>
> diff --git a/tools/lib/bpf/bpf.c b/tools/lib/bpf/bpf.c
> index 500afe478e94a..317727d612149 100644
> --- a/tools/lib/bpf/bpf.c
> +++ b/tools/lib/bpf/bpf.c
> @@ -452,6 +452,64 @@ int bpf_map_freeze(int fd)
> return sys_bpf(BPF_MAP_FREEZE, &attr, sizeof(attr));
> }
>
> +static int bpf_map_batch_common(int cmd, int fd, void *in_batch,
> + void *out_batch, void *keys, void *values,
> + __u32 *count,
> + const struct bpf_map_batch_opts *opts)
> +{
> + union bpf_attr attr = {};
this is not a big issue and I don't want to delay landing your
patches, so maybe you can follow up with another patch. But this '=
{}' part is a complete waste because you do memset below.
> + int ret;
> +
> + if (!OPTS_VALID(opts, bpf_map_batch_opts))
> + return -EINVAL;
> +
> + memset(&attr, 0, sizeof(attr));
> + attr.batch.map_fd = fd;
> + attr.batch.in_batch = ptr_to_u64(in_batch);
> + attr.batch.out_batch = ptr_to_u64(out_batch);
> + attr.batch.keys = ptr_to_u64(keys);
> + attr.batch.values = ptr_to_u64(values);
> + attr.batch.count = *count;
> + attr.batch.elem_flags = OPTS_GET(opts, elem_flags, 0);
> + attr.batch.flags = OPTS_GET(opts, flags, 0);
> +
> + ret = sys_bpf(cmd, &attr, sizeof(attr));
> + *count = attr.batch.count;
> +
> + return ret;
> +}
> +
[...]
next prev parent reply other threads:[~2020-01-15 20:21 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-15 18:42 [PATCH v5 bpf-next 0/9] add bpf batch ops to process more than 1 elem Brian Vazquez
2020-01-15 18:43 ` [PATCH v5 bpf-next 1/9] bpf: add bpf_map_{value_size,update_value,map_copy_value} functions Brian Vazquez
2020-01-15 18:43 ` [PATCH v5 bpf-next 2/9] bpf: add generic support for lookup batch op Brian Vazquez
2020-01-15 18:43 ` [PATCH v5 bpf-next 3/9] bpf: add generic support for update and delete batch ops Brian Vazquez
2020-01-15 18:43 ` [PATCH v5 bpf-next 4/9] bpf: add lookup and update batch ops to arraymap Brian Vazquez
2020-01-15 18:43 ` [PATCH v5 bpf-next 5/9] bpf: add batch ops to all htab bpf map Brian Vazquez
2020-01-15 18:43 ` [PATCH v5 bpf-next 6/9] tools/bpf: sync uapi header bpf.h Brian Vazquez
2020-01-15 18:43 ` [PATCH v5 bpf-next 7/9] libbpf: add libbpf support to batch ops Brian Vazquez
2020-01-15 20:20 ` Andrii Nakryiko [this message]
2020-01-15 18:43 ` [PATCH v5 bpf-next 8/9] selftests/bpf: add batch ops testing for htab and htab_percpu map Brian Vazquez
2020-01-15 18:43 ` [PATCH v5 bpf-next 9/9] selftests/bpf: add batch ops testing to array bpf map Brian Vazquez
2020-01-15 20:13 ` [PATCH v5 bpf-next 0/9] add bpf batch ops to process more than 1 elem Yonghong Song
2020-01-15 22:09 ` Alexei Starovoitov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAEf4BzYR2cNC_O6c8Fu4HtAny-XJaGafpDCMGhuj4-ubQ14vRw@mail.gmail.com \
--to=andrii.nakryiko@gmail.com \
--cc=ast@kernel.org \
--cc=bpf@vger.kernel.org \
--cc=brianvv.kernel@gmail.com \
--cc=brianvv@google.com \
--cc=daniel@iogearbox.net \
--cc=davem@davemloft.net \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=ppenkov@google.com \
--cc=sdf@google.com \
--cc=willemb@google.com \
--cc=yhs@fb.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).