bpf.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Andrii Nakryiko <andrii.nakryiko@gmail.com>
To: Dave Tucker <dave@dtucker.co.uk>
Cc: bpf <bpf@vger.kernel.org>, Jonathan Corbet <corbet@lwn.net>,
	Alexei Starovoitov <ast@kernel.org>,
	Daniel Borkmann <daniel@iogearbox.net>,
	Andrii Nakryiko <andrii@kernel.org>, Martin Lau <kafai@fb.com>,
	Song Liu <songliubraving@fb.com>,
	john fastabend <john.fastabend@gmail.com>,
	KP Singh <kpsingh@kernel.org>,
	Linux Doc Mailing List <linux-doc@vger.kernel.org>
Subject: Re: [PATCH v2 bpf-next 2/2] bpf, docs: document BPF_MAP_TYPE_ARRAY
Date: Thu, 2 Dec 2021 12:08:55 -0800	[thread overview]
Message-ID: <CAEf4BzYYMwGZ10NuZZCYVb=e8bpf3vkLYn_g0B7Roi5cPJRrCw@mail.gmail.com> (raw)
In-Reply-To: <9b20a6e558008b8d422db1008dd2b5c8ff18ce46.1637684071.git.dave@dtucker.co.uk>

On Tue, Nov 23, 2021 at 8:24 AM Dave Tucker <dave@dtucker.co.uk> wrote:
>
> This commit adds documentation for the BPF_MAP_TYPE_ARRAY including
> kernel version introduced, usage and examples.
> It also documents BPF_MAP_TYPE_PERCPU_ARRAY since this is similar.
>
> Signed-off-by: Dave Tucker <dave@dtucker.co.uk>
> ---

It looks good, thanks for the update. But it seems like all the
Documentation/bpf/*.rst are 80-char wrapped, can you please wrap the
lines to fit within 80 characters for consistency? It also helps
immensely when reading source text files and not the HTML-rendered
version.

>  Documentation/bpf/map_array.rst | 172 ++++++++++++++++++++++++++++++++
>  1 file changed, 172 insertions(+)
>  create mode 100644 Documentation/bpf/map_array.rst
>

[...]

  parent reply	other threads:[~2021-12-02 20:09 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-11-23 16:24 [PATCH v2 bpf-next 0/2] bpf, docs: Document BPF_MAP_TYPE_ARRAY Dave Tucker
2021-11-23 16:24 ` [PATCH v2 bpf-next 1/2] bpf, docs: add kernel version to map_cgroup_storage Dave Tucker
2021-11-23 16:24   ` [PATCH v2 bpf-next 2/2] bpf, docs: document BPF_MAP_TYPE_ARRAY Dave Tucker
2021-11-27  2:05     ` Song Liu
2021-12-02 20:08     ` Andrii Nakryiko [this message]
2021-11-27  1:53   ` [PATCH v2 bpf-next 1/2] bpf, docs: add kernel version to map_cgroup_storage Song Liu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAEf4BzYYMwGZ10NuZZCYVb=e8bpf3vkLYn_g0B7Roi5cPJRrCw@mail.gmail.com' \
    --to=andrii.nakryiko@gmail.com \
    --cc=andrii@kernel.org \
    --cc=ast@kernel.org \
    --cc=bpf@vger.kernel.org \
    --cc=corbet@lwn.net \
    --cc=daniel@iogearbox.net \
    --cc=dave@dtucker.co.uk \
    --cc=john.fastabend@gmail.com \
    --cc=kafai@fb.com \
    --cc=kpsingh@kernel.org \
    --cc=linux-doc@vger.kernel.org \
    --cc=songliubraving@fb.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).