From: Andrii Nakryiko <andrii.nakryiko@gmail.com>
To: Allan Zhang <allanzhang@google.com>
Cc: Networking <netdev@vger.kernel.org>, bpf <bpf@vger.kernel.org>,
Song Liu <songliubraving@fb.com>,
Daniel Borkmann <daniel@iogearbox.net>,
Alexei Starovoitov <ast@kernel.org>
Subject: Re: [PATCH bpf-next v8 0/2] bpf: Allow bpf_skb_event_output for more prog types
Date: Wed, 10 Jul 2019 11:05:00 -0700 [thread overview]
Message-ID: <CAEf4BzYbOCYUsgAtOcUwO7_rFosfdhBPPLpq5ppj=f5foGWHzA@mail.gmail.com> (raw)
In-Reply-To: <20190709180005.33406-1-allanzhang@google.com>
On Tue, Jul 9, 2019 at 11:03 AM Allan Zhang <allanzhang@google.com> wrote:
>
> Software event output is only enabled by a few prog types right now (TC,
> LWT out, XDP, sockops). Many other skb based prog types need
> bpf_skb_event_output to produce software event.
>
> More prog types are enabled to access bpf_skb_event_output in this
> patch.
>
> v8 changes:
> No actual change, just cc to netdev@vger.kernel.org and
> bpf@vger.kernel.org.
> v7 patches are acked by Song Liu.
You forgot to include Song's Acked-by into your patch commit messages. Just add
Acked-by: Song Liu <songliubraving@fb.com>
to both patches after your Signed-off-by.
>
> v7 changes:
> Reformat from hints by scripts/checkpatch.pl, including Song's comment
> on signed-off-by name to captical case in cover letter.
> 3 of hints are ignored:
> 1. new file mode.
> 2. SPDX-License-Identifier for event_output.c since all files under
> this dir have no such line.
> 3. "Macros ... enclosed in parentheses" for macro in event_output.c
> due to code's nature.
>
> Change patch 02 subject "bpf:..." to "selftests/bpf:..."
>
> v6 changes:
> Fix Signed-off-by, fix fixup map creation.
>
> v5 changes:
> Fix typos, reformat comments in event_output.c, move revision history to
> cover letter.
>
> v4 changes:
> Reformating log message.
>
> v3 changes:
> Reformating log message.
>
> v2 changes:
> Reformating log message.
>
> Allan Zhang (2):
> bpf: Allow bpf_skb_event_output for a few prog types
> selftests/bpf: Add selftests for bpf_perf_event_output
>
> net/core/filter.c | 6 ++
> tools/testing/selftests/bpf/test_verifier.c | 12 ++-
> .../selftests/bpf/verifier/event_output.c | 94 +++++++++++++++++++
> 3 files changed, 111 insertions(+), 1 deletion(-)
> create mode 100644 tools/testing/selftests/bpf/verifier/event_output.c
>
> --
> 2.22.0.410.gd8fdbe21b5-goog
>
prev parent reply other threads:[~2019-07-10 18:05 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-09 18:00 [PATCH bpf-next v8 0/2] bpf: Allow bpf_skb_event_output for more prog types Allan Zhang
2019-07-09 18:00 ` [PATCH bpf-next v8 1/2] bpf: Allow bpf_skb_event_output for a few " Allan Zhang
2019-07-09 18:00 ` [PATCH bpf-next v8 2/2] selftests/bpf: Add selftests for bpf_perf_event_output Allan Zhang
2019-07-10 18:05 ` Andrii Nakryiko [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAEf4BzYbOCYUsgAtOcUwO7_rFosfdhBPPLpq5ppj=f5foGWHzA@mail.gmail.com' \
--to=andrii.nakryiko@gmail.com \
--cc=allanzhang@google.com \
--cc=ast@kernel.org \
--cc=bpf@vger.kernel.org \
--cc=daniel@iogearbox.net \
--cc=netdev@vger.kernel.org \
--cc=songliubraving@fb.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).