From: Andrii Nakryiko <andrii.nakryiko@gmail.com>
To: Andrei Matei <andreimatei1@gmail.com>
Cc: bpf <bpf@vger.kernel.org>, Alexei Starovoitov <ast@kernel.org>
Subject: Re: [PATCH bpf-next v2 4/5] selftest/bpf: move utility function to tests header
Date: Mon, 25 Jan 2021 18:33:56 -0800 [thread overview]
Message-ID: <CAEf4BzYncMLH8z0D-TMjzekSp0eAPw963dWg91uaKR+nFiBg8w@mail.gmail.com> (raw)
In-Reply-To: <20210124194909.453844-5-andreimatei1@gmail.com>
On Sun, Jan 24, 2021 at 11:54 AM Andrei Matei <andreimatei1@gmail.com> wrote:
>
> get_base_addr is generally useful for tests attaching uprobes. This
> patch moves it from one particular test to test_progs.{h,c}. The
> function will be used by a second test in the next patch.
>
> Signed-off-by: Andrei Matei <andreimatei1@gmail.com>
> ---
trace_helpers.{c,h} seem more appropriate as a destination
> .../selftests/bpf/prog_tests/attach_probe.c | 21 ----------------
> tools/testing/selftests/bpf/test_progs.c | 25 +++++++++++++++++++
> tools/testing/selftests/bpf/test_progs.h | 1 +
> 3 files changed, 26 insertions(+), 21 deletions(-)
>
> diff --git a/tools/testing/selftests/bpf/prog_tests/attach_probe.c b/tools/testing/selftests/bpf/prog_tests/attach_probe.c
> index a0ee87c8e1ea..3bda8acbbafb 100644
> --- a/tools/testing/selftests/bpf/prog_tests/attach_probe.c
> +++ b/tools/testing/selftests/bpf/prog_tests/attach_probe.c
> @@ -2,27 +2,6 @@
> #include <test_progs.h>
> #include "test_attach_probe.skel.h"
>
[...]
next prev parent reply other threads:[~2021-01-26 5:38 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-24 19:49 [PATCH bpf-next v2 0/5] bpf: allow variable-offset stack access Andrei Matei
2021-01-24 19:49 ` [PATCH bpf-next v2 1/5] " Andrei Matei
2021-01-27 22:58 ` Alexei Starovoitov
2021-01-30 22:55 ` Andrei Matei
2021-02-02 0:22 ` Alexei Starovoitov
2021-02-07 1:11 ` Andrei Matei
2021-01-24 19:49 ` [PATCH bpf-next v2 2/5] selftest/bpf: adjust expected verifier errors Andrei Matei
2021-01-24 19:49 ` [PATCH bpf-next v2 3/5] selftest/bpf: verifier tests for var-off access Andrei Matei
2021-01-24 19:49 ` [PATCH bpf-next v2 4/5] selftest/bpf: move utility function to tests header Andrei Matei
2021-01-26 2:33 ` Andrii Nakryiko [this message]
2021-01-24 19:49 ` [PATCH bpf-next v2 5/5] selftest/bpf: add test for var-offset stack access Andrei Matei
2021-01-26 2:37 ` Andrii Nakryiko
2021-02-07 1:11 ` Andrei Matei
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAEf4BzYncMLH8z0D-TMjzekSp0eAPw963dWg91uaKR+nFiBg8w@mail.gmail.com \
--to=andrii.nakryiko@gmail.com \
--cc=andreimatei1@gmail.com \
--cc=ast@kernel.org \
--cc=bpf@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).