From: Andrii Nakryiko <andrii.nakryiko@gmail.com>
To: Lorenz Bauer <lmb@cloudflare.com>
Cc: Alexei Starovoitov <ast@kernel.org>,
Daniel Borkmann <daniel@iogearbox.net>,
Andrii Nakryiko <andrii@kernel.org>,
Jakub Sitnicki <jakub@cloudflare.com>,
kernel-team <kernel-team@cloudflare.com>,
bpf <bpf@vger.kernel.org>, Networking <netdev@vger.kernel.org>
Subject: Re: [PATCH bpf-next 0/8] PROG_TEST_RUN support for sk_lookup programs
Date: Mon, 22 Feb 2021 23:29:34 -0800 [thread overview]
Message-ID: <CAEf4BzYuvE-RsT5Ee+FstZ=vuy3AMd+1j7DazFSb56+hfPKPig@mail.gmail.com> (raw)
In-Reply-To: <20210216105713.45052-1-lmb@cloudflare.com>
On Tue, Feb 16, 2021 at 2:58 AM Lorenz Bauer <lmb@cloudflare.com> wrote:
>
> We don't have PROG_TEST_RUN support for sk_lookup programs at the
> moment. So far this hasn't been a problem, since we can run our
> tests in a separate network namespace. For benchmarking it's nice
> to have PROG_TEST_RUN, so I've gone and implemented it.
>
> Multiple sk_lookup programs can be attached at once to the same
> netns. This can't be expressed with the current PROG_TEST_RUN
> API, so I'm proposing to extend it with an array of prog_fd.
>
> Patches 1-2 are clean ups. Patches 3-4 add the new UAPI and
> implement PROG_TEST_RUN for sk_lookup. Patch 5 adds a new
> function to libbpf to access multi prog tests. Patches 6-8 add
> tests.
>
> Andrii, for patch 4 I decided on the following API:
>
> int bpf_prog_test_run_array(__u32 *prog_fds, __u32 prog_fds_cnt,
> struct bpf_test_run_opts *opts)
>
> To be consistent with the rest of libbpf it would be better
> to take int *prog_fds, but I think then the function would have to
> convert the array to account for platforms where
>
> sizeof(int) != sizeof(__u32)
Curious, is there any supported architecture where this is not the
case? I think it's fine to be consistent, tbh, and use int. Worst
case, in some obscure architecture we'd need to create a copy of an
array. Doesn't seem like a big deal (and highly unlikely anyways).
>
> Please let me know what your preference is.
>
> Lorenz Bauer (8):
> bpf: consolidate shared test timing code
> bpf: add for_each_bpf_prog helper
> bpf: allow multiple programs in BPF_PROG_TEST_RUN
> bpf: add PROG_TEST_RUN support for sk_lookup programs
> tools: libbpf: allow testing program types with multi-prog semantics
> selftests: bpf: convert sk_lookup multi prog tests to PROG_TEST_RUN
> selftests: bpf: convert sk_lookup ctx access tests to PROG_TEST_RUN
> selftests: bpf: check that PROG_TEST_RUN repeats as requested
>
> include/linux/bpf-netns.h | 2 +
> include/linux/bpf.h | 24 +-
> include/linux/filter.h | 4 +-
> include/uapi/linux/bpf.h | 11 +-
> kernel/bpf/net_namespace.c | 2 +-
> kernel/bpf/syscall.c | 73 +++++-
> net/bpf/test_run.c | 230 +++++++++++++-----
> net/core/filter.c | 1 +
> tools/include/uapi/linux/bpf.h | 11 +-
> tools/lib/bpf/bpf.c | 16 +-
> tools/lib/bpf/bpf.h | 3 +
> tools/lib/bpf/libbpf.map | 1 +
> .../selftests/bpf/prog_tests/prog_run_xattr.c | 51 +++-
> .../selftests/bpf/prog_tests/sk_lookup.c | 172 +++++++++----
> .../selftests/bpf/progs/test_sk_lookup.c | 62 +++--
> 15 files changed, 499 insertions(+), 164 deletions(-)
>
> --
> 2.27.0
>
next prev parent reply other threads:[~2021-02-23 7:30 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-02-16 10:57 [PATCH bpf-next 0/8] PROG_TEST_RUN support for sk_lookup programs Lorenz Bauer
2021-02-16 10:57 ` [PATCH bpf-next 1/8] bpf: consolidate shared test timing code Lorenz Bauer
2021-02-16 10:57 ` [PATCH bpf-next 2/8] bpf: add for_each_bpf_prog helper Lorenz Bauer
2021-02-16 10:57 ` [PATCH bpf-next 3/8] bpf: allow multiple programs in BPF_PROG_TEST_RUN Lorenz Bauer
2021-02-16 10:57 ` [PATCH bpf-next 4/8] bpf: add PROG_TEST_RUN support for sk_lookup programs Lorenz Bauer
2021-02-23 1:11 ` Alexei Starovoitov
2021-02-23 10:10 ` Lorenz Bauer
2021-02-24 6:11 ` Alexei Starovoitov
2021-02-16 10:57 ` [PATCH bpf-next 5/8] tools: libbpf: allow testing program types with multi-prog semantics Lorenz Bauer
2021-02-16 10:57 ` [PATCH bpf-next 6/8] selftests: bpf: convert sk_lookup multi prog tests to PROG_TEST_RUN Lorenz Bauer
2021-02-16 10:57 ` [PATCH bpf-next 7/8] selftests: bpf: convert sk_lookup ctx access " Lorenz Bauer
2021-02-16 10:57 ` [PATCH bpf-next 8/8] selftests: bpf: check that PROG_TEST_RUN repeats as requested Lorenz Bauer
2021-02-17 20:08 ` [PATCH bpf-next 0/8] PROG_TEST_RUN support for sk_lookup programs John Fastabend
2021-02-23 7:29 ` Andrii Nakryiko [this message]
2021-02-23 10:12 ` Lorenz Bauer
2021-02-24 21:37 ` Daniel Borkmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAEf4BzYuvE-RsT5Ee+FstZ=vuy3AMd+1j7DazFSb56+hfPKPig@mail.gmail.com' \
--to=andrii.nakryiko@gmail.com \
--cc=andrii@kernel.org \
--cc=ast@kernel.org \
--cc=bpf@vger.kernel.org \
--cc=daniel@iogearbox.net \
--cc=jakub@cloudflare.com \
--cc=kernel-team@cloudflare.com \
--cc=lmb@cloudflare.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).